[jboss-svn-commits] JBL Code SVN: r24683 - in labs/jbossrules/trunk/drools-pipeline/drools-messenger-jms/src: test/java/org/drools/runtime/pipeline/impl and 1 other directory.

jboss-svn-commits at lists.jboss.org jboss-svn-commits at lists.jboss.org
Tue Jan 13 17:13:35 EST 2009


Author: mark.proctor at jboss.com
Date: 2009-01-13 17:13:35 -0500 (Tue, 13 Jan 2009)
New Revision: 24683

Modified:
   labs/jbossrules/trunk/drools-pipeline/drools-messenger-jms/src/main/java/org/drools/runtime/pipeline/impl/JmsMessenger.java
   labs/jbossrules/trunk/drools-pipeline/drools-messenger-jms/src/main/java/org/drools/runtime/pipeline/impl/JmsMessengerProviderImpl.java
   labs/jbossrules/trunk/drools-pipeline/drools-messenger-jms/src/main/java/org/drools/runtime/pipeline/impl/JmsUnwrapMessageObject.java
   labs/jbossrules/trunk/drools-pipeline/drools-messenger-jms/src/main/java/org/drools/runtime/pipeline/impl/JmsUnwrapText.java
   labs/jbossrules/trunk/drools-pipeline/drools-messenger-jms/src/test/java/org/drools/runtime/pipeline/impl/JaxbSimpleJmsMessengerTest.java
   labs/jbossrules/trunk/drools-pipeline/drools-messenger-jms/src/test/java/org/drools/runtime/pipeline/impl/SimpleConsumer.java
   labs/jbossrules/trunk/drools-pipeline/drools-messenger-jms/src/test/java/org/drools/runtime/pipeline/impl/SimpleJmsMessengerTest.java
Log:
JBRULES-1903 Pipeline support for DataLoaders and Feeders 
-code reformat and tidy
-remove bad import

Modified: labs/jbossrules/trunk/drools-pipeline/drools-messenger-jms/src/main/java/org/drools/runtime/pipeline/impl/JmsMessenger.java
===================================================================
--- labs/jbossrules/trunk/drools-pipeline/drools-messenger-jms/src/main/java/org/drools/runtime/pipeline/impl/JmsMessenger.java	2009-01-13 21:17:11 UTC (rev 24682)
+++ labs/jbossrules/trunk/drools-pipeline/drools-messenger-jms/src/main/java/org/drools/runtime/pipeline/impl/JmsMessenger.java	2009-01-13 22:13:35 UTC (rev 24683)
@@ -14,7 +14,6 @@
 import org.drools.runtime.pipeline.Pipeline;
 import org.drools.runtime.pipeline.ResultHandlerFactory;
 import org.drools.runtime.pipeline.Service;
-import org.drools.runtime.pipeline.impl.BaseService;
 
 public class JmsMessenger extends BaseService
     implements
@@ -39,7 +38,7 @@
         super();
         this.pipeline = pipeline;
         this.resultHandlerFactory = resultHandlerFactory;
-        
+
         try {
             InitialContext jndiContext = new InitialContext( properties );
             this.connectionFactory = (ConnectionFactory) jndiContext.lookup( "ConnectionFactory" );

Modified: labs/jbossrules/trunk/drools-pipeline/drools-messenger-jms/src/main/java/org/drools/runtime/pipeline/impl/JmsMessengerProviderImpl.java
===================================================================
--- labs/jbossrules/trunk/drools-pipeline/drools-messenger-jms/src/main/java/org/drools/runtime/pipeline/impl/JmsMessengerProviderImpl.java	2009-01-13 21:17:11 UTC (rev 24682)
+++ labs/jbossrules/trunk/drools-pipeline/drools-messenger-jms/src/main/java/org/drools/runtime/pipeline/impl/JmsMessengerProviderImpl.java	2009-01-13 22:13:35 UTC (rev 24683)
@@ -23,7 +23,7 @@
                                  destinationName,
                                  resultHandlerFactory );
     }
-    
+
     public Action newJmsUnwrapMessageObject() {
         return new JmsUnwrapMessageObject();
     }

Modified: labs/jbossrules/trunk/drools-pipeline/drools-messenger-jms/src/main/java/org/drools/runtime/pipeline/impl/JmsUnwrapMessageObject.java
===================================================================
--- labs/jbossrules/trunk/drools-pipeline/drools-messenger-jms/src/main/java/org/drools/runtime/pipeline/impl/JmsUnwrapMessageObject.java	2009-01-13 21:17:11 UTC (rev 24682)
+++ labs/jbossrules/trunk/drools-pipeline/drools-messenger-jms/src/main/java/org/drools/runtime/pipeline/impl/JmsUnwrapMessageObject.java	2009-01-13 22:13:35 UTC (rev 24683)
@@ -7,15 +7,21 @@
 import org.drools.runtime.pipeline.PipelineContext;
 import org.drools.runtime.pipeline.Receiver;
 
-public class JmsUnwrapMessageObject extends BaseEmitter implements Action, Receiver {
+public class JmsUnwrapMessageObject extends BaseEmitter
+    implements
+    Action,
+    Receiver {
 
     public void receive(Object object,
-                       PipelineContext context) {
+                        PipelineContext context) {
         try {
-            Object result = ((ObjectMessage)object).getObject();
-            emit( result, context );
+            Object result = ((ObjectMessage) object).getObject();
+            emit( result,
+                  context );
         } catch ( JMSException e ) {
-            handleException( this, object, e );
+            handleException( this,
+                             object,
+                             e );
         }
     }
 

Modified: labs/jbossrules/trunk/drools-pipeline/drools-messenger-jms/src/main/java/org/drools/runtime/pipeline/impl/JmsUnwrapText.java
===================================================================
--- labs/jbossrules/trunk/drools-pipeline/drools-messenger-jms/src/main/java/org/drools/runtime/pipeline/impl/JmsUnwrapText.java	2009-01-13 21:17:11 UTC (rev 24682)
+++ labs/jbossrules/trunk/drools-pipeline/drools-messenger-jms/src/main/java/org/drools/runtime/pipeline/impl/JmsUnwrapText.java	2009-01-13 22:13:35 UTC (rev 24683)
@@ -6,17 +6,22 @@
 import org.drools.runtime.pipeline.Emitter;
 import org.drools.runtime.pipeline.PipelineContext;
 import org.drools.runtime.pipeline.Receiver;
-import org.drools.runtime.pipeline.impl.BaseEmitter;
 
-public class JmsUnwrapText  extends BaseEmitter implements Receiver, Emitter {
+public class JmsUnwrapText extends BaseEmitter
+    implements
+    Receiver,
+    Emitter {
 
     public void receive(Object object,
-                       PipelineContext context) {
+                        PipelineContext context) {
         try {
-            String string = ((TextMessage)object).getText();
-            emit( string, context );
+            String string = ((TextMessage) object).getText();
+            emit( string,
+                  context );
         } catch ( JMSException e ) {
-            handleException( this, object, e );
+            handleException( this,
+                             object,
+                             e );
         }
     }
 

Modified: labs/jbossrules/trunk/drools-pipeline/drools-messenger-jms/src/test/java/org/drools/runtime/pipeline/impl/JaxbSimpleJmsMessengerTest.java
===================================================================
--- labs/jbossrules/trunk/drools-pipeline/drools-messenger-jms/src/test/java/org/drools/runtime/pipeline/impl/JaxbSimpleJmsMessengerTest.java	2009-01-13 21:17:11 UTC (rev 24682)
+++ labs/jbossrules/trunk/drools-pipeline/drools-messenger-jms/src/test/java/org/drools/runtime/pipeline/impl/JaxbSimpleJmsMessengerTest.java	2009-01-13 22:13:35 UTC (rev 24683)
@@ -30,12 +30,6 @@
 import org.drools.runtime.pipeline.ResultHandlerFactory;
 import org.drools.runtime.pipeline.Service;
 import org.drools.runtime.pipeline.Transformer;
-import org.drools.runtime.pipeline.impl.ExecuteResultHandler;
-import org.drools.runtime.pipeline.impl.JmsMessenger;
-import org.drools.runtime.pipeline.impl.JmsUnwrapMessageObject;
-import org.drools.runtime.pipeline.impl.StatefulKnowledgeSessionInsertStage;
-import org.drools.runtime.pipeline.impl.StatefulKnowledgeSessionPipelineImpl;
-import org.drools.runtime.pipeline.impl.JaxbFactTest.ResultHandlerImpl;
 import org.drools.runtime.rule.FactHandle;
 import org.drools.util.StringUtils;
 

Modified: labs/jbossrules/trunk/drools-pipeline/drools-messenger-jms/src/test/java/org/drools/runtime/pipeline/impl/SimpleConsumer.java
===================================================================
--- labs/jbossrules/trunk/drools-pipeline/drools-messenger-jms/src/test/java/org/drools/runtime/pipeline/impl/SimpleConsumer.java	2009-01-13 21:17:11 UTC (rev 24682)
+++ labs/jbossrules/trunk/drools-pipeline/drools-messenger-jms/src/test/java/org/drools/runtime/pipeline/impl/SimpleConsumer.java	2009-01-13 22:13:35 UTC (rev 24683)
@@ -25,10 +25,10 @@
     public static void main(String[] args) throws Exception {
         BrokerService broker = new BrokerService();
         // configure the broker
-        broker.setBrokerName("consumer");
-        broker.addConnector("tcp://localhost:61616");
+        broker.setBrokerName( "consumer" );
+        broker.addConnector( "tcp://localhost:61616" );
         broker.start();
-        
+
         Context jndiContext = null;
         ConnectionFactory connectionFactory = null;
         Connection connection = null;

Modified: labs/jbossrules/trunk/drools-pipeline/drools-messenger-jms/src/test/java/org/drools/runtime/pipeline/impl/SimpleJmsMessengerTest.java
===================================================================
--- labs/jbossrules/trunk/drools-pipeline/drools-messenger-jms/src/test/java/org/drools/runtime/pipeline/impl/SimpleJmsMessengerTest.java	2009-01-13 21:17:11 UTC (rev 24682)
+++ labs/jbossrules/trunk/drools-pipeline/drools-messenger-jms/src/test/java/org/drools/runtime/pipeline/impl/SimpleJmsMessengerTest.java	2009-01-13 22:13:35 UTC (rev 24683)
@@ -15,11 +15,6 @@
 import org.drools.runtime.StatefulKnowledgeSession;
 import org.drools.runtime.pipeline.ResultHandler;
 import org.drools.runtime.pipeline.ResultHandlerFactory;
-import org.drools.runtime.pipeline.impl.ExecuteResultHandler;
-import org.drools.runtime.pipeline.impl.JmsMessenger;
-import org.drools.runtime.pipeline.impl.JmsUnwrapMessageObject;
-import org.drools.runtime.pipeline.impl.StatefulKnowledgeSessionInsertStage;
-import org.drools.runtime.pipeline.impl.StatefulKnowledgeSessionPipelineImpl;
 import org.drools.runtime.rule.FactHandle;
 
 public class SimpleJmsMessengerTest extends TestCase {
@@ -58,8 +53,8 @@
         StatefulKnowledgeSession ksession = kbase.newStatefulKnowledgeSession();
 
         StatefulKnowledgeSessionPipelineImpl pipeline = new StatefulKnowledgeSessionPipelineImpl( ksession );
-        
-        JmsUnwrapMessageObject unwrapObjectStage = new JmsUnwrapMessageObject();        
+
+        JmsUnwrapMessageObject unwrapObjectStage = new JmsUnwrapMessageObject();
         StatefulKnowledgeSessionInsertStage insertStage = new StatefulKnowledgeSessionInsertStage();
         unwrapObjectStage.setReceiver( insertStage );
         ExecuteResultHandler resultHandlerStage = new ExecuteResultHandler();
@@ -68,15 +63,15 @@
 
         ResultHandleFactoryImpl factory = new ResultHandleFactoryImpl();
         JmsMessenger feeder = new JmsMessenger( pipeline,
-                                            props,
-                                            this.destinationName,
-                                            factory );
+                                                props,
+                                                this.destinationName,
+                                                factory );
         feeder.start();
         this.simpleProducer.sendObject( "hello" );
         this.simpleProducer.sendObject( "hello1" );
         this.simpleProducer.sendObject( "hello2" );
         this.simpleProducer.sendObject( "hello3" );
-        
+
         for ( int i = 0; i < 5; i++ ) {
             // iterate and sleep 5 times, to give these messages time to complete.
             if ( factory.list.size() == 4 ) {
@@ -84,24 +79,31 @@
             }
             Thread.sleep( 500 );
         }
-        
-        assertEquals( 4, factory.list.size() );
-        
-        FactHandle factHandle = ( FactHandle) ((Map)((ResultHandlerImpl)factory.list.get( 0 )).getObject()).keySet().iterator().next();
-        assertEquals( "hello", ksession.getObject( factHandle  ) );
-        
-        factHandle = ( FactHandle) ((Map)((ResultHandlerImpl)factory.list.get( 1 )).getObject()).keySet().iterator().next();
-        assertEquals( "hello1", ksession.getObject( factHandle  ) );
-        
-        factHandle = ( FactHandle) ((Map)((ResultHandlerImpl)factory.list.get( 2 )).getObject()).keySet().iterator().next();
-        assertEquals( "hello2", ksession.getObject( factHandle  ) );
-        
-        factHandle = ( FactHandle) ((Map)((ResultHandlerImpl)factory.list.get( 3 )).getObject()).keySet().iterator().next();
-        assertEquals( "hello3", ksession.getObject( factHandle  ) );
-        
+
+        assertEquals( 4,
+                      factory.list.size() );
+
+        FactHandle factHandle = (FactHandle) ((Map) ((ResultHandlerImpl) factory.list.get( 0 )).getObject()).keySet().iterator().next();
+        assertEquals( "hello",
+                      ksession.getObject( factHandle ) );
+
+        factHandle = (FactHandle) ((Map) ((ResultHandlerImpl) factory.list.get( 1 )).getObject()).keySet().iterator().next();
+        assertEquals( "hello1",
+                      ksession.getObject( factHandle ) );
+
+        factHandle = (FactHandle) ((Map) ((ResultHandlerImpl) factory.list.get( 2 )).getObject()).keySet().iterator().next();
+        assertEquals( "hello2",
+                      ksession.getObject( factHandle ) );
+
+        factHandle = (FactHandle) ((Map) ((ResultHandlerImpl) factory.list.get( 3 )).getObject()).keySet().iterator().next();
+        assertEquals( "hello3",
+                      ksession.getObject( factHandle ) );
+
     }
-    
-    public static class ResultHandleFactoryImpl implements ResultHandlerFactory {
+
+    public static class ResultHandleFactoryImpl
+        implements
+        ResultHandlerFactory {
         List list = new ArrayList();
 
         public ResultHandler newResultHandler() {
@@ -109,16 +111,20 @@
             list.add( handler );
             return handler;
         }
-        
+
     }
-    
-    public static class ResultHandlerImpl implements ResultHandler {
+
+    public static class ResultHandlerImpl
+        implements
+        ResultHandler {
         Object object;
+
         public void handleResult(Object object) {
-           this.object = object;             
+            this.object = object;
         }
+
         public Object getObject() {
             return this.object;
-        }       
-    }    
+        }
+    }
 }




More information about the jboss-svn-commits mailing list