[jboss-svn-commits] JBoss Common SVN: r3224 - jboss-logmanager/trunk/src/main/java/org/jboss/logmanager.

[jboss-svn-commits at lists.jboss.org]

Author: david.lloyd at jboss.com
Date: 2009-06-05 10:23:25 -0400 (Fri, 05 Jun 2009)
New Revision: 3224

Modified:
   jboss-logmanager/trunk/src/main/java/org/jboss/logmanager/ExtLogRecord.java
Log:
Fix an error in the call stack analysis algorithm

Modified: jboss-logmanager/trunk/src/main/java/org/jboss/logmanager/ExtLogRecord.java
===================================================================
--- jboss-logmanager/trunk/src/main/java/org/jboss/logmanager/ExtLogRecord.java	2009-06-05 00:41:54 UTC (rev 3223)
+++ jboss-logmanager/trunk/src/main/java/org/jboss/logmanager/ExtLogRecord.java	2009-06-05 14:23:25 UTC (rev 3224)
@@ -62,11 +62,7 @@
      * @param loggerClassName the name of the logger class
      */
     public ExtLogRecord(final java.util.logging.Level level, final String msg, final String loggerClassName) {
-        super(level, msg);
-        this.loggerClassName = loggerClassName;
-        ndc = NDC.get();
-        setUnknownCaller();
-        threadName = Thread.currentThread().getName();
+        this(level, msg, FormatStyle.MESSAGE_FORMAT, loggerClassName);
     }
 
     /**
@@ -82,7 +78,6 @@
         this.formatStyle = formatStyle == null ? FormatStyle.MESSAGE_FORMAT : formatStyle;
         this.loggerClassName = loggerClassName;
         ndc = NDC.get();
-        setUnknownCaller();
         threadName = Thread.currentThread().getName();
     }
 
@@ -186,12 +181,14 @@
         boolean found = false;
         for (StackTraceElement element : stack) {
             final String className = element.getClassName();
-            if (found && ! loggerClassName.equals(className)) {
-                setSourceClassName(className);
-                setSourceMethodName(element.getMethodName());
-                setSourceLineNumber(element.getLineNumber());
-                setSourceFileName(element.getFileName());
-                return;
+            if (found) {
+                if (! loggerClassName.equals(className)) {
+                    setSourceClassName(className);
+                    setSourceMethodName(element.getMethodName());
+                    setSourceLineNumber(element.getLineNumber());
+                    setSourceFileName(element.getFileName());
+                    return;
+                }
             } else {
                 found = loggerClassName.equals(className);
             }