[jboss-svn-commits] JBoss Common SVN: r3302 - jboss-logmanager/trunk/src/main/java/org/jboss/logmanager/formatters.

[jboss-svn-commits at lists.jboss.org]

Author: david.lloyd at jboss.com
Date: 2009-06-22 19:35:46 -0400 (Mon, 22 Jun 2009)
New Revision: 3302

Modified:
   jboss-logmanager/trunk/src/main/java/org/jboss/logmanager/formatters/Formatters.java
Log:
Minor performance buffs

Modified: jboss-logmanager/trunk/src/main/java/org/jboss/logmanager/formatters/Formatters.java
===================================================================
--- jboss-logmanager/trunk/src/main/java/org/jboss/logmanager/formatters/Formatters.java	2009-06-22 20:08:13 UTC (rev 3301)
+++ jboss-logmanager/trunk/src/main/java/org/jboss/logmanager/formatters/Formatters.java	2009-06-22 23:35:46 UTC (rev 3302)
@@ -125,11 +125,12 @@
                 renderRaw(builder, record);
                 final int newLen = builder.length();
                 // if we exceeded the max width, chop it off
-                final int overflow = (newLen - oldLen) - maximumWidth;
+                final int writtenLen = newLen - oldLen;
+                final int overflow = writtenLen - maximumWidth;
                 if (overflow > 0) {
                     builder.setLength(newLen - overflow);
                 } else {
-                    final int spaces = minimumWidth - (newLen - oldLen);
+                    final int spaces = minimumWidth - writtenLen;
                     for (int i = 0; i < spaces; i ++) {
                         builder.append(' ');
                     }
@@ -153,6 +154,8 @@
         }
 
         public int estimateLength() {
+            final int maximumWidth = this.maximumWidth;
+            final int minimumWidth = this.minimumWidth;
             if (maximumWidth != 0) {
                 return min(maximumWidth, minimumWidth * 3);
             } else {
@@ -227,9 +230,12 @@
         return new JustifyingFormatStep(leftJustify, minimumWidth, maximumWidth) {
             public void renderRaw(final StringBuilder builder, final ExtLogRecord record) {
                 final SimpleDateFormat dateFormat = dateFormatMaster;
+                final String formatted;
+                final Date date = new Date(record.getMillis());
                 synchronized (dateFormat) {
-                    builder.append(dateFormat.format(new Date(record.getMillis())));
+                    formatted = dateFormat.format(date);
                 }
+                builder.append(formatted);
             }
         };
     }