[jboss-svn-commits] JBL Code SVN: r25715 - labs/jbossrules/trunk/drools-repository/src/main/java/org/drools/repository.

[jboss-svn-commits at lists.jboss.org]

Author: michael.neale at jboss.com
Date: 2009-03-18 19:24:52 -0400 (Wed, 18 Mar 2009)
New Revision: 25715

Modified:
   labs/jbossrules/trunk/drools-repository/src/main/java/org/drools/repository/RulesRepository.java
Log:
tidied up exception handling

Modified: labs/jbossrules/trunk/drools-repository/src/main/java/org/drools/repository/RulesRepository.java
===================================================================
--- labs/jbossrules/trunk/drools-repository/src/main/java/org/drools/repository/RulesRepository.java	2009-03-18 17:40:06 UTC (rev 25714)
+++ labs/jbossrules/trunk/drools-repository/src/main/java/org/drools/repository/RulesRepository.java	2009-03-18 23:24:52 UTC (rev 25715)
@@ -471,7 +471,7 @@
             long start = System.currentTimeMillis();
             this.session.getWorkspace().copy( source,
                                               newName );
-            System.err.println("Time taken for snap: " + (System.currentTimeMillis() - start));
+            log.debug("Time taken for snap: " + (System.currentTimeMillis() - start));
 
         } catch ( RepositoryException e ) {
             log.error( "Unable to create snapshot",
@@ -918,7 +918,7 @@
                                       false );
         } catch (Exception e) {
             log.error(e);
-            e.printStackTrace();
+            throw new RulesRepositoryException(e);
         }
 
     }
@@ -986,10 +986,12 @@
                 mig.migrate( this );
             }
         } catch ( RepositoryException e ) {
-            e.printStackTrace();
-            throw new RulesRepositoryException();
+            log.error(e);
+            throw new RulesRepositoryException("Repository error when importing from stream.", e);
         } catch ( IOException e ) {
-            e.printStackTrace();
+            log.error(e);
+            throw new RulesRepositoryException(e);
+
         }
     }
 
@@ -1015,10 +1017,11 @@
                 mig.migrate( this );
             }
         } catch ( RepositoryException e ) {
-            e.printStackTrace();
-            throw new RulesRepositoryException();
+            log.error(e);
+            throw new RulesRepositoryException(e);
         } catch ( IOException e ) {
-            e.printStackTrace();
+            log.error(e);
+            throw new RulesRepositoryException(e);
         }
     }
 
@@ -1248,7 +1251,6 @@
             return new AssetItemIterator( res.getNodes(),
                                           this );
         } catch ( RepositoryException e ) {
-            System.out.println( e.getMessage() );
             throw new RulesRepositoryException( e );
         }
     }
@@ -1276,7 +1278,6 @@
             return new AssetItemIterator( res.getNodes(),
                                           this );
         } catch ( RepositoryException e ) {
-            System.out.println( e.getMessage() );
             throw new RulesRepositoryException( e );
         }
     }
@@ -1300,7 +1301,6 @@
             return new AssetItemIterator( res.getNodes(),
                                           this );
         } catch ( RepositoryException e ) {
-            System.out.println( e.getMessage() );
             throw new RulesRepositoryException( e );
         }
     }
@@ -1356,7 +1356,6 @@
                 }
             }
 
-            System.out.println( sql );
 
             Query q = this.session.getWorkspace().getQueryManager().createQuery( sql,
                                                                                  Query.SQL );
@@ -1366,7 +1365,6 @@
             return new AssetItemIterator( res.getNodes(),
                                           this );
         } catch ( RepositoryException e ) {
-            System.out.println( e.getMessage() );
             throw new RulesRepositoryException( e );
         }
     }
@@ -1455,7 +1453,7 @@
         try {
             this.logout();
         } catch ( Exception e ) {
-            System.err.println( "Finalizer error: " + e.getMessage() );
+            log.error( "Finalizer error: " + e.getMessage() );
         }
     }
 }
\ No newline at end of file