[jboss-svn-commits] JBL Code SVN: r26522 - in labs/jbossrules/trunk: drools-compiler/src/main/java/org/drools/compiler and 31 other directories.

jboss-svn-commits at lists.jboss.org jboss-svn-commits at lists.jboss.org
Wed May 13 22:17:07 EDT 2009


Author: mark.proctor at jboss.com
Date: 2009-05-13 22:17:06 -0400 (Wed, 13 May 2009)
New Revision: 26522

Modified:
   labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/commons/jci/compilers/EclipseCompilationProblem.java
   labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/commons/jci/compilers/EclipseJavaCompiler.java
   labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/commons/jci/compilers/JaninoCompilationProblem.java
   labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/compiler/ActionError.java
   labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/compiler/DescrBuildError.java
   labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/compiler/DrlParser.java
   labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/compiler/FunctionError.java
   labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/compiler/PackageBuilder.java
   labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/compiler/PackageBuilderErrors.java
   labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/guvnor/client/modeldriven/brl/RuleAttribute.java
   labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/guvnor/client/modeldriven/brl/RuleMetadata.java
   labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/guvnor/client/modeldriven/testing/Scenario.java
   labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/guvnor/server/util/BRDRLPersistence.java
   labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/guvnor/server/util/DataEnumLoader.java
   labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/lang/DrlDumper.java
   labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/lang/MVELDumper.java
   labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/lang/descr/AccessorDescr.java
   labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/lang/descr/RestrictionConnectiveDescr.java
   labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/lang/dsl/AntlrDSLMappingEntry.java
   labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/lang/dsl/DSLMapWalker.java
   labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/lang/dsl/DSLMappingFile.java
   labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/lang/dsl/DefaultExpander.java
   labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/rule/builder/dialect/java/JavaAccumulateBuilder.java
   labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/rule/builder/dialect/java/JavaProcessClassBuilder.java
   labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/rule/builder/dialect/java/JavaRuleClassBuilder.java
   labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/rule/builder/dialect/java/parser/JavaParser.java
   labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/rule/builder/dialect/mvel/MVELActionBuilder.java
   labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/rule/builder/dialect/mvel/MVELConsequenceBuilder.java
   labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/rule/builder/dialect/mvel/MVELReturnValueEvaluatorBuilder.java
   labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/xml/XmlDumper.java
   labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/xml/XmlWorkflowProcessDumper.java
   labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/xml/processes/AbstractNodeHandler.java
   labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/xml/processes/ActionNodeHandler.java
   labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/xml/processes/CompositeNodeHandler.java
   labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/xml/processes/EndNodeHandler.java
   labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/xml/processes/EventNodeHandler.java
   labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/xml/processes/FaultNodeHandler.java
   labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/xml/processes/ForEachNodeHandler.java
   labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/xml/processes/HumanTaskNodeHandler.java
   labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/xml/processes/JoinNodeHandler.java
   labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/xml/processes/MilestoneNodeHandler.java
   labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/xml/processes/RuleFlowMigrator.java
   labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/xml/processes/RuleSetNodeHandler.java
   labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/xml/processes/SplitNodeHandler.java
   labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/xml/processes/StartNodeHandler.java
   labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/xml/processes/StateNodeHandler.java
   labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/xml/processes/SubProcessNodeHandler.java
   labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/xml/processes/TimerNodeHandler.java
   labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/xml/processes/WorkItemNodeHandler.java
   labs/jbossrules/trunk/drools-compiler/src/main/resources/org/drools/lang/dsl/DSLMapWalker.g
   labs/jbossrules/trunk/drools-compiler/src/main/resources/org/drools/semantics/java/parser/Java.g
   labs/jbossrules/trunk/drools-compiler/src/test/java/org/drools/guvnor/modeldriven/DataEnumLoaderTest.java
   labs/jbossrules/trunk/drools-compiler/src/test/java/org/drools/guvnor/server/util/BRLPersitenceTest.java
   labs/jbossrules/trunk/drools-compiler/src/test/java/org/drools/integrationtests/LargeRuleBase.java
   labs/jbossrules/trunk/drools-compiler/src/test/java/org/drools/integrationtests/PackageBuilderThreadSafetyTest.java
   labs/jbossrules/trunk/drools-compiler/src/test/java/org/drools/lang/ErrorsParserTest.java
   labs/jbossrules/trunk/drools-compiler/src/test/java/org/drools/lang/RuleParserTest.java
   labs/jbossrules/trunk/drools-compiler/src/test/java/org/drools/xml/rules/DumperTestHelper.java
   labs/jbossrules/trunk/drools-core/src/main/java/org/drools/agent/FileScanner.java
   labs/jbossrules/trunk/drools-core/src/main/java/org/drools/audit/WorkingMemoryLogger.java
   labs/jbossrules/trunk/drools-core/src/main/java/org/drools/base/ClassTypeResolver.java
   labs/jbossrules/trunk/drools-core/src/main/java/org/drools/factmodel/ClassBuilder.java
   labs/jbossrules/trunk/drools-core/src/main/java/org/drools/facttemplates/FactTemplateImpl.java
   labs/jbossrules/trunk/drools-core/src/main/java/org/drools/process/core/context/variable/Variable.java
   labs/jbossrules/trunk/drools-core/src/main/java/org/drools/process/instance/impl/ProcessInstanceImpl.java
   labs/jbossrules/trunk/drools-core/src/main/java/org/drools/reteoo/LeftTuple.java
   labs/jbossrules/trunk/drools-core/src/main/java/org/drools/reteoo/MemoryVisitor.java
   labs/jbossrules/trunk/drools-core/src/main/java/org/drools/reteoo/builder/BuildUtils.java
   labs/jbossrules/trunk/drools-core/src/main/java/org/drools/util/ClassUtils.java
   labs/jbossrules/trunk/drools-core/src/main/java/org/drools/util/StringUtils.java
   labs/jbossrules/trunk/drools-core/src/main/java/org/drools/workflow/core/impl/ConnectionImpl.java
   labs/jbossrules/trunk/drools-core/src/main/java/org/drools/workflow/instance/impl/WorkflowProcessInstanceImpl.java
   labs/jbossrules/trunk/drools-core/src/test/java/org/drools/FirstClass.java
   labs/jbossrules/trunk/drools-core/src/test/java/org/drools/SecondClass.java
Log:
JBRULES-2065 Performance benefit using StringBuilder instead of StringBuffer in org.drools.util.StringUtils

Modified: labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/commons/jci/compilers/EclipseCompilationProblem.java
===================================================================
--- labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/commons/jci/compilers/EclipseCompilationProblem.java	2009-05-14 00:32:35 UTC (rev 26521)
+++ labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/commons/jci/compilers/EclipseCompilationProblem.java	2009-05-14 02:17:06 UTC (rev 26522)
@@ -62,7 +62,7 @@
     }
 
     public String toString() {
-        final StringBuffer sb = new StringBuffer();
+        final StringBuilder sb = new StringBuilder();
         sb.append(getFileName()).append(" (");
         sb.append(getStartLine());
         sb.append(":");

Modified: labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/commons/jci/compilers/EclipseJavaCompiler.java
===================================================================
--- labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/commons/jci/compilers/EclipseJavaCompiler.java	2009-05-14 00:32:35 UTC (rev 26521)
+++ labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/commons/jci/compilers/EclipseJavaCompiler.java	2009-05-14 02:17:06 UTC (rev 26522)
@@ -191,7 +191,7 @@
         final INameEnvironment nameEnvironment = new INameEnvironment() {
 
             public NameEnvironmentAnswer findType( final char[][] pCompoundTypeName ) {
-                final StringBuffer result = new StringBuffer();
+                final StringBuilder result = new StringBuilder();
                 for (int i = 0; i < pCompoundTypeName.length; i++) {
                     if (i != 0) {
                         result.append('.');
@@ -205,7 +205,7 @@
             }
 
             public NameEnvironmentAnswer findType( final char[] pTypeName, final char[][] pPackageName ) {
-                final StringBuffer result = new StringBuffer();
+                final StringBuilder result = new StringBuilder();
                 for (int i = 0; i < pPackageName.length; i++) {
                     result.append(pPackageName[i]);
                     result.append('.');
@@ -292,7 +292,7 @@
             }
 
             public boolean isPackage( char[][] parentPackageName, char[] pPackageName ) {
-                final StringBuffer result = new StringBuffer();
+                final StringBuilder result = new StringBuilder();
                 if (parentPackageName != null) {
                     for (int i = 0; i < parentPackageName.length; i++) {
                         if (i != 0) {
@@ -333,7 +333,7 @@
                     for (int i = 0; i < clazzFiles.length; i++) {
                         final ClassFile clazzFile = clazzFiles[i];
                         final char[][] compoundName = clazzFile.getCompoundName();
-                        final StringBuffer clazzName = new StringBuffer();
+                        final StringBuilder clazzName = new StringBuilder();
                         for (int j = 0; j < compoundName.length; j++) {
                             if (j != 0) {
                                 clazzName.append('.');

Modified: labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/commons/jci/compilers/JaninoCompilationProblem.java
===================================================================
--- labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/commons/jci/compilers/JaninoCompilationProblem.java	2009-05-14 00:32:35 UTC (rev 26521)
+++ labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/commons/jci/compilers/JaninoCompilationProblem.java	2009-05-14 02:17:06 UTC (rev 26522)
@@ -87,7 +87,7 @@
     }
 
     public String toString() {
-        final StringBuffer sb = new StringBuffer();
+        final StringBuilder sb = new StringBuilder();
         sb.append(getFileName()).append(" (");
         sb.append(getStartLine());
         sb.append(":");

Modified: labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/compiler/ActionError.java
===================================================================
--- labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/compiler/ActionError.java	2009-05-14 00:32:35 UTC (rev 26521)
+++ labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/compiler/ActionError.java	2009-05-14 02:17:06 UTC (rev 26522)
@@ -71,7 +71,7 @@
     }
 
     public String toString() {
-        final StringBuffer buf = new StringBuffer();
+        final StringBuilder buf = new StringBuilder();
         buf.append( this.message );
         buf.append( " : " );
         buf.append( "\n" );
@@ -89,7 +89,7 @@
     }
 
 //    private String createMessage( String message ) {
-//        StringBuffer detail = new StringBuffer();
+//        StringBuilder detail = new StringBuilder();
 //        detail.append( this.message );
 //        detail.append( " : " );
 //        detail.append( this.rule );

Modified: labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/compiler/DescrBuildError.java
===================================================================
--- labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/compiler/DescrBuildError.java	2009-05-14 00:32:35 UTC (rev 26521)
+++ labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/compiler/DescrBuildError.java	2009-05-14 02:17:06 UTC (rev 26522)
@@ -78,7 +78,7 @@
     }
 
     public String toString() {
-        final StringBuffer buf = new StringBuffer();
+        final StringBuilder buf = new StringBuilder();
         buf.append( this.message );
         buf.append( " : " );
         buf.append( this.parentDescr );
@@ -97,7 +97,7 @@
     }
 
 //    private String createMessage( String message ) {
-//        StringBuffer detail = new StringBuffer();
+//        StringBuilder detail = new StringBuilder();
 //        detail.append( this.message );
 //        detail.append( " : " );
 //        detail.append( this.rule );

Modified: labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/compiler/DrlParser.java
===================================================================
--- labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/compiler/DrlParser.java	2009-05-14 00:32:35 UTC (rev 26521)
+++ labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/compiler/DrlParser.java	2009-05-14 02:17:06 UTC (rev 26522)
@@ -100,7 +100,7 @@
                               final Reader drl,
                               final Reader dsl) throws DroolsParserException,
                                                IOException {
-        final StringBuffer text = getDRLText( drl );
+        final StringBuilder text = getDRLText( drl );
         return parse( text.toString(),
                       dsl );
     }
@@ -195,14 +195,14 @@
         return expanded;
     }
 
-    private StringBuffer getDRLText(final InputStream is) throws IOException {
+    private StringBuilder getDRLText(final InputStream is) throws IOException {
         
         
         return null;
     }
     
-    private StringBuffer getDRLText(final Reader reader) throws IOException {
-        final StringBuffer text = new StringBuffer();
+    private StringBuilder getDRLText(final Reader reader) throws IOException {
+        final StringBuilder text = new StringBuilder();
 
         final char[] buf = new char[1024];
         int len = 0;

Modified: labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/compiler/FunctionError.java
===================================================================
--- labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/compiler/FunctionError.java	2009-05-14 00:32:35 UTC (rev 26521)
+++ labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/compiler/FunctionError.java	2009-05-14 02:17:06 UTC (rev 26522)
@@ -55,7 +55,7 @@
     }
     
     private String createMessage( String message ) {
-        StringBuffer detail = new StringBuffer();
+        StringBuilder detail = new StringBuilder();
         if( object instanceof CompilationProblem[] ) {
             CompilationProblem[] cp = (CompilationProblem[]) object;
             this.errorLines = new int[cp.length];

Modified: labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/compiler/PackageBuilder.java
===================================================================
--- labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/compiler/PackageBuilder.java	2009-05-14 00:32:35 UTC (rev 26521)
+++ labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/compiler/PackageBuilder.java	2009-05-14 02:17:06 UTC (rev 26522)
@@ -409,7 +409,7 @@
 	}
 
     private String loadBrlFile(final Reader drl) throws IOException {
-        final StringBuffer buf = new StringBuffer();
+        final StringBuilder buf = new StringBuilder();
         final BufferedReader input = new BufferedReader( drl );
         String line = null;
         while ( (line = input.readLine()) != null ) {
@@ -1478,7 +1478,7 @@
         }
 
         public String toString() {
-            final StringBuffer buf = new StringBuffer();
+            final StringBuilder buf = new StringBuilder();
             buf.append( this.message );
             buf.append( " : " );
             buf.append( "\n" );

Modified: labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/compiler/PackageBuilderErrors.java
===================================================================
--- labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/compiler/PackageBuilderErrors.java	2009-05-14 00:32:35 UTC (rev 26521)
+++ labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/compiler/PackageBuilderErrors.java	2009-05-14 02:17:06 UTC (rev 26522)
@@ -26,7 +26,7 @@
     }
     
     public String toString() {
-        final StringBuffer buf = new StringBuffer();
+        final StringBuilder buf = new StringBuilder();
         for ( int i = 0, length = this.errors.length; i < length; i++) {
             buf.append( errors[i] );
         }

Modified: labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/guvnor/client/modeldriven/brl/RuleAttribute.java
===================================================================
--- labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/guvnor/client/modeldriven/brl/RuleAttribute.java	2009-05-14 00:32:35 UTC (rev 26521)
+++ labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/guvnor/client/modeldriven/brl/RuleAttribute.java	2009-05-14 02:17:06 UTC (rev 26522)
@@ -32,7 +32,7 @@
 
 
     public String toString() {
-        StringBuffer ret = new StringBuffer();
+        StringBuilder ret = new StringBuilder();
         ret.append( this.attributeName );
         if ( NOLOOP.equals( attributeName ) )
         {

Modified: labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/guvnor/client/modeldriven/brl/RuleMetadata.java
===================================================================
--- labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/guvnor/client/modeldriven/brl/RuleMetadata.java	2009-05-14 00:32:35 UTC (rev 26521)
+++ labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/guvnor/client/modeldriven/brl/RuleMetadata.java	2009-05-14 02:17:06 UTC (rev 26522)
@@ -20,7 +20,7 @@
 
 	@Override
 	public String toString() {
-		StringBuffer ret = new StringBuffer();
+		StringBuilder ret = new StringBuilder();
 		ret.append("@");
 		ret.append(this.attributeName);
 		if (this.value != null) {

Modified: labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/guvnor/client/modeldriven/testing/Scenario.java
===================================================================
--- labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/guvnor/client/modeldriven/testing/Scenario.java	2009-05-14 00:32:35 UTC (rev 26521)
+++ labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/guvnor/client/modeldriven/testing/Scenario.java	2009-05-14 02:17:06 UTC (rev 26522)
@@ -273,7 +273,7 @@
     public String printFailureReport() {
         int total = 0;
         int failures = 0;
-        StringBuffer buf = new StringBuffer();
+        StringBuilder buf = new StringBuilder();
         buf.append( "------- Unmet expectations: -------\n" );
         for ( Iterator iterator = fixtures.iterator(); iterator.hasNext(); ) {
             Fixture f = (Fixture) iterator.next();

Modified: labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/guvnor/server/util/BRDRLPersistence.java
===================================================================
--- labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/guvnor/server/util/BRDRLPersistence.java	2009-05-14 00:32:35 UTC (rev 26521)
+++ labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/guvnor/server/util/BRDRLPersistence.java	2009-05-14 02:17:06 UTC (rev 26522)
@@ -30,7 +30,7 @@
 	public String marshal(RuleModel model) {
 		boolean isDSLEnhanced = model.hasDSLSentences();
 
-		StringBuffer buf = new StringBuffer();
+		StringBuilder buf = new StringBuilder();
 		buf.append("rule \"" + model.name + "\"");
 		if (null != model.parentName && model.parentName.length() > 0) {
 			buf.append(" extends \"" + model.parentName + "\"\n");
@@ -65,7 +65,7 @@
 	 * @param buf
 	 * @param model
 	 */
-	private void marshalAttributes(StringBuffer buf, RuleModel model) {
+	private void marshalAttributes(StringBuilder buf, RuleModel model) {
 		boolean hasDialect = false;
 		for (int i = 0; i < model.attributes.length; i++) {
 			RuleAttribute attr = model.attributes[i];
@@ -93,7 +93,7 @@
 	 * @param buf
 	 * @param model
 	 */
-	private void marshalMetadata(StringBuffer buf, RuleModel model) {
+	private void marshalMetadata(StringBuilder buf, RuleModel model) {
 		if (model.metadataList != null) {
 			for (int i = 0; i < model.metadataList.length; i++) {
 				buf.append("\t").append(model.metadataList[i]).append("\n");
@@ -107,7 +107,7 @@
 	 * @param buf
 	 * @param model
 	 */
-	private void marshalLHS(StringBuffer buf, RuleModel model,
+	private void marshalLHS(StringBuilder buf, RuleModel model,
 			boolean isDSLEnhanced) {
 		IPattern[] lhs = model.lhs;
 		LHSPatternVisitor visitor = new LHSPatternVisitor(isDSLEnhanced, buf);
@@ -117,7 +117,7 @@
 		}
 	}
 
-	private void marshalRHS(StringBuffer buf, RuleModel model,
+	private void marshalRHS(StringBuilder buf, RuleModel model,
 			boolean isDSLEnhanced) {
 		IAction[] rhs = model.rhs;
 		RHSActionVisitor visitor = new RHSActionVisitor(isDSLEnhanced, buf);
@@ -128,10 +128,10 @@
 	}
 
 	public static class LHSPatternVisitor extends ReflectiveVisitor {
-		private StringBuffer buf;
+		private StringBuilder buf;
 		private boolean isDSLEnhanced;
 
-		public LHSPatternVisitor(boolean isDSLEnhanced, StringBuffer b) {
+		public LHSPatternVisitor(boolean isDSLEnhanced, StringBuilder b) {
 			this.isDSLEnhanced = isDSLEnhanced;
 			buf = b;
 		}
@@ -234,7 +234,7 @@
 		private void generateConstraints(FactPattern pattern) {
 			int printedCount = 0;
 			for (int i = 0; i < pattern.getFieldConstraints().length; i++) {
-				StringBuffer buffer = new StringBuffer();
+				StringBuilder buffer = new StringBuilder();
 				generateConstraint(pattern.constraintList.constraints[i],
 						false, buffer);
 				if (buffer.length() > 0) {
@@ -252,7 +252,7 @@
 		 * readable DRL in the most common cases.
 		 */
 		private void generateConstraint(FieldConstraint con, boolean nested,
-				StringBuffer buf) {
+				StringBuilder buf) {
 			if (con instanceof CompositeFieldConstraint) {
 				CompositeFieldConstraint cfc = (CompositeFieldConstraint) con;
 				if (nested)
@@ -276,7 +276,7 @@
 		}
 
 		private void generateSingleFieldConstraint(
-				final SingleFieldConstraint constr, StringBuffer buf) {
+				final SingleFieldConstraint constr, StringBuilder buf) {
 			if (constr.constraintValueType == ISingleFieldConstraint.TYPE_PREDICATE) {
 				buf.append("eval( ");
 				buf.append(constr.value);
@@ -289,7 +289,7 @@
 				if ((constr.operator != null && constr.value != null)
 						|| constr.fieldBinding != null) {
 					SingleFieldConstraint parent = (SingleFieldConstraint) constr.parent;
-					StringBuffer parentBuf = new StringBuffer();
+					StringBuilder parentBuf = new StringBuilder();
 					while (parent != null) {
 						parentBuf.insert(0, parent.fieldName + ".");
 						parent = (SingleFieldConstraint) parent.parent;
@@ -312,7 +312,7 @@
 			}
 		}
 
-		private void addFieldRestriction(final StringBuffer buf,
+		private void addFieldRestriction(final StringBuilder buf,
 				final int type, final String operator, final String value) {
 			if (operator == null) {
 				return;
@@ -341,11 +341,11 @@
 	}
 
 	public static class RHSActionVisitor extends ReflectiveVisitor {
-		private StringBuffer buf;
+		private StringBuilder buf;
 		private boolean isDSLEnhanced;
 		private int idx = 0;
 
-		public RHSActionVisitor(boolean isDSLEnhanced, StringBuffer b) {
+		public RHSActionVisitor(boolean isDSLEnhanced, StringBuilder b) {
 			this.isDSLEnhanced = isDSLEnhanced;
 			buf = b;
 		}

Modified: labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/guvnor/server/util/DataEnumLoader.java
===================================================================
--- labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/guvnor/server/util/DataEnumLoader.java	2009-05-14 00:32:35 UTC (rev 26521)
+++ labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/guvnor/server/util/DataEnumLoader.java	2009-05-14 02:17:06 UTC (rev 26522)
@@ -82,7 +82,7 @@
 
 	public static String addCommasForNewLines(String mvelSource) {
         StringTokenizer st = new StringTokenizer(mvelSource, "\r\n");
-        StringBuffer buf = new StringBuffer();
+        StringBuilder buf = new StringBuilder();
         while(st.hasMoreTokens()) {
             String line = st.nextToken().trim();
             if (st.hasMoreTokens() && line.endsWith( "," )) {

Modified: labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/lang/DrlDumper.java
===================================================================
--- labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/lang/DrlDumper.java	2009-05-14 00:32:35 UTC (rev 26521)
+++ labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/lang/DrlDumper.java	2009-05-14 02:17:06 UTC (rev 26522)
@@ -60,13 +60,13 @@
     implements
     PackageDescrDumper {
 
-    private StringBuffer        drlDump;
+    private StringBuilder        drlDump;
     private static final String eol          = System.getProperty( "line.separator" );
     private String              template;
     private boolean             needsBracket = false;
 
     public synchronized String dump(final PackageDescr packageDescr) {
-        this.drlDump = new StringBuffer();
+        this.drlDump = new StringBuilder();
         visitPackageDescr( packageDescr );
         return this.drlDump.toString();
     }
@@ -122,7 +122,7 @@
     }
 
     public void visitPatternDescr(final PatternDescr descr) {
-        StringBuffer buf = new StringBuffer();
+        StringBuilder buf = new StringBuilder();
         buf.append( "\t\t" );
         if ( descr.getIdentifier() != null ) {
             buf.append(  descr.getIdentifier() );

Modified: labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/lang/MVELDumper.java
===================================================================
--- labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/lang/MVELDumper.java	2009-05-14 00:32:35 UTC (rev 26521)
+++ labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/lang/MVELDumper.java	2009-05-14 02:17:06 UTC (rev 26522)
@@ -36,7 +36,7 @@
  */
 public class MVELDumper extends ReflectiveVisitor {
 
-    private StringBuffer        mvelDump;
+    private StringBuilder        mvelDump;
     private boolean             isDateField;
     private static final String eol = System.getProperty( "line.separator" );
     private String              template;
@@ -47,7 +47,7 @@
     }
 
     public String dump(FieldConstraintDescr fieldConstr, boolean isDateField ) {
-        mvelDump = new StringBuffer();
+        mvelDump = new StringBuilder();
         this.isDateField = isDateField;
         this.visit( fieldConstr );
         return mvelDump.toString();

Modified: labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/lang/descr/AccessorDescr.java
===================================================================
--- labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/lang/descr/AccessorDescr.java	2009-05-14 00:32:35 UTC (rev 26521)
+++ labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/lang/descr/AccessorDescr.java	2009-05-14 02:17:06 UTC (rev 26522)
@@ -46,7 +46,7 @@
     }
 
     public String toString() {
-        final StringBuffer buf = new StringBuffer();
+        final StringBuilder buf = new StringBuilder();
         buf.append( (this.variableName != null) ? this.variableName : "" );
         for ( final Iterator it = this.invokers.iterator(); it.hasNext(); ) {
             if ( buf.length() > 0 ) {

Modified: labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/lang/descr/RestrictionConnectiveDescr.java
===================================================================
--- labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/lang/descr/RestrictionConnectiveDescr.java	2009-05-14 00:32:35 UTC (rev 26521)
+++ labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/lang/descr/RestrictionConnectiveDescr.java	2009-05-14 02:17:06 UTC (rev 26522)
@@ -54,7 +54,7 @@
     }
 
     public String toString() {
-        final StringBuffer buf = new StringBuffer();
+        final StringBuilder buf = new StringBuilder();
         buf.append( "( " );
         for ( Iterator it = this.restrictions.iterator(); it.hasNext(); ) {
             buf.append( it.next().toString() );

Modified: labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/lang/dsl/AntlrDSLMappingEntry.java
===================================================================
--- labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/lang/dsl/AntlrDSLMappingEntry.java	2009-05-14 00:32:35 UTC (rev 26521)
+++ labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/lang/dsl/AntlrDSLMappingEntry.java	2009-05-14 02:17:06 UTC (rev 26522)
@@ -176,7 +176,7 @@
      */
     public void setValuePattern(String value) {
         if ( value != null ) {
-            StringBuffer valuePatternBuffer = new StringBuffer();
+            StringBuilder valuePatternBuffer = new StringBuilder();
 
             if ( headMatchGroupAdded ) {
                 valuePatternBuffer.append( "$1" );

Modified: labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/lang/dsl/DSLMapWalker.java
===================================================================
--- labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/lang/dsl/DSLMapWalker.java	2009-05-14 00:32:35 UTC (rev 26521)
+++ labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/lang/dsl/DSLMapWalker.java	2009-05-14 02:17:06 UTC (rev 26522)
@@ -209,10 +209,10 @@
     protected static class entry_scope {
         Map<String,Integer> variables;
         AntlrDSLMappingEntry retval;
-        StringBuffer keybuffer;
-        StringBuffer valuebuffer;
-        StringBuffer sentenceKeyBuffer;
-        StringBuffer sentenceValueBuffer;
+        StringBuilder keybuffer;
+        StringBuilder valuebuffer;
+        StringBuilder sentenceKeyBuffer;
+        StringBuilder sentenceValueBuffer;
     }
     protected Stack entry_stack = new Stack();
 
@@ -226,10 +226,10 @@
 
         	((entry_scope)entry_stack.peek()).retval = new AntlrDSLMappingEntry() ;
         	((entry_scope)entry_stack.peek()).variables = new HashMap<String,Integer>();
-        	((entry_scope)entry_stack.peek()).keybuffer = new StringBuffer();
-        	((entry_scope)entry_stack.peek()).valuebuffer = new StringBuffer();
-        	((entry_scope)entry_stack.peek()).sentenceKeyBuffer = new StringBuffer();
-        	((entry_scope)entry_stack.peek()).sentenceValueBuffer = new StringBuffer();
+        	((entry_scope)entry_stack.peek()).keybuffer = new StringBuilder();
+        	((entry_scope)entry_stack.peek()).valuebuffer = new StringBuilder();
+        	((entry_scope)entry_stack.peek()).sentenceKeyBuffer = new StringBuilder();
+        	((entry_scope)entry_stack.peek()).sentenceValueBuffer = new StringBuilder();
 
         try {
             // src/main/resources/org/drools/lang/dsl/DSLMapWalker.g:52:2: ( ^( VT_ENTRY scope_section ( meta_section )? key_section value_section ) )

Modified: labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/lang/dsl/DSLMappingFile.java
===================================================================
--- labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/lang/dsl/DSLMappingFile.java	2009-05-14 00:32:35 UTC (rev 26521)
+++ labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/lang/dsl/DSLMappingFile.java	2009-05-14 02:17:06 UTC (rev 26522)
@@ -106,7 +106,7 @@
      * @return
      */
     public String dumpFile() {
-        final StringBuffer buf = new StringBuffer();
+        final StringBuilder buf = new StringBuilder();
         for ( final Iterator it = this.mapping.getEntries().iterator(); it.hasNext(); ) {
             buf.append( it.next() );
             buf.append( "\n" );

Modified: labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/lang/dsl/DefaultExpander.java
===================================================================
--- labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/lang/dsl/DefaultExpander.java	2009-05-14 00:32:35 UTC (rev 26521)
+++ labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/lang/dsl/DefaultExpander.java	2009-05-14 02:17:06 UTC (rev 26522)
@@ -131,7 +131,7 @@
         
         final StringBuffer buf = new StringBuffer();
         while ( m.find() ) {
-            final StringBuffer expanded = new StringBuffer();
+            final StringBuilder expanded = new StringBuilder();
             final String constr = m.group( 1 ).trim();
             if ( constr.startsWith( "rule" ) ) {
                 // match rule
@@ -211,7 +211,7 @@
      * @return
      */
     private String expandLHS(final String lhs, int lineOffset) {
-        final StringBuffer buf = new StringBuffer();
+        final StringBuilder buf = new StringBuilder();
         final String[] lines = lhs.split( "\n" ); // since we assembled the string, we know line breaks are \n
         final String[] expanded = new String[lines.length]; // buffer for expanded lines
         int lastExpanded = -1;
@@ -288,7 +288,7 @@
      * @return
      */
     private String expandRHS(final String lhs, int lineOffset) {
-        final StringBuffer buf = new StringBuffer();
+        final StringBuilder buf = new StringBuilder();
         final String[] lines = lhs.split( "\n" ); // since we assembled the string, we know line breaks are \n
         for ( int i = 0; i < lines.length; i++ ) {
             final String trimmed = lines[i].trim();
@@ -322,7 +322,7 @@
 
     // Reads the stream into a String
     private String loadDrlFile(final Reader drl) throws IOException {
-        final StringBuffer buf = new StringBuffer();
+        final StringBuilder buf = new StringBuilder();
         final BufferedReader input = new BufferedReader( drl );
         String line = null;
         while ( (line = input.readLine()) != null ) {

Modified: labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/rule/builder/dialect/java/JavaAccumulateBuilder.java
===================================================================
--- labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/rule/builder/dialect/java/JavaAccumulateBuilder.java	2009-05-14 00:32:35 UTC (rev 26521)
+++ labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/rule/builder/dialect/java/JavaAccumulateBuilder.java	2009-05-14 02:17:06 UTC (rev 26522)
@@ -251,7 +251,7 @@
             locals.add( it.next() );
         }
 
-        StringBuffer initCode = new StringBuffer();
+        StringBuilder initCode = new StringBuilder();
         int lastAdded = 0;
         for ( Iterator it = locals.iterator(); it.hasNext(); ) {
             JavaLocalDeclarationDescr d = (JavaLocalDeclarationDescr) it.next();

Modified: labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/rule/builder/dialect/java/JavaProcessClassBuilder.java
===================================================================
--- labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/rule/builder/dialect/java/JavaProcessClassBuilder.java	2009-05-14 00:32:35 UTC (rev 26521)
+++ labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/rule/builder/dialect/java/JavaProcessClassBuilder.java	2009-05-14 02:17:06 UTC (rev 26522)
@@ -43,7 +43,7 @@
         
         final String lineSeparator = System.getProperty( "line.separator" );
 
-        final StringBuffer buffer = new StringBuffer();
+        final StringBuilder buffer = new StringBuilder();
         buffer.append( "package " + context.getPkg().getName() + ";" + lineSeparator );
 
         for ( ImportDeclaration decl : context.getPkg().getImports().values() ) {

Modified: labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/rule/builder/dialect/java/JavaRuleClassBuilder.java
===================================================================
--- labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/rule/builder/dialect/java/JavaRuleClassBuilder.java	2009-05-14 00:32:35 UTC (rev 26521)
+++ labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/rule/builder/dialect/java/JavaRuleClassBuilder.java	2009-05-14 02:17:06 UTC (rev 26522)
@@ -42,7 +42,7 @@
         
         final String lineSeparator = System.getProperty( "line.separator" );
 
-        final StringBuffer buffer = new StringBuffer();
+        final StringBuilder buffer = new StringBuilder();
         buffer.append( "package " + context.getPkg().getName() + ";" + lineSeparator );
 
         for ( final Iterator it = context.getPkg().getImports().keySet().iterator(); it.hasNext(); ) {

Modified: labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/rule/builder/dialect/java/parser/JavaParser.java
===================================================================
--- labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/rule/builder/dialect/java/parser/JavaParser.java	2009-05-14 00:32:35 UTC (rev 26521)
+++ labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/rule/builder/dialect/java/parser/JavaParser.java	2009-05-14 02:17:06 UTC (rev 26522)
@@ -278,7 +278,7 @@
          	/** This will take a RecognitionException, and create a sensible error message out of it */
          	public String createErrorMessage(RecognitionException e)
             {
-    		StringBuffer message = new StringBuffer();		
+    		StringBuilder message = new StringBuilder();		
                     message.append( source + ":"+e.line+":"+e.charPositionInLine+" ");
                     if ( e instanceof MismatchedTokenException ) {
                             MismatchedTokenException mte = (MismatchedTokenException)e;

Modified: labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/rule/builder/dialect/mvel/MVELActionBuilder.java
===================================================================
--- labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/rule/builder/dialect/mvel/MVELActionBuilder.java	2009-05-14 00:32:35 UTC (rev 26521)
+++ labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/rule/builder/dialect/mvel/MVELActionBuilder.java	2009-05-14 02:17:06 UTC (rev 26522)
@@ -149,7 +149,7 @@
      */
     public static String delimitExpressions(String s) {
 
-        StringBuffer result = new StringBuffer();
+        StringBuilder result = new StringBuilder();
         char[] cs = s.toCharArray();
         int brace = 0;
         int sqre = 0;

Modified: labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/rule/builder/dialect/mvel/MVELConsequenceBuilder.java
===================================================================
--- labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/rule/builder/dialect/mvel/MVELConsequenceBuilder.java	2009-05-14 00:32:35 UTC (rev 26521)
+++ labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/rule/builder/dialect/mvel/MVELConsequenceBuilder.java	2009-05-14 02:17:06 UTC (rev 26522)
@@ -129,7 +129,7 @@
      */
     public static String delimitExpressions(String s) {
 
-        StringBuffer result = new StringBuffer();
+        StringBuilder result = new StringBuilder();
         char[] cs = s.toCharArray();
         int brace = 0;
         int sqre = 0;

Modified: labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/rule/builder/dialect/mvel/MVELReturnValueEvaluatorBuilder.java
===================================================================
--- labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/rule/builder/dialect/mvel/MVELReturnValueEvaluatorBuilder.java	2009-05-14 00:32:35 UTC (rev 26521)
+++ labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/rule/builder/dialect/mvel/MVELReturnValueEvaluatorBuilder.java	2009-05-14 02:17:06 UTC (rev 26522)
@@ -97,7 +97,7 @@
      */
     public static String delimitExpressions(String s) {
 
-        StringBuffer result = new StringBuffer();
+        StringBuilder result = new StringBuilder();
         char[] cs = s.toCharArray();
         int brace = 0;
         int sqre = 0;

Modified: labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/xml/XmlDumper.java
===================================================================
--- labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/xml/XmlDumper.java	2009-05-14 00:32:35 UTC (rev 26521)
+++ labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/xml/XmlDumper.java	2009-05-14 02:17:06 UTC (rev 26522)
@@ -61,13 +61,13 @@
     implements
     PackageDescrDumper {
 
-    private StringBuffer        xmlDump;
+    private StringBuilder        xmlDump;
     private boolean             patternContext;
     private final static String eol = System.getProperty( "line.separator" );
     private String              template;
 
     public synchronized String dump(final PackageDescr packageDescr) {
-        this.xmlDump = new StringBuffer();
+        this.xmlDump = new StringBuilder();
         visitPackageDescr( packageDescr );
         return this.xmlDump.toString();
     }
@@ -93,7 +93,7 @@
     public void visitPatternDescr(final PatternDescr descr) {
         this.patternContext = true;
         this.template = new String();
-        StringBuffer localString = new StringBuffer();
+        StringBuilder localString = new StringBuilder();
 
         if ( descr.getDescrs() != Collections.EMPTY_LIST ) {
             if ( descr.getIdentifier() != null ) {
@@ -127,7 +127,7 @@
     }
 
     public void visitCollectDescr(final CollectDescr descr) {
-        StringBuffer tmpstr = new StringBuffer();
+        StringBuilder tmpstr = new StringBuilder();
         tmpstr.append( "<from> <collect>" );
         visit( descr.getInputPattern() );
         tmpstr.append( this.template );
@@ -391,7 +391,7 @@
      * @author <a href="mailto:prietor at gmail.com">Author Javier Prieto</a>
      */
     public static String replaceIllegalChars(final String code) {
-        final StringBuffer sb = new StringBuffer();
+        final StringBuilder sb = new StringBuilder();
         if ( code != null ) {
             final int n = code.length();
             for ( int i = 0; i < n; i++ ) {

Modified: labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/xml/XmlWorkflowProcessDumper.java
===================================================================
--- labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/xml/XmlWorkflowProcessDumper.java	2009-05-14 00:32:35 UTC (rev 26521)
+++ labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/xml/XmlWorkflowProcessDumper.java	2009-05-14 02:17:06 UTC (rev 26522)
@@ -42,12 +42,12 @@
     }
     
     public String dump(WorkflowProcess process, boolean includeMeta) {
-        StringBuffer xmlDump = new StringBuffer();
+        StringBuilder xmlDump = new StringBuilder();
         visitProcess(process, xmlDump, includeMeta);
         return xmlDump.toString();
     }
     
-    protected void visitProcess(WorkflowProcess process, StringBuffer xmlDump, boolean includeMeta) {
+    protected void visitProcess(WorkflowProcess process, StringBuilder xmlDump, boolean includeMeta) {
         xmlDump.append("<?xml version=\"1.0\" encoding=\"UTF-8\"?> " + EOL
             + "<process xmlns=\"" + namespace + "\"" + EOL
             + "         xmlns:xs=\"http://www.w3.org/2001/XMLSchema-instance\"" + EOL
@@ -78,7 +78,7 @@
         xmlDump.append("</process>");
     }
     
-    protected void visitHeader(WorkflowProcess process, StringBuffer xmlDump, boolean includeMeta) {
+    protected void visitHeader(WorkflowProcess process, StringBuilder xmlDump, boolean includeMeta) {
         xmlDump.append("  <header>" + EOL);
         visitImports(((org.drools.process.core.Process) process).getImports(), xmlDump);
         visitGlobals(((org.drools.process.core.Process) process).getGlobals(), xmlDump);
@@ -101,7 +101,7 @@
         xmlDump.append("  </header>" + EOL + EOL);
     }
     
-    private void visitImports(List<String> imports, StringBuffer xmlDump) {
+    private void visitImports(List<String> imports, StringBuilder xmlDump) {
         if (imports != null && imports.size() > 0) {
             xmlDump.append("    <imports>" + EOL);
             for (String importString: imports) {
@@ -111,7 +111,7 @@
         }
     }
     
-    private void visitFunctionImports(List<String> imports, StringBuffer xmlDump) {
+    private void visitFunctionImports(List<String> imports, StringBuilder xmlDump) {
         if (imports != null && imports.size() > 0) {
             xmlDump.append("    <functionImports>" + EOL);
             for (String importString: imports) {
@@ -121,7 +121,7 @@
         }
     }
     
-    private void visitGlobals(Map<String, String> globals, StringBuffer xmlDump) {
+    private void visitGlobals(Map<String, String> globals, StringBuilder xmlDump) {
         if (globals != null && globals.size() > 0) {
             xmlDump.append("    <globals>" + EOL);
             for (Map.Entry<String, String> global: globals.entrySet()) {
@@ -131,7 +131,7 @@
         }
     }
     
-    public static void visitVariables(List<Variable> variables, StringBuffer xmlDump) {
+    public static void visitVariables(List<Variable> variables, StringBuilder xmlDump) {
         if (variables != null && variables.size() > 0) {
             xmlDump.append("    <variables>" + EOL);
             for (Variable variable: variables) {
@@ -147,7 +147,7 @@
         }
     }
     
-    private void visitSwimlanes(Collection<Swimlane> swimlanes, StringBuffer xmlDump) {
+    private void visitSwimlanes(Collection<Swimlane> swimlanes, StringBuilder xmlDump) {
         if (swimlanes != null && swimlanes.size() > 0) {
             xmlDump.append("    <swimlanes>" + EOL);
             for (Swimlane swimlane: swimlanes) {
@@ -157,7 +157,7 @@
         }
     }
     
-    public static void visitExceptionHandlers(Map<String, ExceptionHandler> exceptionHandlers, StringBuffer xmlDump) {
+    public static void visitExceptionHandlers(Map<String, ExceptionHandler> exceptionHandlers, StringBuilder xmlDump) {
         if (exceptionHandlers != null && exceptionHandlers.size() > 0) {
             xmlDump.append("    <exceptionHandlers>" + EOL);
             for (Map.Entry<String, ExceptionHandler> entry: exceptionHandlers.entrySet()) {
@@ -184,7 +184,7 @@
         }
     }
     
-    public static void visitDataType(DataType dataType, StringBuffer xmlDump) {
+    public static void visitDataType(DataType dataType, StringBuilder xmlDump) {
         xmlDump.append("        <type name=\"" + dataType.getClass().getName() + "\" ");
         // TODO make this pluggable so datatypes can write out other properties as well
         if (dataType instanceof ObjectDataType) {
@@ -193,11 +193,11 @@
         xmlDump.append("/>" + EOL);
     }
     
-    public static void visitValue(Object value, DataType dataType, StringBuffer xmlDump) {
+    public static void visitValue(Object value, DataType dataType, StringBuilder xmlDump) {
 		xmlDump.append("        <value>" + XmlDumper.replaceIllegalChars(dataType.writeValue(value)) + "</value>" + EOL);
     }
     
-    private void visitNodes(WorkflowProcess process, StringBuffer xmlDump, boolean includeMeta) {
+    private void visitNodes(WorkflowProcess process, StringBuilder xmlDump, boolean includeMeta) {
         xmlDump.append("  <nodes>" + EOL);
         for (Node node: process.getNodes()) {
             visitNode(node, xmlDump, includeMeta);
@@ -205,7 +205,7 @@
         xmlDump.append("  </nodes>" + EOL + EOL);
     }
     
-    public void visitNode(Node node, StringBuffer xmlDump, boolean includeMeta) {
+    public void visitNode(Node node, StringBuilder xmlDump, boolean includeMeta) {
      	Handler handler = semanticModule.getHandlerByClass(node.getClass());
         if (handler != null) {
         	((AbstractNodeHandler) handler).writeNode((org.drools.workflow.core.Node) node, xmlDump, includeMeta);
@@ -215,7 +215,7 @@
         }
     }
     
-    private void visitConnections(Node[] nodes, StringBuffer xmlDump, boolean includeMeta) {
+    private void visitConnections(Node[] nodes, StringBuilder xmlDump, boolean includeMeta) {
         List<Connection> connections = new ArrayList<Connection>();
         for (Node node: nodes) {
             for (List<Connection> connectionList: node.getIncomingConnections().values()) {
@@ -229,7 +229,7 @@
         xmlDump.append("  </connections>" + EOL + EOL);
     }
     
-    public void visitConnection(Connection connection, StringBuffer xmlDump, boolean includeMeta) {
+    public void visitConnection(Connection connection, StringBuilder xmlDump, boolean includeMeta) {
         xmlDump.append("    <connection from=\"" + connection.getFrom().getId() + "\" ");
         if (!NodeImpl.CONNECTION_DEFAULT_TYPE.equals(connection.getFromType())) {
             xmlDump.append("fromType=\"" + connection.getFromType() + "\" ");

Modified: labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/xml/processes/AbstractNodeHandler.java
===================================================================
--- labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/xml/processes/AbstractNodeHandler.java	2009-05-14 00:32:35 UTC (rev 26521)
+++ labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/xml/processes/AbstractNodeHandler.java	2009-05-14 02:17:06 UTC (rev 26522)
@@ -149,9 +149,9 @@
     	}
     }
     
-    public abstract void writeNode(final Node node, final StringBuffer xmlDump, final boolean includeMeta);
+    public abstract void writeNode(final Node node, final StringBuilder xmlDump, final boolean includeMeta);
     
-    protected void writeNode(final String name, final Node node, final StringBuffer xmlDump, final boolean includeMeta) {
+    protected void writeNode(final String name, final Node node, final StringBuilder xmlDump, final boolean includeMeta) {
     	xmlDump.append("    <" + name + " id=\"" + node.getId() + "\" "); 
         if (node.getName() != null) {
             xmlDump.append("name=\"" + node.getName() + "\" ");
@@ -180,7 +180,7 @@
         }
     }
     
-    protected void writeActions(final String type, List<DroolsAction> actions, final StringBuffer xmlDump) {
+    protected void writeActions(final String type, List<DroolsAction> actions, final StringBuilder xmlDump) {
     	if (actions != null && actions.size() > 0) {
     		xmlDump.append("      <" + type + ">" + EOL);
 	    	for (DroolsAction action: actions) {
@@ -190,7 +190,7 @@
     	}
     }
     
-    public static void writeAction(final DroolsAction action, final StringBuffer xmlDump) {
+    public static void writeAction(final DroolsAction action, final StringBuilder xmlDump) {
     	if (action instanceof DroolsConsequenceAction) {
     		DroolsConsequenceAction consequenceAction = (DroolsConsequenceAction) action;
     		xmlDump.append("        <action type=\"expression\" ");
@@ -214,7 +214,7 @@
     	}
     }
     
-    public void writeTimers(final Map<Timer, DroolsAction> timers, final StringBuffer xmlDump) {
+    public void writeTimers(final Map<Timer, DroolsAction> timers, final StringBuilder xmlDump) {
     	if (timers != null && !timers.isEmpty()) {
     		xmlDump.append("      <timers>" + EOL);
     		List<Timer> timerList = new ArrayList<Timer>(timers.keySet());
@@ -236,11 +236,11 @@
     	}
     }
     
-    protected void endNode(final StringBuffer xmlDump) {
+    protected void endNode(final StringBuilder xmlDump) {
         xmlDump.append("/>" + EOL);
     }
 
-    protected void endNode(final String name, final StringBuffer xmlDump) {
+    protected void endNode(final String name, final StringBuilder xmlDump) {
         xmlDump.append("    </" + name + ">" + EOL);
     }
     

Modified: labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/xml/processes/ActionNodeHandler.java
===================================================================
--- labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/xml/processes/ActionNodeHandler.java	2009-05-14 00:32:35 UTC (rev 26521)
+++ labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/xml/processes/ActionNodeHandler.java	2009-05-14 02:17:06 UTC (rev 26522)
@@ -32,7 +32,7 @@
         return ActionNode.class;
     }
 
-	public void writeNode(Node node, StringBuffer xmlDump, boolean includeMeta) {
+	public void writeNode(Node node, StringBuilder xmlDump, boolean includeMeta) {
 		ActionNode actionNode = (ActionNode) node;
 		writeNode("actionNode", actionNode, xmlDump, includeMeta);
         DroolsConsequenceAction action = (DroolsConsequenceAction) actionNode.getAction();

Modified: labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/xml/processes/CompositeNodeHandler.java
===================================================================
--- labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/xml/processes/CompositeNodeHandler.java	2009-05-14 00:32:35 UTC (rev 26521)
+++ labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/xml/processes/CompositeNodeHandler.java	2009-05-14 02:17:06 UTC (rev 26522)
@@ -32,7 +32,7 @@
     	return "composite";
     }
 
-    public void writeNode(Node node, StringBuffer xmlDump, boolean includeMeta) {
+    public void writeNode(Node node, StringBuilder xmlDump, boolean includeMeta) {
     	super.writeNode(getNodeName(), node, xmlDump, includeMeta);
         CompositeNode compositeNode = (CompositeNode) node;
         writeAttributes(compositeNode, xmlDump, includeMeta);
@@ -78,7 +78,7 @@
         endNode(getNodeName(), xmlDump);
     }
     
-    protected void writeAttributes(CompositeNode compositeNode, StringBuffer xmlDump, boolean includeMeta) {
+    protected void writeAttributes(CompositeNode compositeNode, StringBuilder xmlDump, boolean includeMeta) {
     }
     
     protected List<Node> getSubNodes(CompositeNode compositeNode) {

Modified: labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/xml/processes/EndNodeHandler.java
===================================================================
--- labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/xml/processes/EndNodeHandler.java	2009-05-14 00:32:35 UTC (rev 26521)
+++ labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/xml/processes/EndNodeHandler.java	2009-05-14 02:17:06 UTC (rev 26522)
@@ -27,7 +27,7 @@
         return EndNode.class;
     }
 
-	public void writeNode(Node node, StringBuffer xmlDump, boolean includeMeta) {
+	public void writeNode(Node node, StringBuilder xmlDump, boolean includeMeta) {
 		EndNode endNode = (EndNode) node;
 		writeNode("end", endNode, xmlDump, includeMeta);
 		boolean terminate = endNode.isTerminate();

Modified: labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/xml/processes/EventNodeHandler.java
===================================================================
--- labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/xml/processes/EventNodeHandler.java	2009-05-14 00:32:35 UTC (rev 26521)
+++ labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/xml/processes/EventNodeHandler.java	2009-05-14 02:17:06 UTC (rev 26522)
@@ -34,7 +34,7 @@
         }
     }
     
-    public void writeNode(Node node, StringBuffer xmlDump, boolean includeMeta) {
+    public void writeNode(Node node, StringBuilder xmlDump, boolean includeMeta) {
 		EventNode eventNode = (EventNode) node;
 		writeNode("eventNode", eventNode, xmlDump, includeMeta);
 		String variableName = eventNode.getVariableName();

Modified: labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/xml/processes/FaultNodeHandler.java
===================================================================
--- labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/xml/processes/FaultNodeHandler.java	2009-05-14 00:32:35 UTC (rev 26521)
+++ labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/xml/processes/FaultNodeHandler.java	2009-05-14 02:17:06 UTC (rev 26522)
@@ -31,7 +31,7 @@
         return FaultNode.class;
     }
 
-	public void writeNode(Node node, StringBuffer xmlDump, boolean includeMeta) {
+	public void writeNode(Node node, StringBuilder xmlDump, boolean includeMeta) {
 		FaultNode faultNode = (FaultNode) node;
 		writeNode("fault", faultNode, xmlDump, includeMeta);
 		String faultName = faultNode.getFaultName();

Modified: labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/xml/processes/ForEachNodeHandler.java
===================================================================
--- labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/xml/processes/ForEachNodeHandler.java	2009-05-14 00:32:35 UTC (rev 26521)
+++ labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/xml/processes/ForEachNodeHandler.java	2009-05-14 02:17:06 UTC (rev 26522)
@@ -26,7 +26,7 @@
     	return "forEach";
     }
     
-    protected void writeAttributes(CompositeNode compositeNode, StringBuffer xmlDump, boolean includeMeta) {
+    protected void writeAttributes(CompositeNode compositeNode, StringBuilder xmlDump, boolean includeMeta) {
     	ForEachNode forEachNode = (ForEachNode) compositeNode;
     	String variableName = forEachNode.getVariableName();
     	if (variableName != null) {

Modified: labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/xml/processes/HumanTaskNodeHandler.java
===================================================================
--- labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/xml/processes/HumanTaskNodeHandler.java	2009-05-14 00:32:35 UTC (rev 26521)
+++ labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/xml/processes/HumanTaskNodeHandler.java	2009-05-14 02:17:06 UTC (rev 26522)
@@ -29,7 +29,7 @@
         return HumanTaskNode.class;
     }
 
-    public void writeNode(Node node, StringBuffer xmlDump, boolean includeMeta) {
+    public void writeNode(Node node, StringBuilder xmlDump, boolean includeMeta) {
         WorkItemNode workItemNode = (WorkItemNode) node;
         writeNode("humanTask", workItemNode, xmlDump, includeMeta);
         visitParameters(workItemNode, xmlDump);
@@ -45,7 +45,7 @@
         endNode("humanTask", xmlDump);
     }
     
-	protected void visitParameters(WorkItemNode workItemNode, StringBuffer xmlDump) {
+	protected void visitParameters(WorkItemNode workItemNode, StringBuilder xmlDump) {
 	    super.visitParameters(workItemNode, xmlDump);
 	    HumanTaskNode humanTaskNode = (HumanTaskNode) workItemNode;
 	    String swimlane = humanTaskNode.getSwimlane();

Modified: labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/xml/processes/JoinNodeHandler.java
===================================================================
--- labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/xml/processes/JoinNodeHandler.java	2009-05-14 00:32:35 UTC (rev 26521)
+++ labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/xml/processes/JoinNodeHandler.java	2009-05-14 02:17:06 UTC (rev 26522)
@@ -31,7 +31,7 @@
         return Join.class;
     }
 
-	public void writeNode(Node node, StringBuffer xmlDump, boolean includeMeta) {
+	public void writeNode(Node node, StringBuilder xmlDump, boolean includeMeta) {
 		Join joinNode = (Join) node;
 		writeNode("join", joinNode, xmlDump, includeMeta);
         int type = joinNode.getType();

Modified: labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/xml/processes/MilestoneNodeHandler.java
===================================================================
--- labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/xml/processes/MilestoneNodeHandler.java	2009-05-14 00:32:35 UTC (rev 26521)
+++ labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/xml/processes/MilestoneNodeHandler.java	2009-05-14 02:17:06 UTC (rev 26522)
@@ -29,7 +29,7 @@
         }
     }
     
-    public void writeNode(Node node, StringBuffer xmlDump, boolean includeMeta) {
+    public void writeNode(Node node, StringBuilder xmlDump, boolean includeMeta) {
 		MilestoneNode milestoneNode = (MilestoneNode) node;
 		writeNode("milestone", milestoneNode, xmlDump, includeMeta);
         String constraint = milestoneNode.getConstraint();

Modified: labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/xml/processes/RuleFlowMigrator.java
===================================================================
--- labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/xml/processes/RuleFlowMigrator.java	2009-05-14 00:32:35 UTC (rev 26521)
+++ labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/xml/processes/RuleFlowMigrator.java	2009-05-14 02:17:06 UTC (rev 26522)
@@ -159,7 +159,7 @@
      * @throws IOException
      ************************************************************************/
     public static String convertReaderToString(Reader reader) throws IOException {
-        final StringBuffer text = new StringBuffer();
+        final StringBuilder text = new StringBuilder();
 
         final char[] buf = new char[1024];
         int len = 0;

Modified: labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/xml/processes/RuleSetNodeHandler.java
===================================================================
--- labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/xml/processes/RuleSetNodeHandler.java	2009-05-14 00:32:35 UTC (rev 26521)
+++ labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/xml/processes/RuleSetNodeHandler.java	2009-05-14 02:17:06 UTC (rev 26522)
@@ -28,7 +28,7 @@
         return RuleSetNode.class;
     }
 
-	public void writeNode(Node node, StringBuffer xmlDump, boolean includeMeta) {
+	public void writeNode(Node node, StringBuilder xmlDump, boolean includeMeta) {
 		RuleSetNode ruleSetNode = (RuleSetNode) node;
 		writeNode("ruleSet", ruleSetNode, xmlDump, includeMeta);
         String ruleFlowGroup = ruleSetNode.getRuleFlowGroup();

Modified: labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/xml/processes/SplitNodeHandler.java
===================================================================
--- labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/xml/processes/SplitNodeHandler.java	2009-05-14 00:32:35 UTC (rev 26521)
+++ labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/xml/processes/SplitNodeHandler.java	2009-05-14 02:17:06 UTC (rev 26522)
@@ -32,7 +32,7 @@
         return Split.class;
     }
 
-	public void writeNode(Node node, StringBuffer xmlDump, boolean includeMeta) {
+	public void writeNode(Node node, StringBuilder xmlDump, boolean includeMeta) {
 		Split splitNode = (Split) node;
 		writeNode("split", splitNode, xmlDump, includeMeta);
         int type = splitNode.getType();

Modified: labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/xml/processes/StartNodeHandler.java
===================================================================
--- labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/xml/processes/StartNodeHandler.java	2009-05-14 00:32:35 UTC (rev 26521)
+++ labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/xml/processes/StartNodeHandler.java	2009-05-14 02:17:06 UTC (rev 26522)
@@ -23,7 +23,7 @@
         return StartNode.class;
     }
 
-	public void writeNode(Node node, StringBuffer xmlDump, boolean includeMeta) {
+	public void writeNode(Node node, StringBuilder xmlDump, boolean includeMeta) {
 		StartNode startNode = (StartNode) node;
 		writeNode("start", startNode, xmlDump, includeMeta);
 		List<Trigger> triggers = startNode.getTriggers();

Modified: labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/xml/processes/StateNodeHandler.java
===================================================================
--- labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/xml/processes/StateNodeHandler.java	2009-05-14 00:32:35 UTC (rev 26521)
+++ labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/xml/processes/StateNodeHandler.java	2009-05-14 02:17:06 UTC (rev 26522)
@@ -27,7 +27,7 @@
         }
     }
     
-    public void writeNode(Node node, StringBuffer xmlDump, boolean includeMeta) {
+    public void writeNode(Node node, StringBuilder xmlDump, boolean includeMeta) {
 		StateNode milestoneNode = (StateNode) node;
 		writeNode("state", milestoneNode, xmlDump, includeMeta);
         endNode(xmlDump);

Modified: labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/xml/processes/SubProcessNodeHandler.java
===================================================================
--- labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/xml/processes/SubProcessNodeHandler.java	2009-05-14 00:32:35 UTC (rev 26521)
+++ labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/xml/processes/SubProcessNodeHandler.java	2009-05-14 02:17:06 UTC (rev 26522)
@@ -37,7 +37,7 @@
         return SubProcessNode.class;
     }
 
-	public void writeNode(Node node, StringBuffer xmlDump, boolean includeMeta) {
+	public void writeNode(Node node, StringBuilder xmlDump, boolean includeMeta) {
 		SubProcessNode subProcessNode = (SubProcessNode) node;
 		writeNode("subProcess", subProcessNode, xmlDump, includeMeta);
         String processId = subProcessNode.getProcessId();

Modified: labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/xml/processes/TimerNodeHandler.java
===================================================================
--- labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/xml/processes/TimerNodeHandler.java	2009-05-14 00:32:35 UTC (rev 26521)
+++ labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/xml/processes/TimerNodeHandler.java	2009-05-14 02:17:06 UTC (rev 26522)
@@ -40,7 +40,7 @@
         return TimerNode.class;
     }
 
-	public void writeNode(Node node, StringBuffer xmlDump, boolean includeMeta) {
+	public void writeNode(Node node, StringBuilder xmlDump, boolean includeMeta) {
 		TimerNode timerNode = (TimerNode) node;
 		writeNode("timerNode", timerNode, xmlDump, includeMeta);
         Timer timer = timerNode.getTimer();

Modified: labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/xml/processes/WorkItemNodeHandler.java
===================================================================
--- labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/xml/processes/WorkItemNodeHandler.java	2009-05-14 00:32:35 UTC (rev 26521)
+++ labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/xml/processes/WorkItemNodeHandler.java	2009-05-14 02:17:06 UTC (rev 26522)
@@ -38,7 +38,7 @@
         return WorkItemNode.class;
     }
 
-	public void writeNode(Node node, StringBuffer xmlDump, boolean includeMeta) {
+	public void writeNode(Node node, StringBuilder xmlDump, boolean includeMeta) {
 		WorkItemNode workItemNode = (WorkItemNode) node;
 		writeNode("workItem", workItemNode, xmlDump, includeMeta);
         visitParameters(workItemNode, xmlDump);
@@ -54,13 +54,13 @@
         endNode("workItem", xmlDump);
 	}
 	
-	protected void visitParameters(WorkItemNode workItemNode, StringBuffer xmlDump) {
+	protected void visitParameters(WorkItemNode workItemNode, StringBuilder xmlDump) {
 	    if (!workItemNode.isWaitForCompletion()) {
             xmlDump.append("waitForCompletion=\"false\" ");
         }
 	}
 	
-	protected void visitInMappings(Map<String, String> inMappings, StringBuffer xmlDump) {
+	protected void visitInMappings(Map<String, String> inMappings, StringBuilder xmlDump) {
         for (Map.Entry<String, String> inMapping: inMappings.entrySet()) {
             xmlDump.append(
                 "      <mapping type=\"in\" "
@@ -69,7 +69,7 @@
         }
 	}
 	
-	protected void visitOutMappings(Map<String, String> outMappings, StringBuffer xmlDump) {
+	protected void visitOutMappings(Map<String, String> outMappings, StringBuilder xmlDump) {
         for (Map.Entry<String, String> outMapping: outMappings.entrySet()) {
             xmlDump.append(
                 "      <mapping type=\"out\" "
@@ -78,7 +78,7 @@
         }
     }
     
-    protected void visitWork(Work work, StringBuffer xmlDump, boolean includeMeta) {
+    protected void visitWork(Work work, StringBuilder xmlDump, boolean includeMeta) {
         if (work != null) {
             xmlDump.append("      <work name=\"" + work.getName() + "\" >" + EOL);
             List<ParameterDefinition> parameterDefinitions =

Modified: labs/jbossrules/trunk/drools-compiler/src/main/resources/org/drools/lang/dsl/DSLMapWalker.g
===================================================================
--- labs/jbossrules/trunk/drools-compiler/src/main/resources/org/drools/lang/dsl/DSLMapWalker.g	2009-05-14 00:32:35 UTC (rev 26521)
+++ labs/jbossrules/trunk/drools-compiler/src/main/resources/org/drools/lang/dsl/DSLMapWalker.g	2009-05-14 02:17:06 UTC (rev 26522)
@@ -36,18 +36,18 @@
 scope {
 	Map<String,Integer> variables;
 	AntlrDSLMappingEntry retval;
-	StringBuffer keybuffer;
-	StringBuffer valuebuffer;
-	StringBuffer sentenceKeyBuffer;
-	StringBuffer sentenceValueBuffer;
+	StringBuilder keybuffer;
+	StringBuilder valuebuffer;
+	StringBuilder sentenceKeyBuffer;
+	StringBuilder sentenceValueBuffer;
 }
 @init {
 	$entry::retval = new AntlrDSLMappingEntry() ;
 	$entry::variables = new HashMap<String,Integer>();
-	$entry::keybuffer = new StringBuffer();
-	$entry::valuebuffer = new StringBuffer();
-	$entry::sentenceKeyBuffer = new StringBuffer();
-	$entry::sentenceValueBuffer = new StringBuffer();
+	$entry::keybuffer = new StringBuilder();
+	$entry::valuebuffer = new StringBuilder();
+	$entry::sentenceKeyBuffer = new StringBuilder();
+	$entry::sentenceValueBuffer = new StringBuilder();
 }
 	: ^(VT_ENTRY scope_section meta_section? key_section 
 	        {    $entry::retval.setVariables( $entry::variables ); 

Modified: labs/jbossrules/trunk/drools-compiler/src/main/resources/org/drools/semantics/java/parser/Java.g
===================================================================
--- labs/jbossrules/trunk/drools-compiler/src/main/resources/org/drools/semantics/java/parser/Java.g	2009-05-14 00:32:35 UTC (rev 26521)
+++ labs/jbossrules/trunk/drools-compiler/src/main/resources/org/drools/semantics/java/parser/Java.g	2009-05-14 02:17:06 UTC (rev 26522)
@@ -137,7 +137,7 @@
      	/** This will take a RecognitionException, and create a sensible error message out of it */
      	public String createErrorMessage(RecognitionException e)
         {
-		StringBuffer message = new StringBuffer();		
+		StringBuilder message = new StringBuilder();		
                 message.append( source + ":"+e.line+":"+e.charPositionInLine+" ");
                 if ( e instanceof MismatchedTokenException ) {
                         MismatchedTokenException mte = (MismatchedTokenException)e;

Modified: labs/jbossrules/trunk/drools-compiler/src/test/java/org/drools/guvnor/modeldriven/DataEnumLoaderTest.java
===================================================================
--- labs/jbossrules/trunk/drools-compiler/src/test/java/org/drools/guvnor/modeldriven/DataEnumLoaderTest.java	2009-05-14 00:32:35 UTC (rev 26521)
+++ labs/jbossrules/trunk/drools-compiler/src/test/java/org/drools/guvnor/modeldriven/DataEnumLoaderTest.java	2009-05-14 02:17:06 UTC (rev 26522)
@@ -114,10 +114,10 @@
 
     }
 
-	private StringBuffer readLines() throws IOException {
+	private StringBuilder readLines() throws IOException {
 		BufferedReader r = new BufferedReader(new InputStreamReader(this.getClass().getResourceAsStream("Some.enumeration")));
 		String line = "";
-		StringBuffer buf = new StringBuffer();
+		StringBuilder buf = new StringBuilder();
 		while ((line = r.readLine()) != null) {
 			buf.append(line); buf.append('\n');
 		}

Modified: labs/jbossrules/trunk/drools-compiler/src/test/java/org/drools/guvnor/server/util/BRLPersitenceTest.java
===================================================================
--- labs/jbossrules/trunk/drools-compiler/src/test/java/org/drools/guvnor/server/util/BRLPersitenceTest.java	2009-05-14 00:32:35 UTC (rev 26521)
+++ labs/jbossrules/trunk/drools-compiler/src/test/java/org/drools/guvnor/server/util/BRLPersitenceTest.java	2009-05-14 02:17:06 UTC (rev 26522)
@@ -216,7 +216,7 @@
 
         final Reader reader = new InputStreamReader( in );
 
-        final StringBuffer text = new StringBuffer();
+        final StringBuilder text = new StringBuilder();
 
         final char[] buf = new char[1024];
         int len = 0;

Modified: labs/jbossrules/trunk/drools-compiler/src/test/java/org/drools/integrationtests/LargeRuleBase.java
===================================================================
--- labs/jbossrules/trunk/drools-compiler/src/test/java/org/drools/integrationtests/LargeRuleBase.java	2009-05-14 00:32:35 UTC (rev 26521)
+++ labs/jbossrules/trunk/drools-compiler/src/test/java/org/drools/integrationtests/LargeRuleBase.java	2009-05-14 02:17:06 UTC (rev 26522)
@@ -40,7 +40,7 @@
 
 	private static void bigBlobCompile() throws DroolsParserException,
 			IOException, Exception {
-		StringBuffer buf = new StringBuffer();
+		StringBuilder buf = new StringBuilder();
 		buf.append(getHeader());
 
 		for (int i = 0; i < RULE_COUNT; i++) {

Modified: labs/jbossrules/trunk/drools-compiler/src/test/java/org/drools/integrationtests/PackageBuilderThreadSafetyTest.java
===================================================================
--- labs/jbossrules/trunk/drools-compiler/src/test/java/org/drools/integrationtests/PackageBuilderThreadSafetyTest.java	2009-05-14 00:32:35 UTC (rev 26521)
+++ labs/jbossrules/trunk/drools-compiler/src/test/java/org/drools/integrationtests/PackageBuilderThreadSafetyTest.java	2009-05-14 02:17:06 UTC (rev 26522)
@@ -89,7 +89,7 @@
                 threads[i].interrupt();
             }
         }
-        StringBuffer exceptionBuf = new StringBuffer();
+        StringBuilder exceptionBuf = new StringBuilder();
         if (!exceptions.isEmpty()) {
         	System.err.println("------->EXCEPTION(s) DURING THREAD TEST : <-------------------");
             for (Iterator<Exception> iterator = exceptions.iterator(); iterator.hasNext();) {
@@ -98,7 +98,7 @@
 			}
         }
 
-        StringBuffer errorBuf = new StringBuffer();
+        StringBuilder errorBuf = new StringBuilder();
         if (!errors.isEmpty()) {
         	System.err.println("------->ERROR(s) DURING THREAD TEST : <-------------------");
             for (Iterator<PackageBuilderErrors> iterator = errors.iterator(); iterator.hasNext();) {

Modified: labs/jbossrules/trunk/drools-compiler/src/test/java/org/drools/lang/ErrorsParserTest.java
===================================================================
--- labs/jbossrules/trunk/drools-compiler/src/test/java/org/drools/lang/ErrorsParserTest.java	2009-05-14 00:32:35 UTC (rev 26521)
+++ labs/jbossrules/trunk/drools-compiler/src/test/java/org/drools/lang/ErrorsParserTest.java	2009-05-14 02:17:06 UTC (rev 26522)
@@ -258,7 +258,7 @@
 
         final Reader reader = getReader( name );
 
-        final StringBuffer text = new StringBuffer();
+        final StringBuilder text = new StringBuilder();
 
         final char[] buf = new char[1024];
         int len = 0;

Modified: labs/jbossrules/trunk/drools-compiler/src/test/java/org/drools/lang/RuleParserTest.java
===================================================================
--- labs/jbossrules/trunk/drools-compiler/src/test/java/org/drools/lang/RuleParserTest.java	2009-05-14 00:32:35 UTC (rev 26521)
+++ labs/jbossrules/trunk/drools-compiler/src/test/java/org/drools/lang/RuleParserTest.java	2009-05-14 02:17:06 UTC (rev 26522)
@@ -4052,7 +4052,7 @@
         // System.err.println( getClass().getResource( name ) );
         final Reader reader = getReader( name );
 
-        final StringBuffer text = new StringBuffer();
+        final StringBuilder text = new StringBuilder();
 
         final char[] buf = new char[1024];
         int len = 0;

Modified: labs/jbossrules/trunk/drools-compiler/src/test/java/org/drools/xml/rules/DumperTestHelper.java
===================================================================
--- labs/jbossrules/trunk/drools-compiler/src/test/java/org/drools/xml/rules/DumperTestHelper.java	2009-05-14 00:32:35 UTC (rev 26521)
+++ labs/jbossrules/trunk/drools-compiler/src/test/java/org/drools/xml/rules/DumperTestHelper.java	2009-05-14 02:17:06 UTC (rev 26522)
@@ -64,7 +64,7 @@
 
     private static String readFile(final String file) throws IOException {
         final InputStreamReader reader = new InputStreamReader( DumperTestHelper.class.getResourceAsStream( file ) );
-        final StringBuffer text = new StringBuffer();
+        final StringBuilder text = new StringBuilder();
         final char[] buf = new char[1024];
         int len = 0;
 

Modified: labs/jbossrules/trunk/drools-core/src/main/java/org/drools/agent/FileScanner.java
===================================================================
--- labs/jbossrules/trunk/drools-core/src/main/java/org/drools/agent/FileScanner.java	2009-05-14 00:32:35 UTC (rev 26521)
+++ labs/jbossrules/trunk/drools-core/src/main/java/org/drools/agent/FileScanner.java	2009-05-14 02:17:06 UTC (rev 26522)
@@ -172,7 +172,7 @@
     }
 
     public String toString() {
-        StringBuffer buf = new StringBuffer();
+        StringBuilder buf = new StringBuilder();
         buf.append( "FileScanner scanning: " );
         for ( int i = 0; i < files.length; i++ ) {
             File f = files[i];

Modified: labs/jbossrules/trunk/drools-core/src/main/java/org/drools/audit/WorkingMemoryLogger.java
===================================================================
--- labs/jbossrules/trunk/drools-core/src/main/java/org/drools/audit/WorkingMemoryLogger.java	2009-05-14 00:32:35 UTC (rev 26521)
+++ labs/jbossrules/trunk/drools-core/src/main/java/org/drools/audit/WorkingMemoryLogger.java	2009-05-14 02:17:06 UTC (rev 26522)
@@ -299,7 +299,7 @@
      * @return A String represetation of the declarations of the activation.
      */
     private String extractDeclarations(final Activation activation,  final WorkingMemory workingMemory) {
-        final StringBuffer result = new StringBuffer();
+        final StringBuilder result = new StringBuilder();
         final Tuple tuple = activation.getTuple();
         final Map<?, ?> declarations = activation.getSubRule().getOuterDeclarations();
         for ( Iterator<?> it = declarations.values().iterator(); it.hasNext(); ) {
@@ -343,7 +343,7 @@
      * @return A unique id for the activation
      */
     private static String getActivationId(final Activation activation) {
-        final StringBuffer result = new StringBuffer( activation.getRule().getName() );
+        final StringBuilder result = new StringBuilder( activation.getRule().getName() );
         result.append( " [" );
         final Tuple tuple = activation.getTuple();
         final FactHandle[] handles = tuple.getFactHandles();

Modified: labs/jbossrules/trunk/drools-core/src/main/java/org/drools/base/ClassTypeResolver.java
===================================================================
--- labs/jbossrules/trunk/drools-core/src/main/java/org/drools/base/ClassTypeResolver.java	2009-05-14 00:32:35 UTC (rev 26521)
+++ labs/jbossrules/trunk/drools-core/src/main/java/org/drools/base/ClassTypeResolver.java	2009-05-14 02:17:06 UTC (rev 26522)
@@ -112,7 +112,7 @@
     public Class resolveType(String className) throws ClassNotFoundException {
         Class clazz = null;
         boolean isArray = false;
-        final StringBuffer arrayClassName = new StringBuffer();
+        final StringBuilder arrayClassName = new StringBuilder();
 
         //is the class a primitive type ?
         if ( internalNamesMap.containsKey( className ) ) {
@@ -163,7 +163,7 @@
             // If there are more than one possible resolutions, complain about
             // the ambiguity
             if ( validClazzCandidates.size() > 1 ) {
-                final StringBuffer sb = new StringBuffer();
+                final StringBuilder sb = new StringBuilder();
                 final Iterator clazzCandIter = validClazzCandidates.iterator();
                 while ( clazzCandIter.hasNext() ) {
                     if ( 0 != sb.length() ) {

Modified: labs/jbossrules/trunk/drools-core/src/main/java/org/drools/factmodel/ClassBuilder.java
===================================================================
--- labs/jbossrules/trunk/drools-core/src/main/java/org/drools/factmodel/ClassBuilder.java	2009-05-14 00:32:35 UTC (rev 26521)
+++ labs/jbossrules/trunk/drools-core/src/main/java/org/drools/factmodel/ClassBuilder.java	2009-05-14 02:17:06 UTC (rev 26522)
@@ -739,12 +739,12 @@
                 mv.visitLabel( l0 );
             }
 
-            // StringBuffer buf = new StringBuffer();
+            // StringBuilder buf = new StringBuilder();
             mv.visitTypeInsn( Opcodes.NEW,
-                              Type.getInternalName( StringBuffer.class ) );
+                              Type.getInternalName( StringBuilder.class ) );
             mv.visitInsn( Opcodes.DUP );
             mv.visitMethodInsn( Opcodes.INVOKESPECIAL,
-                                Type.getInternalName( StringBuffer.class ),
+                                Type.getInternalName( StringBuilder.class ),
                                 "<init>",
                                 "()V" );
             mv.visitVarInsn( Opcodes.ASTORE,
@@ -764,16 +764,16 @@
                                 "getSimpleName",
                                 "()Ljava/lang/String;" );
             mv.visitMethodInsn( Opcodes.INVOKEVIRTUAL,
-                                Type.getInternalName( StringBuffer.class ),
+                                Type.getInternalName( StringBuilder.class ),
                                 "append",
-                                "(Ljava/lang/String;)Ljava/lang/StringBuffer;" );
+                                "(Ljava/lang/String;)Ljava/lang/StringBuilder;" );
 
             // buf.append("( ");
             mv.visitLdcInsn( "( " );
             mv.visitMethodInsn( Opcodes.INVOKEVIRTUAL,
-                                Type.getInternalName( StringBuffer.class ),
+                                Type.getInternalName( StringBuilder.class ),
                                 "append",
-                                "(Ljava/lang/String;)Ljava/lang/StringBuffer;" );
+                                "(Ljava/lang/String;)Ljava/lang/StringBuilder;" );
 
             boolean previous = false;
             for ( FieldDefinition field : classDef.getFieldsDefinitions() ) {
@@ -781,23 +781,23 @@
                     // buf.append(", ");
                     mv.visitLdcInsn( ", " );
                     mv.visitMethodInsn( Opcodes.INVOKEVIRTUAL,
-                                        Type.getInternalName( StringBuffer.class ),
+                                        Type.getInternalName( StringBuilder.class ),
                                         "append",
-                                        "(Ljava/lang/String;)Ljava/lang/StringBuffer;" );
+                                        "(Ljava/lang/String;)Ljava/lang/StringBuilder;" );
                 }
                 // buf.append(attrName)
                 mv.visitLdcInsn( field.getName() );
                 mv.visitMethodInsn( Opcodes.INVOKEVIRTUAL,
-                                    Type.getInternalName( StringBuffer.class ),
+                                    Type.getInternalName( StringBuilder.class ),
                                     "append",
-                                    "(Ljava/lang/String;)Ljava/lang/StringBuffer;" );
+                                    "(Ljava/lang/String;)Ljava/lang/StringBuilder;" );
 
                 // buf.append("=");
                 mv.visitLdcInsn( "=" );
                 mv.visitMethodInsn( Opcodes.INVOKEVIRTUAL,
-                                    Type.getInternalName( StringBuffer.class ),
+                                    Type.getInternalName( StringBuilder.class ),
                                     "append",
-                                    "(Ljava/lang/String;)Ljava/lang/StringBuffer;" );
+                                    "(Ljava/lang/String;)Ljava/lang/StringBuilder;" );
 
                 // buf.append(attrValue)
                 mv.visitVarInsn( Opcodes.ALOAD,
@@ -809,15 +809,15 @@
 
                 if ( isPrimitive( field.getTypeName() ) ) {
                     mv.visitMethodInsn( Opcodes.INVOKEVIRTUAL,
-                                        Type.getInternalName( StringBuffer.class ),
+                                        Type.getInternalName( StringBuilder.class ),
                                         "append",
-                                        Type.getMethodDescriptor( Type.getType( StringBuffer.class ),
+                                        Type.getMethodDescriptor( Type.getType( StringBuilder.class ),
                                                                   new Type[]{Type.getType( getTypeDescriptor( field.getTypeName() ) )} ) );
                 } else {
                     mv.visitMethodInsn( Opcodes.INVOKEVIRTUAL,
-                                        Type.getInternalName( StringBuffer.class ),
+                                        Type.getInternalName( StringBuilder.class ),
                                         "append",
-                                        Type.getMethodDescriptor( Type.getType( StringBuffer.class ),
+                                        Type.getMethodDescriptor( Type.getType( StringBuilder.class ),
                                                                   new Type[]{Type.getType( Object.class )} ) );
                 }
                 previous = true;
@@ -825,11 +825,11 @@
 
             mv.visitLdcInsn( " )" );
             mv.visitMethodInsn( Opcodes.INVOKEVIRTUAL,
-                                Type.getInternalName( StringBuffer.class ),
+                                Type.getInternalName( StringBuilder.class ),
                                 "append",
-                                "(Ljava/lang/String;)Ljava/lang/StringBuffer;" );
+                                "(Ljava/lang/String;)Ljava/lang/StringBuilder;" );
             mv.visitMethodInsn( Opcodes.INVOKEVIRTUAL,
-                                Type.getInternalName( StringBuffer.class ),
+                                Type.getInternalName( StringBuilder.class ),
                                 "toString",
                                 "()Ljava/lang/String;" );
             mv.visitInsn( Opcodes.ARETURN );
@@ -845,7 +845,7 @@
                                        lastLabel,
                                        0 );
                 mv.visitLocalVariable( "buf",
-                                       Type.getDescriptor( StringBuffer.class ),
+                                       Type.getDescriptor( StringBuilder.class ),
                                        null,
                                        l0,
                                        lastLabel,

Modified: labs/jbossrules/trunk/drools-core/src/main/java/org/drools/facttemplates/FactTemplateImpl.java
===================================================================
--- labs/jbossrules/trunk/drools-core/src/main/java/org/drools/facttemplates/FactTemplateImpl.java	2009-05-14 00:32:35 UTC (rev 26521)
+++ labs/jbossrules/trunk/drools-core/src/main/java/org/drools/facttemplates/FactTemplateImpl.java	2009-05-14 02:17:06 UTC (rev 26522)
@@ -149,7 +149,7 @@
      * for the slot type
      */
     public String toString() {
-        final StringBuffer buf = new StringBuffer();
+        final StringBuilder buf = new StringBuilder();
         buf.append( "(" + this.name + " " );
         //        for (int idx=0; idx < this.slots.length; idx++){
         //            buf.append("(" + this.slots[idx].getName() +

Modified: labs/jbossrules/trunk/drools-core/src/main/java/org/drools/process/core/context/variable/Variable.java
===================================================================
--- labs/jbossrules/trunk/drools-core/src/main/java/org/drools/process/core/context/variable/Variable.java	2009-05-14 00:32:35 UTC (rev 26521)
+++ labs/jbossrules/trunk/drools-core/src/main/java/org/drools/process/core/context/variable/Variable.java	2009-05-14 02:17:06 UTC (rev 26522)
@@ -67,7 +67,7 @@
         if ( this.type.verifyDataType( value ) ) {
             this.value = value;
         } else {
-            final StringBuffer sb = new StringBuffer();
+            final StringBuilder sb = new StringBuilder();
             sb.append( "Value <" );
             sb.append( value );
             sb.append( "> is not valid for datatype: " );

Modified: labs/jbossrules/trunk/drools-core/src/main/java/org/drools/process/instance/impl/ProcessInstanceImpl.java
===================================================================
--- labs/jbossrules/trunk/drools-core/src/main/java/org/drools/process/instance/impl/ProcessInstanceImpl.java	2009-05-14 00:32:35 UTC (rev 26521)
+++ labs/jbossrules/trunk/drools-core/src/main/java/org/drools/process/instance/impl/ProcessInstanceImpl.java	2009-05-14 02:17:06 UTC (rev 26522)
@@ -203,7 +203,7 @@
     }
     
     public String toString() {
-        final StringBuffer b = new StringBuffer( "ProcessInstance " );
+        final StringBuilder b = new StringBuilder( "ProcessInstance " );
         b.append( getId() );
         b.append( " [processId=" );
         b.append( this.process.getId() );

Modified: labs/jbossrules/trunk/drools-core/src/main/java/org/drools/reteoo/LeftTuple.java
===================================================================
--- labs/jbossrules/trunk/drools-core/src/main/java/org/drools/reteoo/LeftTuple.java	2009-05-14 00:32:35 UTC (rev 26521)
+++ labs/jbossrules/trunk/drools-core/src/main/java/org/drools/reteoo/LeftTuple.java	2009-05-14 02:17:06 UTC (rev 26522)
@@ -365,7 +365,7 @@
     }
 
     public String toString() {
-        final StringBuffer buffer = new StringBuffer();
+        final StringBuilder buffer = new StringBuilder();
 
         LeftTuple entry = this;
         while ( entry != null ) {

Modified: labs/jbossrules/trunk/drools-core/src/main/java/org/drools/reteoo/MemoryVisitor.java
===================================================================
--- labs/jbossrules/trunk/drools-core/src/main/java/org/drools/reteoo/MemoryVisitor.java	2009-05-14 00:32:35 UTC (rev 26521)
+++ labs/jbossrules/trunk/drools-core/src/main/java/org/drools/reteoo/MemoryVisitor.java	2009-05-14 02:17:06 UTC (rev 26522)
@@ -272,7 +272,7 @@
     }
 
     private String indent() {
-        final StringBuffer buffer = new StringBuffer();
+        final StringBuilder buffer = new StringBuilder();
         for ( int i = 0; i < this.indent; i++ ) {
             buffer.append( "  " );
         }

Modified: labs/jbossrules/trunk/drools-core/src/main/java/org/drools/reteoo/builder/BuildUtils.java
===================================================================
--- labs/jbossrules/trunk/drools-core/src/main/java/org/drools/reteoo/builder/BuildUtils.java	2009-05-14 00:32:35 UTC (rev 26521)
+++ labs/jbossrules/trunk/drools-core/src/main/java/org/drools/reteoo/builder/BuildUtils.java	2009-05-14 02:17:06 UTC (rev 26522)
@@ -253,7 +253,7 @@
 
         // Make sure the required declarations
         if ( list.size() != 0 ) {
-            final StringBuffer buffer = new StringBuffer();
+            final StringBuilder buffer = new StringBuilder();
             buffer.append( list.get( 0 ) );
             for ( int i = 1, size = list.size(); i < size; i++ ) {
                 buffer.append( ", " + list.get( i ) );

Modified: labs/jbossrules/trunk/drools-core/src/main/java/org/drools/util/ClassUtils.java
===================================================================
--- labs/jbossrules/trunk/drools-core/src/main/java/org/drools/util/ClassUtils.java	2009-05-14 00:32:35 UTC (rev 26521)
+++ labs/jbossrules/trunk/drools-core/src/main/java/org/drools/util/ClassUtils.java	2009-05-14 02:17:06 UTC (rev 26522)
@@ -68,7 +68,7 @@
     }
 
     public static String canonicalName(Class clazz) {
-        StringBuffer name = new StringBuffer();
+        StringBuilder name = new StringBuilder();
 
         if ( clazz.isArray() ) {
             name.append( canonicalName( clazz.getComponentType() ) );

Modified: labs/jbossrules/trunk/drools-core/src/main/java/org/drools/util/StringUtils.java
===================================================================
--- labs/jbossrules/trunk/drools-core/src/main/java/org/drools/util/StringUtils.java	2009-05-14 00:32:35 UTC (rev 26521)
+++ labs/jbossrules/trunk/drools-core/src/main/java/org/drools/util/StringUtils.java	2009-05-14 02:17:06 UTC (rev 26522)
@@ -145,7 +145,7 @@
     // String.charAt(n) is best bet overall
     //
     // Append:
-    // String.concat about twice as fast as StringBuffer.append
+    // String.concat about twice as fast as StringBuilder.append
     // (not sure who tested this)
 
     /**
@@ -273,7 +273,7 @@
                 }
                 return new String( output2 );
             default :
-                final StringBuffer buf = new StringBuffer( outputLength );
+                final StringBuilder buf = new StringBuilder( outputLength );
                 for ( int i = 0; i < repeat; i++ ) {
                     buf.append( str );
                 }
@@ -772,7 +772,7 @@
      */
     public static String readFileAsString(Reader reader) {
         try {
-            StringBuffer fileData = new StringBuffer( 1000 );
+            StringBuilder fileData = new StringBuilder( 1000 );
             char[] buf = new char[1024];
             int numRead = 0;
             while ( (numRead = reader.read( buf )) != -1 ) {
@@ -835,7 +835,7 @@
             return;
         }
         int sz = str.length();
-        StringBuffer unicode = new StringBuffer(4);
+        StringBuilder unicode = new StringBuilder(4);
         boolean hadSlash = false;
         boolean inUnicode = false;
         for (int i = 0; i < sz; i++) {
@@ -1024,7 +1024,7 @@
         if (coll == null || coll.isEmpty()) {
             return "";
         }
-        StringBuffer sb = new StringBuffer();
+        StringBuilder sb = new StringBuilder();
         Iterator it = coll.iterator();
         while (it.hasNext()) {
             sb.append(prefix).append(it.next()).append(suffix);
@@ -1063,8 +1063,8 @@
         if (isEmpty(inString) || isEmpty(oldPattern) || newPattern == null) {
             return inString;
         }
-        StringBuffer sbuf = new StringBuffer();
-        // output StringBuffer we'll build up
+        StringBuilder sbuf = new StringBuilder();
+        // output StringBuilder we'll build up
         int pos = 0; // our position in the old string
         int index = inString.indexOf(oldPattern);
         // the index of an occurrence we've found, or -1
@@ -1175,7 +1175,7 @@
         if (isEmpty(inString) || isEmpty(charsToDelete)) {
             return inString;
         }
-        StringBuffer out = new StringBuffer();
+        StringBuilder out = new StringBuilder();
         for (int i = 0; i < inString.length(); i++) {
             char c = inString.charAt(i);
             if (charsToDelete.indexOf(c) == -1) {

Modified: labs/jbossrules/trunk/drools-core/src/main/java/org/drools/workflow/core/impl/ConnectionImpl.java
===================================================================
--- labs/jbossrules/trunk/drools-core/src/main/java/org/drools/workflow/core/impl/ConnectionImpl.java	2009-05-14 00:32:35 UTC (rev 26521)
+++ labs/jbossrules/trunk/drools-core/src/main/java/org/drools/workflow/core/impl/ConnectionImpl.java	2009-05-14 02:17:06 UTC (rev 26522)
@@ -125,7 +125,7 @@
     }
     
     public String toString() {
-        final StringBuffer sb = new StringBuffer("Connection ");
+        final StringBuilder sb = new StringBuilder("Connection ");
         sb.append(getFrom());
         sb.append(" [type=");
         sb.append(getFromType());

Modified: labs/jbossrules/trunk/drools-core/src/main/java/org/drools/workflow/instance/impl/WorkflowProcessInstanceImpl.java
===================================================================
--- labs/jbossrules/trunk/drools-core/src/main/java/org/drools/workflow/instance/impl/WorkflowProcessInstanceImpl.java	2009-05-14 00:32:35 UTC (rev 26521)
+++ labs/jbossrules/trunk/drools-core/src/main/java/org/drools/workflow/instance/impl/WorkflowProcessInstanceImpl.java	2009-05-14 02:17:06 UTC (rev 26522)
@@ -214,7 +214,7 @@
 	}
 
 	public String toString() {
-		final StringBuffer sb = new StringBuffer("WorkflowProcessInstance");
+		final StringBuilder sb = new StringBuilder("WorkflowProcessInstance");
 		sb.append(getId());
 		sb.append(" [processId=");
 		sb.append(getProcess().getId());

Modified: labs/jbossrules/trunk/drools-core/src/test/java/org/drools/FirstClass.java
===================================================================
--- labs/jbossrules/trunk/drools-core/src/test/java/org/drools/FirstClass.java	2009-05-14 00:32:35 UTC (rev 26521)
+++ labs/jbossrules/trunk/drools-core/src/test/java/org/drools/FirstClass.java	2009-05-14 02:17:06 UTC (rev 26522)
@@ -48,7 +48,7 @@
 	}
 	
 	public String toString() {
-		StringBuffer buf = new StringBuffer();
+		StringBuilder buf = new StringBuilder();
 		buf.append("FirstClass[");
 		buf.append("item1=" + item1 + ", ");
 		buf.append("item2=" + item2 + ", ");

Modified: labs/jbossrules/trunk/drools-core/src/test/java/org/drools/SecondClass.java
===================================================================
--- labs/jbossrules/trunk/drools-core/src/test/java/org/drools/SecondClass.java	2009-05-14 00:32:35 UTC (rev 26521)
+++ labs/jbossrules/trunk/drools-core/src/test/java/org/drools/SecondClass.java	2009-05-14 02:17:06 UTC (rev 26522)
@@ -39,7 +39,7 @@
 	}
 	
 	public String toString() {
-		StringBuffer buf = new StringBuffer();
+		StringBuilder buf = new StringBuilder();
 		buf.append("SecondClass[");
 		buf.append("item1=" + item1 + ", ");
 		buf.append("item2=" + item2 + ", ");




More information about the jboss-svn-commits mailing list