[jboss-svn-commits] JBoss Common SVN: r3653 - in shrinkwrap/trunk/impl-base/src: test/java/org/jboss/shrinkwrap/impl/base and 1 other directory.

[jboss-svn-commits at lists.jboss.org]

Author: aslak
Date: 2009-11-11 03:16:57 -0500 (Wed, 11 Nov 2009)
New Revision: 3653

Modified:
   shrinkwrap/trunk/impl-base/src/main/java/org/jboss/shrinkwrap/impl/base/Archives.java
   shrinkwrap/trunk/impl-base/src/test/java/org/jboss/shrinkwrap/impl/base/ArchivesTestCase.java
Log:
SHRINKWARP-50 Changed Archives.create so you can get back something useful on first call. Avoid always having to call .as 

Modified: shrinkwrap/trunk/impl-base/src/main/java/org/jboss/shrinkwrap/impl/base/Archives.java
===================================================================
--- shrinkwrap/trunk/impl-base/src/main/java/org/jboss/shrinkwrap/impl/base/Archives.java	2009-11-10 17:36:46 UTC (rev 3652)
+++ shrinkwrap/trunk/impl-base/src/main/java/org/jboss/shrinkwrap/impl/base/Archives.java	2009-11-11 08:16:57 UTC (rev 3653)
@@ -36,8 +36,8 @@
     * @param archiveName The name of the archive
     * @return A {@link Specializer} archive base  
     */
-   public static Specializer create(String archiveName) {
-      return new MemoryMapArchiveImpl(archiveName);
+   public static <T extends Specializer> T create(String archiveName, Class<T> type) {
+      return new MemoryMapArchiveImpl(archiveName).as(type);
    }
    
    //-------------------------------------------------------------------------------------||

Modified: shrinkwrap/trunk/impl-base/src/test/java/org/jboss/shrinkwrap/impl/base/ArchivesTestCase.java
===================================================================
--- shrinkwrap/trunk/impl-base/src/test/java/org/jboss/shrinkwrap/impl/base/ArchivesTestCase.java	2009-11-10 17:36:46 UTC (rev 3652)
+++ shrinkwrap/trunk/impl-base/src/test/java/org/jboss/shrinkwrap/impl/base/ArchivesTestCase.java	2009-11-11 08:16:57 UTC (rev 3653)
@@ -18,8 +18,7 @@
 
 import junit.framework.Assert;
 
-import org.jboss.shrinkwrap.api.Specializer;
-import org.jboss.shrinkwrap.spi.MemoryMapArchive;
+import org.jboss.shrinkwrap.api.spec.JavaArchive;
 import org.junit.Test;
 
 
@@ -36,18 +35,14 @@
    public void shouldBeAbleToCreateANewArchive() throws Exception {
       String archiveName = "test.war";
       
-      Specializer archive = Archives.create(archiveName);
+      JavaArchive archive = Archives.create(archiveName, JavaArchive.class);
       
       Assert.assertNotNull(
             "A archive should have been created", archive);
       
-      Assert.assertTrue(
-            "A MemoryMapArchive should have been created", 
-            archive instanceof MemoryMapArchive);
-      
       Assert.assertEquals(
             "Should have the same name as given imput", 
             archiveName, 
-            ((MemoryMapArchive)archive).getName());
+            archive.getName());
    }
 }