[jboss-svn-commits] JBoss Common SVN: r3659 - shrinkwrap/trunk/impl-base/src/main/java/org/jboss/shrinkwrap/impl/base.

[jboss-svn-commits at lists.jboss.org]

Author: aslak
Date: 2009-11-11 04:49:05 -0500 (Wed, 11 Nov 2009)
New Revision: 3659

Modified:
   shrinkwrap/trunk/impl-base/src/main/java/org/jboss/shrinkwrap/impl/base/EnterpriseContainerBase.java
Log:
SHRINKWRAP-70 Added input validation

Modified: shrinkwrap/trunk/impl-base/src/main/java/org/jboss/shrinkwrap/impl/base/EnterpriseContainerBase.java
===================================================================
--- shrinkwrap/trunk/impl-base/src/main/java/org/jboss/shrinkwrap/impl/base/EnterpriseContainerBase.java	2009-11-11 09:45:10 UTC (rev 3658)
+++ shrinkwrap/trunk/impl-base/src/main/java/org/jboss/shrinkwrap/impl/base/EnterpriseContainerBase.java	2009-11-11 09:49:05 UTC (rev 3659)
@@ -260,7 +260,7 @@
    public T addModule(String resourceName)
    {
       Validate.notNull(resourceName, "ResourceName must be specified");
-      ;
+      
       Path location = new BasicPath(AssetUtil.getNameForClassloaderResource(resourceName));
       return addModule(location, resourceName);
    }
@@ -325,6 +325,9 @@
    @Override
    public T addModule(final String targetPath, final File resource) throws IllegalArgumentException
    {
+      Validate.notNull(targetPath, "Target Path must be specified");
+      Validate.notNull(resource, "Resource must be specified");
+      
       return addModule(new BasicPath(targetPath), resource);
    }
 
@@ -334,6 +337,9 @@
    @Override
    public T addModule(final String targetPath, final String resourceName) throws IllegalArgumentException
    {
+      Validate.notNull(targetPath, "Target Path must be specified");
+      Validate.notNull(resourceName, "Resource must be specified");
+
       return addModule(new BasicPath(targetPath), resourceName);
    }
 
@@ -343,6 +349,9 @@
    @Override
    public T addModule(final String targetPath, final URL resource) throws IllegalArgumentException
    {
+      Validate.notNull(targetPath, "Target Path must be specified");
+      Validate.notNull(resource, "Resource must be specified");
+      
       return addModule(new BasicPath(targetPath), resource);
    }
 }