[jboss-svn-commits] JBoss Common SVN: r3545 - jboss-logmanager/trunk/src/main/java/org/jboss/logmanager.

jboss-svn-commits at lists.jboss.org jboss-svn-commits at lists.jboss.org
Tue Sep 29 11:27:36 EDT 2009


Author: david.lloyd at jboss.com
Date: 2009-09-29 11:27:36 -0400 (Tue, 29 Sep 2009)
New Revision: 3545

Modified:
   jboss-logmanager/trunk/src/main/java/org/jboss/logmanager/LogContext.java
Log:
Findbugs: null pointer is always dereferenced

Modified: jboss-logmanager/trunk/src/main/java/org/jboss/logmanager/LogContext.java
===================================================================
--- jboss-logmanager/trunk/src/main/java/org/jboss/logmanager/LogContext.java	2009-09-28 15:55:02 UTC (rev 3544)
+++ jboss-logmanager/trunk/src/main/java/org/jboss/logmanager/LogContext.java	2009-09-29 15:27:36 UTC (rev 3545)
@@ -207,7 +207,7 @@
         for (;;) {
             final Map<String, LevelRef> oldLevelMap = levelMapReference.get();
             final LevelRef oldRef = oldLevelMap.get(level.getName());
-            if (oldRef != null || oldRef.get() != level) {
+            if (oldRef == null || oldRef.get() != level) {
                 // not registered, or the registration expired naturally
                 return;
             }



More information about the jboss-svn-commits mailing list