[jboss-svn-commits] JBL Code SVN: r32416 - labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/guvnor/client/modeldriven/dt.

[jboss-svn-commits at lists.jboss.org]

Author: baunax
Date: 2010-04-05 12:26:50 -0400 (Mon, 05 Apr 2010)
New Revision: 32416

Modified:
   labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/guvnor/client/modeldriven/dt/GuidedDecisionTable.java
Log:
added generics

Modified: labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/guvnor/client/modeldriven/dt/GuidedDecisionTable.java
===================================================================
--- labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/guvnor/client/modeldriven/dt/GuidedDecisionTable.java	2010-04-05 16:21:53 UTC (rev 32415)
+++ labs/jbossrules/trunk/drools-compiler/src/main/java/org/drools/guvnor/client/modeldriven/dt/GuidedDecisionTable.java	2010-04-05 16:26:50 UTC (rev 32416)
@@ -87,7 +87,7 @@
 	public String[] getValueList(DTColumnConfig col, SuggestionCompletionEngine sce) {
 		if (col instanceof AttributeCol) {
 			AttributeCol at = (AttributeCol) col;
-			if (at.attr.equals("no-loop") || at.attr.equals("enabled")) {
+			if ("no-loop".equals(at.attr) || "enabled".equals(at.attr)) {
 				return new String[] { "true", "false" };
 			}
 		} else if (col instanceof ConditionCol) {
@@ -127,8 +127,8 @@
 	}
 
 	private String getBoundFactType(String boundName) {
-		for (Iterator iterator = conditionCols.iterator(); iterator.hasNext();) {
-			ConditionCol c = (ConditionCol) iterator.next();
+		for (Iterator<ConditionCol> iterator = conditionCols.iterator(); iterator.hasNext();) {
+			ConditionCol c = iterator.next();
 			if (c.boundName.equals(boundName)) {
 				return c.factType;
 			}
@@ -139,11 +139,7 @@
 	public boolean isNumeric(DTColumnConfig col, SuggestionCompletionEngine sce) {
 		if (col instanceof AttributeCol) {
 			AttributeCol at = (AttributeCol) col;
-			if (at.attr.equals("salience")) {
-				return true;
-			} else {
-				return false;
-			}
+			return "salience".equals(at.attr);
 		} else if (col instanceof ConditionCol) {
 			ConditionCol c = (ConditionCol) col;
 			if (c.constraintValueType == ISingleFieldConstraint.TYPE_LITERAL) {