[jboss-svn-commits] JBL Code SVN: r31181 - labs/jbossrules/trunk/drools-guvnor/src/main/java/org/drools/guvnor/server/files.

[jboss-svn-commits at lists.jboss.org]

Author: Rikkola
Date: 2010-01-21 08:25:47 -0500 (Thu, 21 Jan 2010)
New Revision: 31181

Modified:
   labs/jbossrules/trunk/drools-guvnor/src/main/java/org/drools/guvnor/server/files/PackageDeploymentServlet.java
Log:
GUVNOR-471 : PackageDeploymentServlet doHead concurrency issue with SimpleDateFormat

Modified: labs/jbossrules/trunk/drools-guvnor/src/main/java/org/drools/guvnor/server/files/PackageDeploymentServlet.java
===================================================================
--- labs/jbossrules/trunk/drools-guvnor/src/main/java/org/drools/guvnor/server/files/PackageDeploymentServlet.java	2010-01-21 10:41:43 UTC (rev 31180)
+++ labs/jbossrules/trunk/drools-guvnor/src/main/java/org/drools/guvnor/server/files/PackageDeploymentServlet.java	2010-01-21 13:25:47 UTC (rev 31181)
@@ -47,9 +47,10 @@
 
     private static final long      serialVersionUID = 400L;
 
-    public static SimpleDateFormat RFC822DATEFORMAT = new SimpleDateFormat( "EEE', 'dd' 'MMM' 'yyyy' 'HH:mm:ss' 'Z",
-                                                                            Locale.US );
+    public static final String RFC822DATEFORMAT = "EEE', 'dd' 'MMM' 'yyyy' 'HH:mm:ss' 'Z";
+    public static final Locale HEADER_LOCALE = Locale.US;
 
+
     @Override
     protected long getLastModified(HttpServletRequest request) {
         PackageDeploymentURIHelper helper = null;
@@ -68,6 +69,7 @@
                           HttpServletResponse response) throws ServletException,
                                                        IOException {
         if ( request.getMethod().equals( "HEAD" ) ) {
+            SimpleDateFormat dateFormat = new SimpleDateFormat(RFC822DATEFORMAT, HEADER_LOCALE);
             PackageDeploymentURIHelper helper = new PackageDeploymentURIHelper( request.getRequestURI() );
             FileManagerUtils fm = getFileManager();
             long mod = fm.getLastModified( helper.getPackageName(),
@@ -75,7 +77,7 @@
             response.addHeader( "lastModified",
                                 "" + mod );
             response.addHeader( "Last-Modified",
-                                RFC822DATEFORMAT.format( new Date( mod ) ) );
+                                dateFormat.format( new Date( mod ) ) );
 
         } else {
             super.doHead( request,