[jboss-svn-commits] JBL Code SVN: r33926 - in labs/jbossrules/trunk/drools-process/drools-process-task/src/main/java/org/drools/task/service: hornetq and 1 other directory.
jboss-svn-commits at lists.jboss.org
jboss-svn-commits at lists.jboss.org
Thu Jul 15 18:50:28 EDT 2010
Author: lucazamador
Date: 2010-07-15 18:50:28 -0400 (Thu, 15 Jul 2010)
New Revision: 33926
Modified:
labs/jbossrules/trunk/drools-process/drools-process-task/src/main/java/org/drools/task/service/EventTransport.java
labs/jbossrules/trunk/drools-process/drools-process-task/src/main/java/org/drools/task/service/SessionWriter.java
labs/jbossrules/trunk/drools-process/drools-process-task/src/main/java/org/drools/task/service/hornetq/BaseHornetQTaskServer.java
labs/jbossrules/trunk/drools-process/drools-process-task/src/main/java/org/drools/task/service/hornetq/HornetQSessionWriter.java
labs/jbossrules/trunk/drools-process/drools-process-task/src/main/java/org/drools/task/service/hornetq/HornetQTaskClientConnector.java
Log:
process-task hornetq implementation: cleaning code
Modified: labs/jbossrules/trunk/drools-process/drools-process-task/src/main/java/org/drools/task/service/EventTransport.java
===================================================================
--- labs/jbossrules/trunk/drools-process/drools-process-task/src/main/java/org/drools/task/service/EventTransport.java 2010-07-15 20:48:13 UTC (rev 33925)
+++ labs/jbossrules/trunk/drools-process/drools-process-task/src/main/java/org/drools/task/service/EventTransport.java 2010-07-15 22:50:28 UTC (rev 33926)
@@ -1,5 +1,6 @@
package org.drools.task.service;
+import java.io.IOException;
import java.util.ArrayList;
import java.util.List;
import java.util.Map;
@@ -26,7 +27,11 @@
List<Object> args = new ArrayList<Object>( 1 );
args.add(payload);
Command cmd = new Command(responseId, CommandName.EventTriggerResponse, args);
- session.write(cmd);
+ try {
+ session.write(cmd);
+ } catch (IOException e) {
+ throw new RuntimeException(e);
+ }
}
public boolean isRemove() {
Modified: labs/jbossrules/trunk/drools-process/drools-process-task/src/main/java/org/drools/task/service/SessionWriter.java
===================================================================
--- labs/jbossrules/trunk/drools-process/drools-process-task/src/main/java/org/drools/task/service/SessionWriter.java 2010-07-15 20:48:13 UTC (rev 33925)
+++ labs/jbossrules/trunk/drools-process/drools-process-task/src/main/java/org/drools/task/service/SessionWriter.java 2010-07-15 22:50:28 UTC (rev 33926)
@@ -1,7 +1,9 @@
package org.drools.task.service;
+import java.io.IOException;
+
public interface SessionWriter {
- public void write(Object message);
+ public void write(Object message) throws IOException;
}
Modified: labs/jbossrules/trunk/drools-process/drools-process-task/src/main/java/org/drools/task/service/hornetq/BaseHornetQTaskServer.java
===================================================================
--- labs/jbossrules/trunk/drools-process/drools-process-task/src/main/java/org/drools/task/service/hornetq/BaseHornetQTaskServer.java 2010-07-15 20:48:13 UTC (rev 33925)
+++ labs/jbossrules/trunk/drools-process/drools-process-task/src/main/java/org/drools/task/service/hornetq/BaseHornetQTaskServer.java 2010-07-15 22:50:28 UTC (rev 33926)
@@ -75,9 +75,6 @@
break;
default:
logger.error(e.getMessage());
- if (logger.isDebugEnabled()) {
- e.printStackTrace();
- }
break;
}
}
@@ -86,13 +83,19 @@
}
}
- private Object readMessage(ClientMessage msgReceived) throws IOException, ClassNotFoundException {
+ private Object readMessage(ClientMessage msgReceived) throws IOException {
int bodySize = msgReceived.getBodySize();
byte[] message = new byte[bodySize];
msgReceived.getBodyBuffer().readBytes(message);
ByteArrayInputStream bais = new ByteArrayInputStream(message);
- ObjectInputStream ois = new ObjectInputStream(bais);
- return ois.readObject();
+ try {
+ ObjectInputStream ois = new ObjectInputStream(bais);
+ return ois.readObject();
+ } catch (IOException e) {
+ throw new IOException("Error reading message");
+ } catch (ClassNotFoundException e) {
+ throw new IOException("Error creating message");
+ }
}
public void start() throws Exception {
Modified: labs/jbossrules/trunk/drools-process/drools-process-task/src/main/java/org/drools/task/service/hornetq/HornetQSessionWriter.java
===================================================================
--- labs/jbossrules/trunk/drools-process/drools-process-task/src/main/java/org/drools/task/service/hornetq/HornetQSessionWriter.java 2010-07-15 20:48:13 UTC (rev 33925)
+++ labs/jbossrules/trunk/drools-process/drools-process-task/src/main/java/org/drools/task/service/hornetq/HornetQSessionWriter.java 2010-07-15 22:50:28 UTC (rev 33926)
@@ -20,7 +20,7 @@
this.producer = producer;
}
- public void write(Object message) {
+ public void write(Object message) throws IOException {
ByteArrayOutputStream baos = new ByteArrayOutputStream();
ObjectOutputStream oout;
try {
@@ -30,9 +30,9 @@
clientMessage.getBodyBuffer().writeBytes(baos.toByteArray());
producer.send(clientMessage);
} catch (IOException e) {
- e.printStackTrace();
+ throw new IOException("Error creating message");
} catch (HornetQException e) {
- e.printStackTrace();
+ throw new IOException("Unable to create message");
}
}
Modified: labs/jbossrules/trunk/drools-process/drools-process-task/src/main/java/org/drools/task/service/hornetq/HornetQTaskClientConnector.java
===================================================================
--- labs/jbossrules/trunk/drools-process/drools-process-task/src/main/java/org/drools/task/service/hornetq/HornetQTaskClientConnector.java 2010-07-15 20:48:13 UTC (rev 33925)
+++ labs/jbossrules/trunk/drools-process/drools-process-task/src/main/java/org/drools/task/service/hornetq/HornetQTaskClientConnector.java 2010-07-15 22:50:28 UTC (rev 33926)
@@ -96,8 +96,6 @@
logger.info(e.getMessage());
}
catch (Exception e) {
- // TODO: remove this printStackTrace()
- e.printStackTrace();
throw new RuntimeException("Client Exception with class " + getClass() + " using port " + port, e);
}
}
@@ -106,7 +104,7 @@
session.start();
return true;
} catch (Exception e) {
- e.printStackTrace();
+ logger.error(e.getMessage());
return false;
}
}
@@ -153,9 +151,9 @@
message.putStringProperty("producerId", name);
producer.send(message);
} catch (IOException e) {
- e.printStackTrace();
+ throw new RuntimeException("Error creating message", e);
} catch (HornetQException e) {
- e.printStackTrace();
+ throw new RuntimeException("Error writing message", e);
}
}
More information about the jboss-svn-commits
mailing list