[jboss-svn-commits] JBL Code SVN: r33283 - in labs/jbosslabs/labs-3.0-build/integration/sbs-nukesauthentication/trunk/src: test/java/org/jboss/labs/sbs/plugin/nukesauth and 1 other directory.

[jboss-svn-commits at lists.jboss.org]

Author: lkrzyzanek
Date: 2010-06-01 08:58:13 -0400 (Tue, 01 Jun 2010)
New Revision: 33283

Modified:
   labs/jbosslabs/labs-3.0-build/integration/sbs-nukesauthentication/trunk/src/main/java/org/jboss/labs/sbs/plugin/nukesauth/SbsAccountManagerImpl.java
   labs/jbosslabs/labs-3.0-build/integration/sbs-nukesauthentication/trunk/src/test/java/org/jboss/labs/sbs/plugin/nukesauth/SbsAccountManagerImplTest.java
Log:
ORG-606 - fixed small bug in listToString method

Modified: labs/jbosslabs/labs-3.0-build/integration/sbs-nukesauthentication/trunk/src/main/java/org/jboss/labs/sbs/plugin/nukesauth/SbsAccountManagerImpl.java
===================================================================
--- labs/jbosslabs/labs-3.0-build/integration/sbs-nukesauthentication/trunk/src/main/java/org/jboss/labs/sbs/plugin/nukesauth/SbsAccountManagerImpl.java	2010-06-01 12:39:19 UTC (rev 33282)
+++ labs/jbosslabs/labs-3.0-build/integration/sbs-nukesauthentication/trunk/src/main/java/org/jboss/labs/sbs/plugin/nukesauth/SbsAccountManagerImpl.java	2010-06-01 12:58:13 UTC (rev 33283)
@@ -23,7 +23,6 @@
 
 import java.util.Collection;
 import java.util.HashSet;
-import java.util.Iterator;
 import java.util.LinkedList;
 import java.util.List;
 import java.util.Map;
@@ -188,13 +187,14 @@
   protected String listToString(String masterUsername, List<NukesUser> list) {
     StringBuffer sb = new StringBuffer();
 
-    for (Iterator<NukesUser> iterator = list.iterator(); iterator.hasNext();) {
-      NukesUser nukesUser = iterator.next();
+    int i = 0;
+    for (NukesUser nukesUser : list) {
       if (!masterUsername.equals(nukesUser.getUsername())) {
-        sb.append(nukesUser.getUsername());
-        if (iterator.hasNext()) {
+        if (i != 0) {
           sb.append(duplicateAccountsDeliminer);
         }
+        sb.append(nukesUser.getUsername());
+        i++;
       }
     }
 

Modified: labs/jbosslabs/labs-3.0-build/integration/sbs-nukesauthentication/trunk/src/test/java/org/jboss/labs/sbs/plugin/nukesauth/SbsAccountManagerImplTest.java
===================================================================
--- labs/jbosslabs/labs-3.0-build/integration/sbs-nukesauthentication/trunk/src/test/java/org/jboss/labs/sbs/plugin/nukesauth/SbsAccountManagerImplTest.java	2010-06-01 12:39:19 UTC (rev 33282)
+++ labs/jbosslabs/labs-3.0-build/integration/sbs-nukesauthentication/trunk/src/test/java/org/jboss/labs/sbs/plugin/nukesauth/SbsAccountManagerImplTest.java	2010-06-01 12:58:13 UTC (rev 33283)
@@ -51,6 +51,8 @@
     nukes.add(new NukesUser("account4"));
 
     assertEquals("account2::account3::account4", sbsAccountManager.listToString("account1", nukes));
+    assertEquals("account1::account3::account4", sbsAccountManager.listToString("account2", nukes));
+    assertEquals("account1::account2::account3", sbsAccountManager.listToString("account4", nukes));
   }
 
 }