[jboss-svn-commits] JBL Code SVN: r33336 - in labs/jbossrules/branches/salaboy_drools_grid_api_separation/drools-guvnor/src/main/java/org/drools/guvnor/client/explorer/grid: panels and 1 other directory.

jboss-svn-commits at lists.jboss.org jboss-svn-commits at lists.jboss.org
Thu Jun 3 17:58:33 EDT 2010


Author: diegoll
Date: 2010-06-03 17:58:32 -0400 (Thu, 03 Jun 2010)
New Revision: 33336

Added:
   labs/jbossrules/branches/salaboy_drools_grid_api_separation/drools-guvnor/src/main/java/org/drools/guvnor/client/explorer/grid/panels/NewGridTopologyPanel.java
Modified:
   labs/jbossrules/branches/salaboy_drools_grid_api_separation/drools-guvnor/src/main/java/org/drools/guvnor/client/explorer/grid/BrowseGridTopologiesTreeBuilder.java
Log:
cleaning up panel creation

Modified: labs/jbossrules/branches/salaboy_drools_grid_api_separation/drools-guvnor/src/main/java/org/drools/guvnor/client/explorer/grid/BrowseGridTopologiesTreeBuilder.java
===================================================================
--- labs/jbossrules/branches/salaboy_drools_grid_api_separation/drools-guvnor/src/main/java/org/drools/guvnor/client/explorer/grid/BrowseGridTopologiesTreeBuilder.java	2010-06-03 16:09:01 UTC (rev 33335)
+++ labs/jbossrules/branches/salaboy_drools_grid_api_separation/drools-guvnor/src/main/java/org/drools/guvnor/client/explorer/grid/BrowseGridTopologiesTreeBuilder.java	2010-06-03 21:58:32 UTC (rev 33336)
@@ -3,19 +3,10 @@
 import java.util.Collections;
 import java.util.List;
 
-import org.drools.guvnor.client.common.GenericCallback;
 import org.drools.guvnor.client.explorer.ExplorerViewCenterPanel;
 import org.drools.guvnor.client.explorer.grid.model.GridTopologyView;
-import org.drools.guvnor.client.explorer.grid.services.TopologyAssetsService;
-import org.drools.guvnor.client.explorer.grid.services.TopologyAssetsServiceAsync;
+import org.drools.guvnor.client.explorer.grid.panels.NewGridTopologyPanel;
 
-import com.google.gwt.core.client.GWT;
-import com.google.gwt.event.dom.client.ClickEvent;
-import com.google.gwt.event.dom.client.ClickHandler;
-import com.google.gwt.user.client.ui.Button;
-import com.google.gwt.user.client.ui.Panel;
-import com.google.gwt.user.client.ui.TextBox;
-import com.google.gwt.user.client.ui.VerticalPanel;
 import com.gwtext.client.core.EventObject;
 import com.gwtext.client.data.Node;
 import com.gwtext.client.widgets.tree.TreeNode;
@@ -24,7 +15,6 @@
 public class BrowseGridTopologiesTreeBuilder {
 
 	private static final String TOPOLOGIES_TAB_KEY = "topologies";
-	private TopologyAssetsServiceAsync assetService;
 	private BrowseGridResourcesTreeBuilder gridResourcesTreeBuilder;
 	
 	public Node build(final ExplorerViewCenterPanel targetPanel){
@@ -42,34 +32,17 @@
         return topologiesItem;
     }
 
-    private void openCreateNewGridTopologyPanel(final ExplorerViewCenterPanel targetPanel, TreeNode topologiesItem) {
+    private void openCreateNewGridTopologyPanel(final ExplorerViewCenterPanel targetPanel, final TreeNode topologiesItem) {
 		if (!targetPanel.showIfOpen(TOPOLOGIES_TAB_KEY)) {
-			buildCreateNewGridTopologyPanel(targetPanel, topologiesItem);
+	        targetPanel.addTab("New execution environment", true, new NewGridTopologyPanel() {
+				@Override
+				public void onGridTopologyCreation(GridTopologyView newTopology) {
+					addTopologyNode(targetPanel, topologiesItem, newTopology);
+				}
+			}, TOPOLOGIES_TAB_KEY);
         }
 	}
 
-	private void buildCreateNewGridTopologyPanel(final ExplorerViewCenterPanel targetPanel, final TreeNode topologiesItem) {
-		Panel panel = new VerticalPanel();
-		final TextBox topologyName = new TextBox();
-		
-		Button addTopologyAction = new Button("Create");
-		addTopologyAction.addClickHandler(new ClickHandler() {
-			public void onClick(ClickEvent event) {
-				getService().createNewTopology(topologyName.getText(),
-						new GenericCallback<GridTopologyView>() {
-							public void onSuccess(GridTopologyView newTopology) {
-								addTopologyNode(targetPanel, topologiesItem, newTopology);
-							}
-						});
-			}
-		});
-		
-		panel.add(topologyName);
-		panel.add(addTopologyAction);
-		
-        targetPanel.addTab("New execution environment", true, panel, TOPOLOGIES_TAB_KEY);
-	}
-
 	private void addTopologyNode(ExplorerViewCenterPanel targetPanel, TreeNode topologiesItem, final GridTopologyView newTopology) {
 		topologiesItem.appendChild(getGridResourcesTreeBuilder().build(targetPanel, newTopology));
 	}
@@ -78,12 +51,6 @@
 		return Collections.emptyList();
 	}
 
-	private TopologyAssetsServiceAsync getService() {
-		if(assetService == null)
-			assetService =  GWT.create(TopologyAssetsService.class);
-		return assetService;
-	}
-
     public BrowseGridResourcesTreeBuilder getGridResourcesTreeBuilder() {
     	if(gridResourcesTreeBuilder == null)
     		gridResourcesTreeBuilder = new BrowseGridResourcesTreeBuilder();

Added: labs/jbossrules/branches/salaboy_drools_grid_api_separation/drools-guvnor/src/main/java/org/drools/guvnor/client/explorer/grid/panels/NewGridTopologyPanel.java
===================================================================
--- labs/jbossrules/branches/salaboy_drools_grid_api_separation/drools-guvnor/src/main/java/org/drools/guvnor/client/explorer/grid/panels/NewGridTopologyPanel.java	                        (rev 0)
+++ labs/jbossrules/branches/salaboy_drools_grid_api_separation/drools-guvnor/src/main/java/org/drools/guvnor/client/explorer/grid/panels/NewGridTopologyPanel.java	2010-06-03 21:58:32 UTC (rev 33336)
@@ -0,0 +1,50 @@
+package org.drools.guvnor.client.explorer.grid.panels;
+
+import org.drools.guvnor.client.common.GenericCallback;
+import org.drools.guvnor.client.explorer.grid.model.GridTopologyView;
+import org.drools.guvnor.client.explorer.grid.services.TopologyAssetsService;
+import org.drools.guvnor.client.explorer.grid.services.TopologyAssetsServiceAsync;
+
+import com.google.gwt.core.client.GWT;
+import com.google.gwt.event.dom.client.ClickEvent;
+import com.google.gwt.event.dom.client.ClickHandler;
+import com.google.gwt.user.client.ui.Button;
+import com.google.gwt.user.client.ui.Composite;
+import com.google.gwt.user.client.ui.Panel;
+import com.google.gwt.user.client.ui.TextBox;
+import com.google.gwt.user.client.ui.VerticalPanel;
+
+public abstract class NewGridTopologyPanel extends Composite {
+
+	private TopologyAssetsServiceAsync assetService;
+
+	public NewGridTopologyPanel() {
+		Panel panel = new VerticalPanel();
+		final TextBox topologyName = new TextBox();
+		
+		Button addTopologyAction = new Button("Create");
+		addTopologyAction.addClickHandler(new ClickHandler() {
+			public void onClick(ClickEvent event) {
+				getService().createNewTopology(topologyName.getText(),
+						new GenericCallback<GridTopologyView>() {
+							public void onSuccess(GridTopologyView newTopology) {
+								onGridTopologyCreation(newTopology);
+							}
+						});
+			}
+		});
+		
+		panel.add(topologyName);
+		panel.add(addTopologyAction);
+		initWidget(panel);
+	}
+	
+	public abstract void onGridTopologyCreation(GridTopologyView newTopology);
+	
+	private TopologyAssetsServiceAsync getService() {
+		if(assetService == null)
+			assetService =  GWT.create(TopologyAssetsService.class);
+		return assetService;
+	}
+
+}



More information about the jboss-svn-commits mailing list