[jboss-svn-commits] JBL Code SVN: r32248 - labs/jbossrules/trunk/drools-guvnor/src/main/java/org/drools/guvnor/client/ruleeditor.

[jboss-svn-commits at lists.jboss.org]

Author: baunax
Date: 2010-03-26 14:08:06 -0400 (Fri, 26 Mar 2010)
New Revision: 32248

Modified:
   labs/jbossrules/trunk/drools-guvnor/src/main/java/org/drools/guvnor/client/ruleeditor/WorkingSetEditor.java
Log:
fixed a bunch of NPEs and ArrayIndexOutOfBound while synchronizing listboxes

Modified: labs/jbossrules/trunk/drools-guvnor/src/main/java/org/drools/guvnor/client/ruleeditor/WorkingSetEditor.java
===================================================================
--- labs/jbossrules/trunk/drools-guvnor/src/main/java/org/drools/guvnor/client/ruleeditor/WorkingSetEditor.java	2010-03-26 17:43:17 UTC (rev 32247)
+++ labs/jbossrules/trunk/drools-guvnor/src/main/java/org/drools/guvnor/client/ruleeditor/WorkingSetEditor.java	2010-03-26 18:08:06 UTC (rev 32248)
@@ -124,7 +124,7 @@
 
         addNewConstraint.addClickListener( new ClickListener() {
             public void onClick(Widget w) {
-                showNewConstrainPop(factsCombo, fieldsCombo, constraintsCombo);
+                showNewConstrainPop();
             }
         });
 		
@@ -151,7 +151,7 @@
 		
 		constraintsCombo.addChangeListener(new ChangeListener() {
 			public void onChange(Widget sender) {
-				showConstraintConfig(constraintsCombo, vpConstraintConf);
+				showConstraintConfig();
 			}
 		});
 		
@@ -163,11 +163,11 @@
 		fillSelectedFacts();
 		fillSelectedFactFields();
 		fillFieldConstrains();
-		showConstraintConfig(constraintsCombo, vpConstraintConf);
+		showConstraintConfig();
 		return table;
 	}
 
-	private void showConstraintConfig(ListBox constraintsCombo, VerticalPanel vpConstraintConf) {
+	private void showConstraintConfig() {
 		if (constraintsCombo.getItemCount() == 0) {
 			vpConstraintConf.remove(vpConstraintConf.getWidgetCount() - 1);
 			vpConstraintConf.add(new Label());
@@ -181,7 +181,7 @@
 		}
 	}
 
-	private void showNewConstrainPop(final ListBox factsCombo, final ListBox fieldsCombo, final ListBox constraintsCombo) {
+	private void showNewConstrainPop() {
         final FormStylePopup pop = new FormStylePopup("images/config.png", constants.AddNewConstrain()); //NON-NLS
         final Button addbutton = new Button(constants.OK());
         final ListBox consDefsCombo = new ListBox(false);
@@ -276,6 +276,7 @@
 			vpConstraintConf.remove(vpConstraintConf.getWidgetCount() - 1);
 			vpConstraintConf.add(new Label());
 		}
+		showConstraintConfig();
 	}
 	
 	private String addContrainsMap(Constraint c) {