[jboss-svn-commits] JBoss Common SVN: r4374 - shrinkwrap/trunk/impl-base/src/main/java/org/jboss/shrinkwrap/impl/base/exporter.

jboss-svn-commits at lists.jboss.org jboss-svn-commits at lists.jboss.org
Sat May 8 19:05:45 EDT 2010


Author: ALRubinger
Date: 2010-05-08 19:05:44 -0400 (Sat, 08 May 2010)
New Revision: 4374

Modified:
   shrinkwrap/trunk/impl-base/src/main/java/org/jboss/shrinkwrap/impl/base/exporter/JdkZipExporterDelegate.java
Log:
[SHRINKWRAP-133] Remove the TODO, things are working just fine.  We cannot make up for the JDK lack of support for closing empty ZIPs.

Modified: shrinkwrap/trunk/impl-base/src/main/java/org/jboss/shrinkwrap/impl/base/exporter/JdkZipExporterDelegate.java
===================================================================
--- shrinkwrap/trunk/impl-base/src/main/java/org/jboss/shrinkwrap/impl/base/exporter/JdkZipExporterDelegate.java	2010-05-08 18:43:29 UTC (rev 4373)
+++ shrinkwrap/trunk/impl-base/src/main/java/org/jboss/shrinkwrap/impl/base/exporter/JdkZipExporterDelegate.java	2010-05-08 23:05:44 UTC (rev 4374)
@@ -141,7 +141,6 @@
                log.log(Level.WARNING, "Exception encountered during export of archive", e);
 
                // SHRINKWRAP-133 - if the Zip is empty, it won't close and a deadlock is triggered
-               //TODO Find a better solution :)
                if (pathsExported.isEmpty())
                {
                   // Ensure the streams are set up before we do any work on them;



More information about the jboss-svn-commits mailing list