[jbosscache-commits] JBoss Cache SVN: r4626 - core/trunk/src/main/java/org/jboss/cache/interceptors.

jbosscache-commits at lists.jboss.org jbosscache-commits at lists.jboss.org
Tue Oct 16 12:27:34 EDT 2007


Author: manik.surtani at jboss.com
Date: 2007-10-16 12:27:34 -0400 (Tue, 16 Oct 2007)
New Revision: 4626

Modified:
   core/trunk/src/main/java/org/jboss/cache/interceptors/OptimisticCreateIfNotExistsInterceptor.java
Log:
Unnecessary sync?

Modified: core/trunk/src/main/java/org/jboss/cache/interceptors/OptimisticCreateIfNotExistsInterceptor.java
===================================================================
--- core/trunk/src/main/java/org/jboss/cache/interceptors/OptimisticCreateIfNotExistsInterceptor.java	2007-10-16 14:30:18 UTC (rev 4625)
+++ core/trunk/src/main/java/org/jboss/cache/interceptors/OptimisticCreateIfNotExistsInterceptor.java	2007-10-16 16:27:34 UTC (rev 4626)
@@ -110,9 +110,12 @@
       List<Fqn> nodesCreated = new ArrayList<Fqn>();
 
       // synchronize on the workspace so that more than one thread doesn't attempt to put stuff into the workspace for
-      // the same transaction.
+      // the same transaction.  Isn't this unlikely though, given that each transaction would only occur in a single thread
+      // at a time?
+/*
       synchronized (workspace)
       {
+*/
          DataVersion version = null;
          if (ctx.getOptionOverrides() != null && ctx.getOptionOverrides().getDataVersion() != null)
          {
@@ -223,7 +226,7 @@
             }
          }
 
-      }// end sync block
+      //}// end sync block
 
       if (!suppressNotification)
       {




More information about the jbosscache-commits mailing list