[jbosscache-dev] RE: Pojo-style config

[Brian Stansberry]

Agreed.  I wrote them as public static class Config, and forgot that for
the MC we'd have to use the '$' instead of the '.' that's usable in java
code.  I did the -beans.xml files last night and didn't have the energy
to deal with it.
 
The 2 files thing does suck though.

________________________________

	From: Manik Surtani [mailto:manik at jboss.org] 
	Sent: Monday, October 23, 2006 5:17 AM
	To: Brian Stansberry
	Cc: jbosscache-dev at lists.jboss.org
	Subject: Re: Pojo-style config
	
	
	Looks great! 

	One Q though - about the specific config impls for CacheLoaders,
etc., do we really want them as inner classes, e.g.,
org.jboss.cache.loader.FileCacheLoader$Config?  From a Java standpoint,
this makes the most sense and is cleanest, can't say I like the String
representation of the inner class in XML though.  :-)  Just me being a
pedant, but isn't org.jboss.cache.loader.FileCacheLoaderConfig better,
sure this means 2 .java files per cache loader, but still?

	Cheers,
	
	
	--
	Manik Surtani

	Lead, JBoss Cache
	JBoss, a division of Red Hat

	Email: manik at jboss.org
	Telephone: +44 7786 702 706
	MSN: manik at surtani.org
	Yahoo/AIM/Skype: maniksurtani


	On 23 Oct 2006, at 07:05, Brian Stansberry wrote:


		FYI on where this sits:

		1) I checked in all the stuff we were discussing last
week.
		2) When I ran the testsuite, I didn't see regressions.
We'll see what
		cc shows.  The existing testsuite actually excercises
the new code
		fairly well, because even when the old style Element and
Properties
		configs are used, everything gets converted behind the
scenes to the new
		pojos.
		3) I created a stripped down AS head and created
-beans.xml files for
		the 4 JBC configs that will go in AS 5 -- tomcat, ejb3
sfsb, ejb3
		entity, and the HAPartition cache.  They all deploy
cleanly, so that's a
		simple test of the MC-style config.  Don't know if they
do what they
		should (e.g. does eviction actually happen), but I'm
pretty confident
		about that.  The -beans.xml files are attached so you
can see what they
		look like.

		There are details about that can be improved or at least
need
		discussing, but I think it's pretty reasonable for an
alpha.

		Cheers,

		Brian Stansberry
		Lead, AS Clustering
		JBoss, a division of Red Hat
		Ph: 510-396-3864
		skype: bstansberry  
		<tc6-cluster-beans.xml>
		
		<cluster-beans.xml>
		
		<ejb3-clustered-sfsbcache-beans.xml>
		
		<ejb3-entity-cache-beans.xml>


-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.jboss.org/pipermail/jbosscache-dev/attachments/20061023/a387e510/attachment.html