[jbosscache-dev] Mircea's RedcdRecJDBCCacheLoader

[Galder Zamarreno]

I guess you still wanna be using CacheLoader endings for new classes 
correct? i.e AdjListJDBCClassLoader

Apart from that, excellent work :)

Mircea Markus wrote:
> Hi,
> 
> I've added the new JDBCCacheLoader impl on CVS. Old version is also 
> present in the repository - JDBCCacheLoadeOld - deprecated class. I 
> think it would be useful to keep it there for a while due to the following:
> - there is a CompatibilityTest test to ensure that the new one (class 
> name JDBCCacheLoader) works fine on data created by the old one. Also 
> any other further compatibility issues should be investigated here
> - there is a benchmark code I've added which evaluates/compares 
> performance. I think is might prove useful for further implementations 
> or even in another benchmark
> 
> There was an issue with the old impl: root was not persisted. The new 
> one works fine on this.
> 
> Class I've added/modified:
> JDBCCacheLoader
> AdjListJDBCClassLoader
> JDBCCacheLoaderOld
> AdjListJDBCClassLoaderCompatibilityTest
> JDBCCacheLoader test
> AdjListJDBCClassLoaderConfig
> JDBCClassLoaderConfig
> tests\perf\org\jboss\cache\manualtests\cacheloader - the classes that 
> perform the benchmarking/performance comparisons
> 
> Any feedback would be great!
> 
> Cheers,
> Mircea
> 
> On 2/8/07, *Mircea Markus* <mircea.markus at gmail.com 
> <mailto:mircea.markus at gmail.com>> wrote:
> 
>     Hi,
> 
>     Second thought on this.
>     My SoUglyNamedJDBCCacheLoader :) needs an additional configuration
>     element - DBMS string concatenation function syntax. Normally
>     concat(1,2) should make it for most of DBMs (works on mysql, oracle,
>     mssql), but the fact is that this additional required config does
>     not make the new impl 100% backward(you can not take the new class
>     and put it in the place of old class). So I suggest following:
>     - keep the JDBCChacheLoader as it is
>     - also add the new impl (with a more expressive name, of course :)(
>     perhaps deprecate the old one?)
>     - recommend the user to use the new class over the old one,
>     highlighting performance improvements
> 
>     Cheers,
>     Mircea
> 
> 
> 
>     On 2/8/07, *Manik Surtani* < manik at jboss.org
>     <mailto:manik at jboss.org>> wrote:
> 
>         Guys,
> 
>         I'm pretty keen on including Mircea's RedcdRecJDBCCacheLoader in
>         2.0.0:
> 
>         1)  Performance improvement based on removal of recursive DB calls
>         (uses linear calls instead - see Mircea's previous posts)
>         2)  Backward compatible with the existing JDBC cache loader
>         3)  No specific use case why the old JDBCCacheLoader should be used
>         instead of this.
> 
>         So my question to you is this:
> 
>         Do we drop the existing JDBCCacheLoader and rename the
>         RedcdRecJDBCCacheLoader (hate that name!) to JDBCCacheLoader?
> 
>         Comments?
>         --
>         Manik Surtani
> 
>         Lead, JBoss Cache
>         JBoss, a division of Red Hat
> 
>         Email: manik at jboss.org <mailto:manik at jboss.org>
>         Telephone: +44 7786 702 706
>         MSN: manik at surtani.org <mailto:manik at surtani.org>
>         Yahoo/AIM/Skype: maniksurtani
> 
> 
> 
>         _______________________________________________
>         jbosscache-dev mailing list
>         jbosscache-dev at lists.jboss.org
>         <mailto:jbosscache-dev at lists.jboss.org>
>         https://lists.jboss.org/mailman/listinfo/jbosscache-dev
> 
> 
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> jbosscache-dev mailing list
> jbosscache-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/jbosscache-dev

-- 
Galder Zamarreño
Sr. Software Maintenance Engineer
JBoss, a division of Red Hat