[jbosscache-issues] [JBoss JIRA] Commented: (JBCACHE-1526) GlobalTransaction lost upon buddy fqn transformation of RollbackCommand

[Brian Stansberry (JIRA)]

    [ https://jira.jboss.org/jira/browse/JBCACHE-1526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12478715#action_12478715 ] 

Brian Stansberry commented on JBCACHE-1526:
-------------------------------------------

I noticed OptimisticReplicationInterceptor.broadcastRollback also passes null as the GTX to the RollbackCommand it creates. I don't know if that's for sure a bug, but it looks like one.

> GlobalTransaction lost upon buddy fqn transformation of RollbackCommand
> -----------------------------------------------------------------------
>
>                 Key: JBCACHE-1526
>                 URL: https://jira.jboss.org/jira/browse/JBCACHE-1526
>             Project: JBoss Cache
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>          Components: Buddy Replication
>    Affects Versions: 3.1.0.GA
>            Reporter: Paul Ferraro
>            Assignee: Manik Surtani
>         Attachments: Buddy3NodesFailedRemotePrepare.java
>
>
> During EAP5 web session buddy replication testing, the following trace logs caught my attention:
> [JBoss] 19:54:53,957 TRACE [org.jboss.cache.buddyreplication.BuddyManager] (ajp-jawa01%2F10.34.32.153-8009-979) Transformed RollbackCommand{gtx=GlobalTransaction:<10.34.32.153:54191>:1331} to RollbackCommand{gtx=null}
> [JBoss] 19:54:54,073 TRACE [org.jboss.cache.buddyreplication.BuddyManager] (ajp-jawa01%2F10.34.32.153-8009-981) Transformed RollbackCommand{gtx=GlobalTransaction:<10.34.32.153:54191>:1333} to RollbackCommand{gtx=null}
> [JBoss] 19:54:54,073 TRACE [org.jboss.cache.buddyreplication.BuddyManager] (ajp-jawa01%2F10.34.32.153-8009-981) Transformed RollbackCommand{gtx=GlobalTransaction:<10.34.32.153:54191>:1333} to RollbackCommand{gtx=null}
> This seems due to the following method in Fqn2BuddyFqnVisitor:
>    public Object visitRollbackCommand(InvocationContext ctx, RollbackCommand command) throws Throwable
>    {
>       return factory.buildRollbackCommand(null);
>    }
> Shouldn't we be propagating the GlobalTransaction as done in visitCommitCommand(...) and visitPrepareCommand(...)?

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira