[jbosscache-issues] [JBoss JIRA] Commented: (JBCACHE-1528) Data gravitation prefers exception response over valid gravitation

[Brian Stansberry (JIRA)]

    [ https://jira.jboss.org/jira/browse/JBCACHE-1528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12479151#action_12479151 ] 

Brian Stansberry commented on JBCACHE-1528:
-------------------------------------------

One tangential thing I noticed is this in CacheInvocationDelegate:

   protected void cacheStatusCheck(InvocationContext ctx)
   {
      assertIsConstructed();
      if (!ctx.getOptionOverrides().isSkipCacheStatusCheck() && !componentRegistry.invocationsAllowed(true))
      {
         throw new IllegalStateException("Cache not in STARTED state!");
      }
   }

"true" is always passed to componentRegistry.invocationsAllowed, whether or not the call is locally originated.

Doesn't matter to the above exception, since passing "false" would only be helpful during cache startup and the above occurred during shutdown.

> Data gravitation prefers exception response over valid gravitation
> ------------------------------------------------------------------
>
>                 Key: JBCACHE-1528
>                 URL: https://jira.jboss.org/jira/browse/JBCACHE-1528
>             Project: JBoss Cache
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>          Components: Buddy Replication
>    Affects Versions: 3.1.0.GA
>            Reporter: Brian Stansberry
>            Assignee: Manik Surtani
>
> A web request that performed a data gravitation for the session failed because one node returned an ISE while another returned the data. The ISE should have been ignored and the returned data used.
> The first log message below shows what was returned from the gravitation RPC; the second indicates that the ISE propagated.
> [JBoss] 16:48:56,696 TRACE [org.jboss.cache.marshall.CommandAwareRpcDispatcher] (ajp-jawa04%2F10.34.32.156-8009-7) responses: [sender=10.34.32.154:59373, retval=GravitateResult dataFound=false nodeData=null fqn=null, received=true, suspected=false]
> [JBoss] [sender=10.34.32.153:40508, retval=GravitateResult dataFound=true nodeData=[NodeData {fqn: /JSESSION/st_localhost/BrvolmfTMDqZAzEL1quXCA__, attrs={0=192, 1=1249483734634, 2=org.jboss.web.tomcat.service.session.distributedcache.spi.DistributableSessionMetadata at 500942cd, 3=org.jboss.ha.framework.server.SimpleCachableMarshalledValue{raw=nullserialized=true}}}] fqn=/_BUDDY_BACKUP_/10.34.32.155_47742/JSESSION/st_localhost/BrvolmfTMDqZAzEL1quXCA__, received=true, suspected=false]
> [JBoss] [sender=10.34.32.155:47742, retval=java.lang.IllegalStateException: Cache not in STARTED state!, received=true, suspected=false]
> [JBoss] 
> [JBoss] 16:48:56,698 ERROR [org.apache.catalina.connector.CoyoteAdapter] (ajp-jawa04%2F10.34.32.156-8009-7) An exception or error occurred in the container during the request processing
> [JBoss] java.lang.IllegalStateException: Cache not in STARTED state!
> [JBoss] 	at org.jboss.cache.invocation.CacheInvocationDelegate.cacheStatusCheck(CacheInvocationDelegate.java:695)
> [JBoss] 	at org.jboss.cache.invocation.CacheInvocationDelegate.getChildrenNamesInternal(CacheInvocationDelegate.java:652)
> [JBoss] 	at org.jboss.cache.invocation.CacheInvocationDelegate.getChildrenNames(CacheInvocationDelegate.java:639)
> [JBoss] 	at org.jboss.cache.commands.read.GravitateDataCommand.perform(GravitateDataCommand.java:130)
> ....
> The stack trace below is what was returned from the remote node; it's not the caller-side stack.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira