[jbosscache-issues] [JBoss JIRA] Commented: (JBCACHE-1527) LockParentForChildInsertRemove ignored with PessimisticLocking

[Manik Surtani (JIRA)]

    [ https://jira.jboss.org/jira/browse/JBCACHE-1527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12479209#action_12479209 ] 

Manik Surtani commented on JBCACHE-1527:
----------------------------------------

Patch looks great.  Agree about the need for the 'created' flag to be reset if a repeek fails.

I've rolled in a (modified) version of this patch into JBC trunk.

> LockParentForChildInsertRemove ignored with	PessimisticLocking
> --------------------------------------------------------------
>
>                 Key: JBCACHE-1527
>                 URL: https://jira.jboss.org/jira/browse/JBCACHE-1527
>             Project: JBoss Cache
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>          Components: Locking
>    Affects Versions: 3.1.0.GA
>            Reporter: Brian Stansberry
>            Assignee: Manik Surtani
>             Fix For: 3.2.0.GA
>
>         Attachments: DGTest.java, JBCACHE-1527.patch
>
>
> From looking at the JBC 3 code, it seems the 
> LockParentForChildInsertRemove configuration is no longer respected for 
> pessimistic locking.  I can't trace any path from the property in 
> Configuration to code that uses it. 
> PessimisticLockInterceptor.handlePutCommand, handleMoveCommand and 
> handleRemoveNodeCommand all always tell the lock manager to lock 
> parents. handleEvictFqnCommand always tells the lock manager not to lock 
> parents.
> This is causing failures in buddy replication testing when nodes 
> join/leave clusters under load. There's a lot of data gravitation plus 
> stuff like migrating defunct backup trees to "DEAD" regions. Too much 
> contention for parent level locks.
> Plus locking on the structural parent to add/remove session nodes will 
> suck for the session caching use case.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira