[jbosstools-commits] JBoss Tools SVN: r12897 - trunk/vpe/plugins/org.jboss.tools.vpe/src/org/jboss/tools/vpe/editor.

jbosstools-commits at lists.jboss.org jbosstools-commits at lists.jboss.org
Tue Jan 6 11:28:12 EST 2009


Author: yradtsevich
Date: 2009-01-06 11:28:09 -0500 (Tue, 06 Jan 2009)
New Revision: 12897

Modified:
   trunk/vpe/plugins/org.jboss.tools.vpe/src/org/jboss/tools/vpe/editor/VpeVisualDomBuilder.java
Log:
RESOLVED - issue JBIDE-3473: Something wrong with text processing inside table.
https://jira.jboss.org/jira/browse/JBIDE-3473

Now during node update old node is deleting AFTER a new node was added.

Modified: trunk/vpe/plugins/org.jboss.tools.vpe/src/org/jboss/tools/vpe/editor/VpeVisualDomBuilder.java
===================================================================
--- trunk/vpe/plugins/org.jboss.tools.vpe/src/org/jboss/tools/vpe/editor/VpeVisualDomBuilder.java	2009-01-06 16:16:39 UTC (rev 12896)
+++ trunk/vpe/plugins/org.jboss.tools.vpe/src/org/jboss/tools/vpe/editor/VpeVisualDomBuilder.java	2009-01-06 16:28:09 UTC (rev 12897)
@@ -1031,8 +1031,11 @@
 			nsIDOMNode visualContainer = visualOldNode.getParentNode();
 			nsIDOMNode visualNextNode = visualOldNode.getNextSibling();
 			if (visualContainer != null) {
+				addNode(sourceNode, visualNextNode, visualContainer);
+				// If add the new node after deleting the old, in some cases
+				// XULRunner will work in unexpected way (see JBIDE-3473)
+				// so it is necessary to remove the old child AFTER adding the new 
 				visualContainer.removeChild(visualOldNode);
-				addNode(sourceNode, visualNextNode, visualContainer);
 			}
 		} else {
 			// Max Areshkau Why we need update parent node when we update text




More information about the jbosstools-commits mailing list