[jbosstools-commits] JBoss Tools SVN: r35299 - trunk/jsf/tests/org.jboss.tools.jsf.ui.test/src/org/jboss/tools/jsf/jsp/ca/test.

jbosstools-commits at lists.jboss.org jbosstools-commits at lists.jboss.org
Mon Oct 3 16:23:54 EDT 2011


Author: dazarov
Date: 2011-10-03 16:23:54 -0400 (Mon, 03 Oct 2011)
New Revision: 35299

Modified:
   trunk/jsf/tests/org.jboss.tools.jsf.ui.test/src/org/jboss/tools/jsf/jsp/ca/test/CAForELJavaAndJSTCompareTest.java
Log:
It is better to use AssertEquals then AssertTrue in case of comparing
https://issues.jboss.org/browse/JBIDE-9792

Modified: trunk/jsf/tests/org.jboss.tools.jsf.ui.test/src/org/jboss/tools/jsf/jsp/ca/test/CAForELJavaAndJSTCompareTest.java
===================================================================
--- trunk/jsf/tests/org.jboss.tools.jsf.ui.test/src/org/jboss/tools/jsf/jsp/ca/test/CAForELJavaAndJSTCompareTest.java	2011-10-03 20:00:24 UTC (rev 35298)
+++ trunk/jsf/tests/org.jboss.tools.jsf.ui.test/src/org/jboss/tools/jsf/jsp/ca/test/CAForELJavaAndJSTCompareTest.java	2011-10-03 20:23:54 UTC (rev 35299)
@@ -181,11 +181,11 @@
 	private boolean compareJavaAndJSTProposals(ELProposalProcessor.Proposal javaProposal, AutoELContentAssistantProposal jstProposal) {
 		assertNotNull ("Display String of Java EL Proposal should not be a null", javaProposal.getDisplayString());
 		assertNotNull ("Display String of JST EL Proposal should not be a null", jstProposal.getDisplayString());
-		assertTrue("Display Strings must be equal (Java: ["+javaProposal.getDisplayString() +"] != JST: [" + jstProposal.getDisplayString() + "])", javaProposal.getDisplayString().equals(jstProposal.getDisplayString()));
+		assertEquals("Display Strings must be equal", jstProposal.getDisplayString(), javaProposal.getDisplayString());
 
 		assertNotNull ("Additional Info String of Java EL Proposal should not be a null", javaProposal.getAdditionalProposalInfo());
 		assertNotNull ("Additional Info String of JST EL Proposal should not be a null", jstProposal.getAdditionalProposalInfo());
-		assertTrue("Additional Info Strings must be equal (Java: ["+javaProposal.getAdditionalProposalInfo() +"] != JST: [" + jstProposal.getAdditionalProposalInfo() + "])", javaProposal.getAdditionalProposalInfo().equals(jstProposal.getAdditionalProposalInfo()));
+		assertEquals("Additional Info Strings must be equal", jstProposal.getAdditionalProposalInfo(), javaProposal.getAdditionalProposalInfo());
 		return true;
 	}
 }



More information about the jbosstools-commits mailing list