[jbosstools-commits] JBoss Tools SVN: r42868 - in trunk/as/plugins: org.jboss.ide.eclipse.as.ui/jbossui/org/jboss/ide/eclipse/as/ui and 1 other directories.

jbosstools-commits at lists.jboss.org jbosstools-commits at lists.jboss.org
Tue Aug 7 02:59:30 EDT 2012


Author: rob.stryker at jboss.com
Date: 2012-08-07 02:59:27 -0400 (Tue, 07 Aug 2012)
New Revision: 42868

Modified:
   trunk/as/plugins/org.jboss.ide.eclipse.as.core/jbosscore/org/jboss/ide/eclipse/as/core/server/UnitedServerListener.java
   trunk/as/plugins/org.jboss.ide.eclipse.as.ui/jbossui/org/jboss/ide/eclipse/as/ui/Messages.java
   trunk/as/plugins/org.jboss.ide.eclipse.as.ui/jbossui/org/jboss/ide/eclipse/as/ui/Messages.properties
   trunk/as/plugins/org.jboss.ide.eclipse.as.ui/jbossui/org/jboss/ide/eclipse/as/ui/editor/DeploymentModuleOptionCompositeAssistant.java
   trunk/as/plugins/org.jboss.ide.eclipse.as.ui/jbossui/org/jboss/ide/eclipse/as/ui/editor/ModuleDeploymentPage.java
Log:
JBIDE-11982 to trunk

Modified: trunk/as/plugins/org.jboss.ide.eclipse.as.core/jbosscore/org/jboss/ide/eclipse/as/core/server/UnitedServerListener.java
===================================================================
--- trunk/as/plugins/org.jboss.ide.eclipse.as.core/jbosscore/org/jboss/ide/eclipse/as/core/server/UnitedServerListener.java	2012-08-06 16:38:04 UTC (rev 42867)
+++ trunk/as/plugins/org.jboss.ide.eclipse.as.core/jbosscore/org/jboss/ide/eclipse/as/core/server/UnitedServerListener.java	2012-08-07 06:59:27 UTC (rev 42868)
@@ -64,4 +64,21 @@
 		}
 		return false;
 	}
+	
+	public boolean serverModulesChanged(ServerEvent event, int state) {
+		int eventKind = event.getKind();
+		if ((eventKind & ServerEvent.MODULE_CHANGE) != 0) {
+			return true;
+		}
+		return false;
+	}
+	public boolean serverPublishStateChanged(ServerEvent event, int state) {
+		int eventKind = event.getKind();
+		if ((eventKind & ServerEvent.PUBLISH_STATE_CHANGE) != 0) {
+			return true;
+		}
+		return false;
+	}
+	
+	
 }

Modified: trunk/as/plugins/org.jboss.ide.eclipse.as.ui/jbossui/org/jboss/ide/eclipse/as/ui/Messages.java
===================================================================
--- trunk/as/plugins/org.jboss.ide.eclipse.as.ui/jbossui/org/jboss/ide/eclipse/as/ui/Messages.java	2012-08-06 16:38:04 UTC (rev 42867)
+++ trunk/as/plugins/org.jboss.ide.eclipse.as.ui/jbossui/org/jboss/ide/eclipse/as/ui/Messages.java	2012-08-07 06:59:27 UTC (rev 42868)
@@ -222,7 +222,9 @@
 	public static String EditorNoRuntimeSelected;
 	public static String EditorLocalDeployment;
 	public static String EditorRefreshViewer;
+	public static String EditorDeploymentPageWarning;
 	
+	
 	public static String ExploreUtils_Action_Text;
 	public static String ExploreUtils_Description;
 

Modified: trunk/as/plugins/org.jboss.ide.eclipse.as.ui/jbossui/org/jboss/ide/eclipse/as/ui/Messages.properties
===================================================================
--- trunk/as/plugins/org.jboss.ide.eclipse.as.ui/jbossui/org/jboss/ide/eclipse/as/ui/Messages.properties	2012-08-06 16:38:04 UTC (rev 42867)
+++ trunk/as/plugins/org.jboss.ide.eclipse.as.ui/jbossui/org/jboss/ide/eclipse/as/ui/Messages.properties	2012-08-07 06:59:27 UTC (rev 42868)
@@ -197,7 +197,7 @@
 EditorNoRuntimeSelected=No Runtime Selected. Please select a runtime and refresh your deployment options.
 EditorLocalDeployment=Local Deployment
 EditorRefreshViewer=Refresh Table
-
+EditorDeploymentPageWarning=Settings on this page may only be modified if the server has 0 modules and is fully synchronized.
 ExploreUtils_Action_Text=File Browser
 ExploreUtils_Description=Explore deploy directory
 

Modified: trunk/as/plugins/org.jboss.ide.eclipse.as.ui/jbossui/org/jboss/ide/eclipse/as/ui/editor/DeploymentModuleOptionCompositeAssistant.java
===================================================================
--- trunk/as/plugins/org.jboss.ide.eclipse.as.ui/jbossui/org/jboss/ide/eclipse/as/ui/editor/DeploymentModuleOptionCompositeAssistant.java	2012-08-06 16:38:04 UTC (rev 42867)
+++ trunk/as/plugins/org.jboss.ide.eclipse.as.ui/jbossui/org/jboss/ide/eclipse/as/ui/editor/DeploymentModuleOptionCompositeAssistant.java	2012-08-07 06:59:27 UTC (rev 42868)
@@ -976,4 +976,18 @@
 			return new Path(folder).append(outputName).toPortableString();
 		return outputName;
 	}
+
+	public void setEnabled(boolean enabled) {
+		Control[] c = new Control[] { 
+				viewer.getTree(), deployText, tempDeployText, 
+				metadataRadio, serverRadio, customRadio, currentSelection, 
+				deployButton, tempDeployButton,zipDeployWTPProjects				
+		};
+		System.out.println("Setting enablement to " + enabled);
+		for( int i = 0; i < c.length; i++ ) {
+			if( c[i] != null && !c[i].isDisposed()) {
+				c[i].setEnabled(enabled);
+			}
+		}
+	}
 }

Modified: trunk/as/plugins/org.jboss.ide.eclipse.as.ui/jbossui/org/jboss/ide/eclipse/as/ui/editor/ModuleDeploymentPage.java
===================================================================
--- trunk/as/plugins/org.jboss.ide.eclipse.as.ui/jbossui/org/jboss/ide/eclipse/as/ui/editor/ModuleDeploymentPage.java	2012-08-06 16:38:04 UTC (rev 42867)
+++ trunk/as/plugins/org.jboss.ide.eclipse.as.ui/jbossui/org/jboss/ide/eclipse/as/ui/editor/ModuleDeploymentPage.java	2012-08-07 06:59:27 UTC (rev 42868)
@@ -16,30 +16,38 @@
 import org.eclipse.core.runtime.IStatus;
 import org.eclipse.core.runtime.NullProgressMonitor;
 import org.eclipse.core.runtime.Path;
+import org.eclipse.swt.SWT;
 import org.eclipse.swt.layout.FormAttachment;
 import org.eclipse.swt.layout.FormData;
 import org.eclipse.swt.layout.FormLayout;
 import org.eclipse.swt.widgets.Composite;
 import org.eclipse.swt.widgets.Control;
+import org.eclipse.swt.widgets.Display;
+import org.eclipse.swt.widgets.Label;
 import org.eclipse.ui.IEditorInput;
 import org.eclipse.ui.IEditorSite;
 import org.eclipse.ui.forms.widgets.FormToolkit;
 import org.eclipse.ui.forms.widgets.ScrolledForm;
 import org.eclipse.wst.server.core.IModule;
 import org.eclipse.wst.server.core.IRuntime;
+import org.eclipse.wst.server.core.IServer;
+import org.eclipse.wst.server.core.IServerListener;
 import org.eclipse.wst.server.core.IServerWorkingCopy;
+import org.eclipse.wst.server.core.ServerEvent;
 import org.eclipse.wst.server.ui.editor.IServerEditorPartInput;
 import org.eclipse.wst.server.ui.editor.ServerEditorPart;
 import org.eclipse.wst.server.ui.internal.command.ServerCommand;
 import org.eclipse.wst.server.ui.internal.editor.ServerEditorPartInput;
 import org.eclipse.wst.server.ui.internal.editor.ServerResourceCommandManager;
 import org.jboss.ide.eclipse.as.core.server.IJBossServerRuntime;
+import org.jboss.ide.eclipse.as.core.server.UnitedServerListener;
 import org.jboss.ide.eclipse.as.core.server.internal.ServerAttributeHelper;
 import org.jboss.ide.eclipse.as.core.util.DeploymentPreferenceLoader;
 import org.jboss.ide.eclipse.as.core.util.DeploymentPreferenceLoader.DeploymentModulePrefs;
 import org.jboss.ide.eclipse.as.core.util.DeploymentPreferenceLoader.DeploymentPreferences;
 import org.jboss.ide.eclipse.as.core.util.ServerUtil;
 import org.jboss.ide.eclipse.as.ui.Messages;
+import org.jboss.ide.eclipse.as.ui.UIUtil;
 
 public class ModuleDeploymentPage extends ServerEditorPart {
 	protected ServerResourceCommandManager commandManager;
@@ -47,6 +55,7 @@
 	protected DeploymentPreferences preferences;
 	protected ServerAttributeHelper helper; 
 	protected DeploymentModuleOptionCompositeAssistant tab;
+	private IServerListener listener;
 	public ServerAttributeHelper getHelper() {
 		if( helper == null ) {
 			helper = new ServerAttributeHelper(getServer().getOriginal(), getServer());
@@ -80,10 +89,42 @@
 			server = sepi.getServer();
 			commandManager = ((ServerEditorPartInput) sepi).getServerCommandManager();
 			readOnly = sepi.isServerReadOnly();
+			helper = new ServerAttributeHelper(server.getOriginal(), server);
+			listener = new UnitedServerListener() {
+				public void serverChanged(ServerEvent event) {
+					setDeploymentTabEnablement(event.getModule());
+				}
+			};
+			server.getOriginal().addServerListener(listener);
 		}
-		helper = new ServerAttributeHelper(server.getOriginal(), server);
 	}
 	
+	protected void setDeploymentTabEnablement(IModule[] changed) {
+		// This is a big hack due to https://bugs.eclipse.org/bugs/show_bug.cgi?id=386718
+		// IT seems getting the NEW module list from the event is not possible,
+		// and figuring out if a module was added also does not seem to be possible
+		new Thread() {
+			public void run() {
+				try {
+					Thread.sleep(300);
+				} catch(InterruptedException ie) {}
+				
+				IModule[] deployed = server.getOriginal().getModules();
+				final boolean hasNoModules = deployed == null || deployed.length == 0;
+				final boolean enabled =  hasNoModules && server.getOriginal().getServerPublishState() == IServer.PUBLISH_STATE_NONE;
+				Display.getDefault().asyncExec(new Runnable() { 
+					public void run() {
+						tab.setEnabled(enabled);
+					}
+				});
+			}
+		}.start();
+	}
+	
+	public void dispose() {
+		super.dispose();
+		server.getOriginal().removeServerListener(listener);
+	}
 	public void refreshPossibleModules() {
 		ArrayList<IModule> possibleChildren = new ArrayList<IModule>();
 		IModule[] modules2 = org.eclipse.wst.server.core.ServerUtil.getModules(server.getServerType().getRuntimeType().getModuleTypes());
@@ -117,18 +158,19 @@
 	}
 	
 	private void addDeploymentLocationControls(Composite parent, Control top) {
+		FormToolkit toolkit = new FormToolkit(parent.getDisplay());
+		Label l1 = toolkit.createLabel(parent, Messages.EditorDeploymentPageWarning); 
+		FormData fd = new FormData();
+		fd.left = new FormAttachment(0, 5);
+		fd.top = top == null ? new FormAttachment(0, 5) : new FormAttachment(top, 5); 
+		fd.right = new FormAttachment(100, -5);
+		l1.setLayoutData(fd);
+		
 		tab = new DeploymentModuleOptionCompositeAssistant();
 		tab.setDeploymentPage(this);
 		tab.setDeploymentPrefs(preferences);
 		Composite defaultComposite = tab.createDefaultComposite(parent);
-		FormData fd = new FormData();
-		fd.left = new FormAttachment(0, 5);
-		if( top == null )
-			fd.top = new FormAttachment(0, 5);
-		else
-			fd.top = new FormAttachment(top, 5);
-		fd.right = new FormAttachment(100, -5);
-		defaultComposite.setLayoutData(fd);
+		defaultComposite.setLayoutData(UIUtil.createFormData2(l1, 5, null,0,0,5,100,-5));
 		
 		Composite viewComposite = tab.createViewerPortion(parent);
 		fd = new FormData();



More information about the jbosstools-commits mailing list