[jbosstools-commits] JBoss Tools SVN: r42474 - trunk/common/plugins/org.jboss.tools.common/src/org/jboss/tools/common/java.

[jbosstools-commits at lists.jboss.org]

Author: scabanovich
Date: 2012-07-09 17:03:33 -0400 (Mon, 09 Jul 2012)
New Revision: 42474

Modified:
   trunk/common/plugins/org.jboss.tools.common/src/org/jboss/tools/common/java/ParametedTypeFactory.java
Log:
JBIDE-12296
https://issues.jboss.org/browse/JBIDE-12296
Map ParametedTypeFactory.cache is accessed from different threads by build and as-you-type validation. It should be synchronized.

Modified: trunk/common/plugins/org.jboss.tools.common/src/org/jboss/tools/common/java/ParametedTypeFactory.java
===================================================================
--- trunk/common/plugins/org.jboss.tools.common/src/org/jboss/tools/common/java/ParametedTypeFactory.java	2012-07-09 20:48:30 UTC (rev 42473)
+++ trunk/common/plugins/org.jboss.tools.common/src/org/jboss/tools/common/java/ParametedTypeFactory.java	2012-07-09 21:03:33 UTC (rev 42474)
@@ -11,6 +11,7 @@
 package org.jboss.tools.common.java;
 
 import java.util.HashMap;
+import java.util.Hashtable;
 import java.util.Map;
 
 import org.eclipse.core.runtime.CoreException;
@@ -25,20 +26,20 @@
 
 public class ParametedTypeFactory { 
 	// I S J C F D Z
-	static HashMap<Character,String> primitives = new HashMap<Character, String>();
+	static Map<Character,String> primitives = new HashMap<Character, String>();
 	static {
-		primitives.put(Signature.C_INT, "Ljava.lang.Integer;");
-		primitives.put(Signature.C_SHORT, "Ljava.lang.Short;");
-		primitives.put(Signature.C_LONG, "Ljava.lang.Long;");
-		primitives.put(Signature.C_CHAR, "Ljava.lang.Character;");
-		primitives.put(Signature.C_FLOAT, "Ljava.lang.Float;");
-		primitives.put(Signature.C_DOUBLE, "Ljava.lang.Double;");
-		primitives.put(Signature.C_BOOLEAN, "Ljava.lang.Boolean;");
-		primitives.put(Signature.C_BYTE, "Ljava.lang.Boolean;");
+		primitives.put(Signature.C_INT, "Ljava.lang.Integer;"); //$NON-NLS-1$
+		primitives.put(Signature.C_SHORT, "Ljava.lang.Short;"); //$NON-NLS-1$
+		primitives.put(Signature.C_LONG, "Ljava.lang.Long;"); //$NON-NLS-1$
+		primitives.put(Signature.C_CHAR, "Ljava.lang.Character;"); //$NON-NLS-1$
+		primitives.put(Signature.C_FLOAT, "Ljava.lang.Float;"); //$NON-NLS-1$
+		primitives.put(Signature.C_DOUBLE, "Ljava.lang.Double;"); //$NON-NLS-1$
+		primitives.put(Signature.C_BOOLEAN, "Ljava.lang.Boolean;"); //$NON-NLS-1$
+		primitives.put(Signature.C_BYTE, "Ljava.lang.Boolean;"); //$NON-NLS-1$
 	}
 	//unresolved Object signature
 	public static String OBJECT = "QObject;"; //$NON-NLS-1$
-	Map<String, ParametedType> cache = new HashMap<String, ParametedType>();
+	Map<String, ParametedType> cache = new Hashtable<String, ParametedType>();
 
 	public ParametedType newParametedType(IType type) {
 		ParametedType parametedType = new ParametedType();