[jbosstools-commits] JBoss Tools SVN: r42568 - trunk/jst/plugins/org.jboss.tools.jst.jsp/src/org/jboss/tools/jst/jsp/selection/bar.

jbosstools-commits at lists.jboss.org jbosstools-commits at lists.jboss.org
Fri Jul 13 06:10:52 EDT 2012


Author: dmaliarevich
Date: 2012-07-13 06:10:51 -0400 (Fri, 13 Jul 2012)
New Revision: 42568

Modified:
   trunk/jst/plugins/org.jboss.tools.jst.jsp/src/org/jboss/tools/jst/jsp/selection/bar/SelectionBarHandler.java
Log:
https://issues.jboss.org/browse/JBIDE-12330 - Explicitly change the selection bar visibility

Modified: trunk/jst/plugins/org.jboss.tools.jst.jsp/src/org/jboss/tools/jst/jsp/selection/bar/SelectionBarHandler.java
===================================================================
--- trunk/jst/plugins/org.jboss.tools.jst.jsp/src/org/jboss/tools/jst/jsp/selection/bar/SelectionBarHandler.java	2012-07-13 09:55:30 UTC (rev 42567)
+++ trunk/jst/plugins/org.jboss.tools.jst.jsp/src/org/jboss/tools/jst/jsp/selection/bar/SelectionBarHandler.java	2012-07-13 10:10:51 UTC (rev 42568)
@@ -18,6 +18,7 @@
 import org.eclipse.core.commands.ExecutionException;
 import org.eclipse.core.commands.HandlerEvent;
 import org.eclipse.core.expressions.IEvaluationContext;
+import org.eclipse.ui.IEditorPart;
 import org.eclipse.ui.ISources;
 import org.eclipse.ui.commands.IElementUpdater;
 import org.eclipse.ui.handlers.HandlerUtil;
@@ -72,9 +73,19 @@
 		/*
 		 * Change command state and save it to PreferenceStore
 		 */
+		boolean visible = !HandlerUtil.toggleCommandState(event.getCommand()); 
 		JspEditorPlugin.getDefault().getPreferenceStore().setValue(
 				IVpePreferencesPage.SHOW_SELECTION_TAG_BAR,
-						!HandlerUtil.toggleCommandState(event.getCommand()));
+				visible);
+		/*
+		 * https://issues.jboss.org/browse/JBIDE-12330
+		 * Explicitly change the selection bar visibility,
+		 * because listeners do not catch this event in eclipse 4.2. 
+		 */
+		IEditorPart activeEditor = HandlerUtil.getActiveEditorChecked(event);
+		if(activeEditor instanceof JSPMultiPageEditor) {
+			((JSPMultiPageEditor) activeEditor).getSelectionBar().setVisible(visible);
+		}
 		return null;
 	}
 	



More information about the jbosstools-commits mailing list