[jbosstools-commits] JBoss Tools SVN: r39428 - trunk/vpe/plugins/org.jboss.tools.vpe.browsersim.browser/src/org/jboss/tools/vpe/browsersim/browser.

[jbosstools-commits at lists.jboss.org]

Author: yradtsevich
Date: 2012-03-11 07:01:03 -0400 (Sun, 11 Mar 2012)
New Revision: 39428

Modified:
   trunk/vpe/plugins/org.jboss.tools.vpe.browsersim.browser/src/org/jboss/tools/vpe/browsersim/browser/AbstractWebKitBrowser.java
Log:
https://issues.jboss.org/browse/JBIDE-11165 : BrowserSim: StringIndexOutOfBoundsException on Linux when emty URL is entered

Modified: trunk/vpe/plugins/org.jboss.tools.vpe.browsersim.browser/src/org/jboss/tools/vpe/browsersim/browser/AbstractWebKitBrowser.java
===================================================================
--- trunk/vpe/plugins/org.jboss.tools.vpe.browsersim.browser/src/org/jboss/tools/vpe/browsersim/browser/AbstractWebKitBrowser.java	2012-03-10 19:28:38 UTC (rev 39427)
+++ trunk/vpe/plugins/org.jboss.tools.vpe.browsersim.browser/src/org/jboss/tools/vpe/browsersim/browser/AbstractWebKitBrowser.java	2012-03-11 11:01:03 UTC (rev 39428)
@@ -26,10 +26,18 @@
 
 	@Override
 	public boolean setUrl(String url, String postData, String[] headers) {
-		setCustomUserAgent(defaultUserAgent);
-		boolean result = super.setUrl(url, postData, headers);
-		setCustomUserAgent(defaultUserAgent);
-		return result;
+		if (url != null && url.trim().isEmpty()) {
+			/* If the url is empty, then just ignore it to avoid
+			 * StringIndexOutOfBoundsException under Linux (JBIDE-11165)
+			 * (in the case if url == null, then super.setUrl
+			 * will throw an IllegalArgumentException, thus we do not need to handle this).*/
+			return false;
+		} else {
+			setCustomUserAgent(defaultUserAgent);
+			boolean result = super.setUrl(url, postData, headers);
+			setCustomUserAgent(defaultUserAgent);
+			return result;
+		}
 	}
 
 	@Override