[jbosstools-commits] JBoss Tools SVN: r43915 - trunk/openshift/plugins/org.jboss.tools.openshift.express.ui/src/org/jboss/tools/openshift/express/internal/ui/wizard.

[jbosstools-commits at lists.jboss.org]

Author: adietish
Date: 2012-09-21 04:53:14 -0400 (Fri, 21 Sep 2012)
New Revision: 43915

Modified:
   trunk/openshift/plugins/org.jboss.tools.openshift.express.ui/src/org/jboss/tools/openshift/express/internal/ui/wizard/GitCloningSettingsWizardPage.java
Log:
[JBIDE-11912] implementation finished: corrected bugs with layout and validation status

Modified: trunk/openshift/plugins/org.jboss.tools.openshift.express.ui/src/org/jboss/tools/openshift/express/internal/ui/wizard/GitCloningSettingsWizardPage.java
===================================================================
--- trunk/openshift/plugins/org.jboss.tools.openshift.express.ui/src/org/jboss/tools/openshift/express/internal/ui/wizard/GitCloningSettingsWizardPage.java	2012-09-21 08:51:52 UTC (rev 43914)
+++ trunk/openshift/plugins/org.jboss.tools.openshift.express.ui/src/org/jboss/tools/openshift/express/internal/ui/wizard/GitCloningSettingsWizardPage.java	2012-09-21 08:53:14 UTC (rev 43915)
@@ -11,7 +11,6 @@
 package org.jboss.tools.openshift.express.internal.ui.wizard;
 
 import org.eclipse.core.databinding.DataBindingContext;
-import org.eclipse.core.databinding.UpdateValueStrategy;
 import org.eclipse.core.databinding.beans.BeanProperties;
 import org.eclipse.core.databinding.observable.value.IObservableValue;
 import org.eclipse.core.databinding.validation.IValidator;
@@ -199,11 +198,14 @@
 		sshLink.addSelectionListener(onSshPrefs("SSH2 Preferences"));
 		sshLink.addSelectionListener(onManageSSHKeys("SSH Keys wizard"));
 		
+		// we need a binding to have validation setting wizard validation status
+		Label dummyLabel = new Label(parent, SWT.None);
+		dummyLabel.setVisible(false);
+		GridDataFactory.fillDefaults().exclude(true).applyTo(dummyLabel);
 		ValueBindingBuilder
-				.bind(WidgetProperties.text().observe(sshLink))
+				.bind(WidgetProperties.text().observe(dummyLabel))
 				.notUpdating(BeanProperties.value(
 						GitCloningSettingsWizardPageModel.PROPERTY_HAS_REMOTEKEYS).observe(pageModel))
-				.withStrategy(new UpdateValueStrategy(UpdateValueStrategy.POLICY_CONVERT))
 				.validatingAfterGet(new IValidator() {
 
 					@Override