[jbosstools-commits] JBoss Tools SVN: r43941 - trunk/common/plugins/org.jboss.tools.common.model/src/org/jboss/tools/common/model/filesystems/impl.

jbosstools-commits at lists.jboss.org jbosstools-commits at lists.jboss.org
Fri Sep 21 17:54:00 EDT 2012


Author: scabanovich
Date: 2012-09-21 17:54:00 -0400 (Fri, 21 Sep 2012)
New Revision: 43941

Modified:
   trunk/common/plugins/org.jboss.tools.common.model/src/org/jboss/tools/common/model/filesystems/impl/FileAnyImpl.java
Log:
JBIDE-12479
https://issues.jboss.org/browse/JBIDE-12479
Previous commit of FileAnyImpl commented "XModel file objects should not keep references to long strings." has a logic error in method set(String, String).



Modified: trunk/common/plugins/org.jboss.tools.common.model/src/org/jboss/tools/common/model/filesystems/impl/FileAnyImpl.java
===================================================================
--- trunk/common/plugins/org.jboss.tools.common.model/src/org/jboss/tools/common/model/filesystems/impl/FileAnyImpl.java	2012-09-21 21:39:42 UTC (rev 43940)
+++ trunk/common/plugins/org.jboss.tools.common.model/src/org/jboss/tools/common/model/filesystems/impl/FileAnyImpl.java	2012-09-21 21:54:00 UTC (rev 43941)
@@ -212,8 +212,10 @@
         			|| ATTR_NAME_INCORRECT_BODY.equals(name)
         		) {
     			//do nothing
+    			return;
     		}
-		} else if(ATTR_NAME__BODY_.equals(name)) {
+		}
+		if(ATTR_NAME__BODY_.equals(name)) {
 			tempBody = value;
 		} else if((!XML_ATTR_NAME.equals(name) && !"EXTENSION".equals(name)) || !isActive() || !(getParent() instanceof FolderImpl)) { //$NON-NLS-1$
 			super.set(name, value);



More information about the jbosstools-commits mailing list