[jbosstools-dev] Re: [jbosstools-commits] JBoss Tools SVN: r5304 - trunk/jsf/plugins/org.jboss.tools.jsf.vpe.seam.

[Max Rydahl Andersen]

On Mon, 17 Dec 2007 12:46:22 +0100, Vitali Yemialyanchyk  
<vyemialyanchyk at exadel.com> wrote:

> This is necessary for [s:formattedText] support. Look at
> http://docs.jboss.com/seam/2.0.0.GA/reference/en/html/text.html.
> To support all these features we should use antlr - the same way as seam
> does.

yes, but

1) this is LGPL'ed code!
2) Seam does not use all these jars at runtime
3) This is not a simple bugfix for a 2.0.1

/max

>
> Vitali.
>
> -----Original Message-----
> From: external-exadel-list-bounces at redhat.com
> [mailto:external-exadel-list-bounces at redhat.com] On Behalf Of Max Rydahl
> Andersen
> Sent: Sunday, December 16, 2007 10:11 PM
> To: jbosstools-dev at lists.jboss.org
> Cc: external-exadel-list at redhat.com
> Subject: Fwd: [jbosstools-commits] JBoss Tools SVN: r5304 -
> trunk/jsf/plugins/org.jboss.tools.jsf.vpe.seam.
>
> why are we adding new features and "largish" new antlr dependencies in
> 2.0.1 !?
>
> -max
>
> ------- Forwarded message -------
> From: jbosstools-commits at lists.jboss.org
> To: jbosstools-commits at lists.jboss.org
> Cc:
> Subject: [jbosstools-commits] JBoss Tools SVN: r5304 -
> trunk/jsf/plugins/org.jboss.tools.jsf.vpe.seam.
> Date: Fri, 14 Dec 2007 13:40:11 +0100
>
> Author: vyemialyanchyk
> Date: 2007-12-14 07:40:10 -0500 (Fri, 14 Dec 2007)
> New Revision: 5304
>
> Modified:
>     trunk/jsf/plugins/org.jboss.tools.jsf.vpe.seam/.classpath
>     trunk/jsf/plugins/org.jboss.tools.jsf.vpe.seam/build.properties
> Log:
> http://jira.jboss.com/jira/browse/JBIDE-1449
>
> Modified: trunk/jsf/plugins/org.jboss.tools.jsf.vpe.seam/.classpath
> ===================================================================
> --- trunk/jsf/plugins/org.jboss.tools.jsf.vpe.seam/.classpath	2007-12-14
> 12:39:40 UTC (rev 5303)
> +++ trunk/jsf/plugins/org.jboss.tools.jsf.vpe.seam/.classpath	2007-12-14
> 12:40:10 UTC (rev 5304)
> @@ -3,5 +3,8 @@
>   	<classpathentry kind="src" path="src"/>
>   	<classpathentry kind="con"
> path="org.eclipse.jdt.launching.JRE_CONTAINER"/>
>   	<classpathentry kind="con"
> path="org.eclipse.pde.core.requiredPlugins"/>
> +	<classpathentry kind="lib" path="lib/ant-antlr.jar"/>
> +	<classpathentry kind="lib" path="lib/antlr.jar"/>
> +	<classpathentry kind="lib" path="lib/antlr-runtime.jar"/>
>   	<classpathentry kind="output" path="bin"/>
>   </classpath>
>
> Modified: trunk/jsf/plugins/org.jboss.tools.jsf.vpe.seam/build.properties
> ===================================================================
> ---
> trunk/jsf/plugins/org.jboss.tools.jsf.vpe.seam/build.properties	2007-12-14
> 12:39:40 UTC (rev 5303)
> +++
> trunk/jsf/plugins/org.jboss.tools.jsf.vpe.seam/build.properties	2007-12-14
> 12:40:10 UTC (rev 5304)
> @@ -3,11 +3,10 @@
>   bin.includes = META-INF/,\
>                  .,\
>                  plugin.xml,\
> +               lib/,\
> +               lib/ant-antlr.jar,\
> +               lib/antlr.jar,\
> +               lib/antlr-runtime.jar,\
>                  templates/
>   src.includes = templates/,\
> -               src/,\
> -               plugin.xml,\
> -               build.properties,\
> -               META-INF/,\
> -               .project,\
> -               .classpath
> +               src/
>
> _______________________________________________
> jbosstools-commits mailing list
> jbosstools-commits at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/jbosstools-commits
>
>
>



-- 
--
Max Rydahl Andersen
callto://max.rydahl.andersen

Hibernate
max at hibernate.org
http://hibernate.org

JBoss a division of Red Hat
max.andersen at jboss.com