[jbosstools-dev] Questions found while looking at report problem reimplementation

[Max Rydahl Andersen]

> 4) The layout looks weird on linux - the right side of all the text 
> fields are chopped of (the dialog is to narrow) - note commenting out
> the hard coded getPreferredSize did not help, it just made it worse.

Fixed this issue and a bunch of other simplifications in the code.

Found some more questions ;)

1) ClassLoaderUtil.init() ?

Why is ClassLoaderUtil.init() placed in ReportProblemAction.run() ?
When is that needed ?

Removing it gives a weird error:

"Can't create new JBoss Server."

java.lang.NullPointerException

at 
org.jboss.tools.common.model.options.Preference.getValue(Preference.java:33)

at 
org.jboss.tools.common.model.options.PreferenceModelUtilities.initPreferenceValue(PreferenceModelUtilities.java:69)

at 
org.jboss.tools.jst.web.WebModelPlugin.initializeDefaultPluginPreferences(WebModelPlugin.java:97)

at 
org.eclipse.core.runtime.Plugin.internalInitializeDefaultPluginPreferences(Plugin.java:449)

at 
org.eclipse.core.internal.preferences.legacy.InitLegacyPreferences.init(InitLegacyPreferences.java:52)

at 
org.eclipse.core.internal.preferences.PreferenceServiceRegistryHelper.applyRuntimeDefaults(PreferenceServiceRegistryHelper.java:146)

Why?

2) Is there some crazy heavy initialization required to show the Report 
Problem dialog ?

It takes seconds before it shows up the first time (not done anything 
else) ....what is going on ? Is XModel loading the whole world ?

3) Resource keys

There is a plugin.properties file with localization properties, e.g.

action.reportproblem.label=Report Problem

Inside ReportProblemAction, .setObject(properties) are used to 
initialize headers - where are the localization files for these strings 
? e.g. subtitle, header etc. ?

/max