[jbosstools-dev] [Fwd: [jbosstools-commits] JBoss Tools SVN: r3756- trunk/jst/plugins/org.jboss.tools.jst.web.ui/src/org/jboss/tools/jst/web/ui/action/server.]

[Max Rydahl Andersen]

Viacheslav Kabanovich wrote:
> Hello Max,
> 
> Changes today:
> 
> If WAR is referenced by EAR, I touch %ear content%/META-INF/application.xml,
> otherwise I touch % war content%/WEB-INF/web.xml.
> 
> Content dir is obtained by using wst model.
> 

Ok, so the answers to my original questions is:

 >>1) Why is both the manifest.mf and web.xml being touched for ear 
 >>deployment ? The war is inside the ear so just touching the ear 
should >>be enough; doesn't touching both trigger risk a double-restart ?

Fixed by this:
 > If WAR is referenced by EAR, I touch %ear 
content%/META-INF/application.xml,
 > otherwise I touch % war content%/WEB-INF/web.xml.

 >>2) We should also check that if the war is inside an ear the ear 
 >>descriptor should be touched; and if not in an ear the war descriptor 
 >>should be touched. Do we do that already ?

Does this also work for EJB projects now ?

 >>3) The code scans *all* project files multiple times - that can't be 
 >>very efficient for large projects.

 >>Since these projects knows where their descriptors are why are we 
 >>scanning for them ?

I guess this is fixed now too ;)

 >4) btw. seam-gen uses this for ear's:
 >
 >    <target name="restart" depends="explode" description="Restart the 
exploded archive">
 >        <touch file="${ear.deploy.dir}/META-INF/application.xml"/>
 >    </target>

 >Why did you choose manifest.mf for ear ?

Not relevant anymore it seems ;)

/max