[jbosstools-dev] Re: [Fwd: Build failed in Hudson: JBossTools #382]

[Dmitry Geraskov]

Max Rydahl Andersen wrote:

>>>>>I've found that 2 hibernate plugins (org.hibernate.eclipse.console and
>>>>>org.hibernate.eclipse.mapper) compiled with jdk 1.4 level and others
>>>>>with level 1.5.
>>>>>Can I change their compilation level to 1.5?
>>>>>
>>>>>          
>>>>>
>>>>No; we don't use jdk 5 on the hibernate plugins just yet. Is it needed?
>>>>
>>>>-max
>>>>
>>>>
>>>>        
>>>>
>>>No, but after Denises letter I decided completely synchronize with svn
>>>and foud that I used SringBuilder (from jdk 1.5 ) in
>>>OpenSource/MappingActions but jdk level in svn is 1.4.
>>>Why we haven't compilation error there?
>>>I'll change StringBuilder to StringBuffer.
>>>
>>>      
>>>
>>Also I found that MTreeViewer uses jdk 1.5 syntax.
>>    
>>
>
>Weird that you don't get compile errors if the level is set to 1.4.
>
>Let me just check a few things and maybe upgrading the plugins to 1.5 is ok. But
>do please change it to be compilable for now.
>
>-max
>  
>
No, I have (locally). But as Denis wrote me about compilation errors on 
Hudson build in

org.hibernate.eclipse.console.test plugin I was surprised why we haven't errors in 
org.hibernate.eclipse.console plugin earlier(on the build)? Or this build doesn't build org.hibernate.eclipse.console plugin?


-- 
Best regards,

 Dmitry Geraskov              
 dgeraskov at exadel.com
 Senior Developer
 Exadel Inc