[jbosstools-dev] Unnecessary dependency

Dmitry Geraskov dgeraskov at exadel.com
Thu Jun 12 04:09:18 EDT 2008


Hi, Denis,

I noticed that you have added HQLEditorPreferencePageTest to 
org.hibernate.eclipse.console.test.

This class uses one method of WorkbenchUtils class from 
org.jboss.tools.test plugin and it made you to add the dependency into 
manifest.
The method is rather simple:

public static PreferenceDialog createPreferenceDialog(String pageId) {
        return PreferencesUtil.createPreferenceDialogOn(WorkbenchUtils
                .getActiveShell(), pageId, new String[] {pageId}, null);
    }

I think that this dependency not so necessary to make us to create the 
depency between the plugins.
If we remove using WorkbenchUtils class then repetition of code will be 
minimal.


-- 
Best regards,

 Dmitry Geraskov              





More information about the jbosstools-dev mailing list