[jbosstools-dev] Re: Unnecessary dependency

[Dmitry Geraskov]

Hm...
May be better solution is to create 'test.util' plugin and other plugins 
will depend on it, but not on each other?

Denis Golovin пишет:
>
> Dmitry,
>
> I'd say it this way :)
>
> You're right about this particular case, but ....
>
> First of all you cannot keep it separate from org.jboss.tools.tests in 
> the future.
>
> There are a lot of functionality that I would move to 
> org.jboss.tools.tests plug-in to share it  among all test plugins:
> 1. Creating a project with java nature or adding it to existing 
> projects, example is MappingTestProject.buildJavaProject
> 2. Recursive copy files, example is MappingTestProject.recursiveCopyFiles
> 3. You name it :)
>
> So you can copy code and remove this particular dependency but soon 
> you will have to put it back.
>
> Best
>
> Denis
>
> Dmitry Geraskov wrote:
>> Hi, Denis,
>>
>> I noticed that you have added HQLEditorPreferencePageTest to 
>> org.hibernate.eclipse.console.test.
>>
>> This class uses one method of WorkbenchUtils class from 
>> org.jboss.tools.test plugin and it made you to add the dependency 
>> into manifest.
>> The method is rather simple:
>>
>> public static PreferenceDialog createPreferenceDialog(String pageId) {
>>        return PreferencesUtil.createPreferenceDialogOn(WorkbenchUtils
>>                .getActiveShell(), pageId, new String[] {pageId}, null);
>>    }
>>
>> I think that this dependency not so necessary to make us to create 
>> the depency between the plugins.
>> If we remove using WorkbenchUtils class then repetition of code will 
>> be minimal.
>>
>>
>

-- 
Best regards,

 Dmitry Geraskov              
 dgeraskov at exadel.com
 Exadel Inc