[jbosstools-dev] looking at the seam pages.xml editor

[Max Rydahl Andersen]

resending this....

Denis, Alexey, Slava - anyone ?

I'm mostly interested in what #1 is about.

#2 I can see now is just copies of existing code which results in #3 being worse - i'm fixing these when i bump into them.

/max

> Hi,
>
> I'm looking around in the seam pages xml editor (the graphical part).
>
> I  got a couple of quesitons about it ;)
>
> 1) If we are not using GMF why is EMF model then interesting for the graphical part ?
>
> 2) Isn't alot of this code inside org.jboss.tools.seam.ui.pages direct copies of existing code ?
>    e.g. the ConnectionRouter and alot of the common code in the EditParts looks very familiar ?
>    Shouldn't we consolidate this kind of code instead of keep duplicating it ?
>
> 3) Any reason why we are using arbitrary numbers in all the layout/painting ? :) e.g. 31, 21, 50 and 18 does not say much.
>    (note: I'm currently fixing this one since they hurt me alot when trying to update the graphics to be more light/less-bulky)
>
> /max
> _______________________________________________
> jbosstools-dev mailing list
> jbosstools-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/jbosstools-dev
> 



-- 
Using Opera's revolutionary e-mail client: http://www.opera.com/mail/