[jbosstools-dev] looking at the seam pages.xml editor

[Max Rydahl Andersen]

> 1) GMF provides a lot of new functionality, some of which
> is not needed and burdens the diagram. It is easy to develop
> GMF diagram as long as you stay within its restrictions.
> Any deviation from GMF standard requires a lot of efforts
> and studying, (though of course, everything can be done
> in the long run). On the other hand, EMF model saves a lot of
> efforts in codying without imposing any restrictions on view.

ok - I'll love to hear which efforts that EMF helps here. Ill wait for Daniel ;)

> 2) I agree with you 100% that same code should be in one place
> rather than copied. However, it is possible, that copying is
> made for future modifications, though of course if that future
> passes by without actual changes, it just leaves an unnecessary
> mess behind.

yup.

> 3) The design for figures on diagram is provided by our designer
> Alexey Dmitriev, who is sensitive about each pixel and the smallest
> difference in tints of colors. He provides the best looking design,
> and Danil converts it to numbers, which may look arbitrary.

Yes understood - but these numbers actually mean things and makes any small changes
impossible. They should be calculated so things *relative* to other objects
not fixed since then it looks bad at different resolutions/zoom levels +
it makes it really hard to modify/adjust.

/max

> Slava
>
>
> ----- Original Message -----
> From: "Max Rydahl Andersen" <max.andersen at redhat.com>
> To: "Max Rydahl Andersen" <max.andersen at redhat.com>;
> <jbosstools-dev at lists.jboss.org>
> Sent: Tuesday, June 17, 2008 1:42 PM
> Subject: Re: [jbosstools-dev] looking at the seam pages.xml editor
>
>
>> resending this....
>>
>> Denis, Alexey, Slava - anyone ?
>>
>> I'm mostly interested in what #1 is about.
>>
>> #2 I can see now is just copies of existing code which results in #3 being
> worse - i'm fixing these when i bump into them.
>>
>> /max
>>
>> > Hi,
>> >
>> > I'm looking around in the seam pages xml editor (the graphical part).
>> >
>> > I  got a couple of quesitons about it ;)
>> >
>> > 1) If we are not using GMF why is EMF model then interesting for the
> graphical part ?
>> >
>> > 2) Isn't alot of this code inside org.jboss.tools.seam.ui.pages direct
> copies of existing code ?
>> >    e.g. the ConnectionRouter and alot of the common code in the
> EditParts looks very familiar ?
>> >    Shouldn't we consolidate this kind of code instead of keep
> duplicating it ?
>> >
>> > 3) Any reason why we are using arbitrary numbers in all the
> layout/painting ? :) e.g. 31, 21, 50 and 18 does not say much.
>> >    (note: I'm currently fixing this one since they hurt me alot when
> trying to update the graphics to be more light/less-bulky)
>> >
>> > /max
>> > _______________________________________________
>> > jbosstools-dev mailing list
>> > jbosstools-dev at lists.jboss.org
>> > https://lists.jboss.org/mailman/listinfo/jbosstools-dev
>> >
>>
>>
>>
>> --
>> Using Opera's revolutionary e-mail client: http://www.opera.com/mail/
>> _______________________________________________
>> jbosstools-dev mailing list
>> jbosstools-dev at lists.jboss.org
>> https://lists.jboss.org/mailman/listinfo/jbosstools-dev
>
> 



-- 
Using Opera's revolutionary e-mail client: http://www.opera.com/mail/