[jbosstools-dev] Re: Hbm2DDLExporterTask logic

[Max Rydahl Andersen]

Hi Vitali,

The old schemaexport/schemaupdate had some funky logic around its settings 
so I can't say if it is a bug without running the code.

So write a test that shows that is does not do what is expected and lets work from there.

-max


>                   if(drop && create) {
>                         export.create(scriptToConsole, exportToDatabase);
>                   } else {
>                         export.execute(scriptToConsole, exportToDatabase, drop, create);
>                   }
>
> But in SchemaExport:
>
>>>>
>
>     public void create(boolean script, boolean export)
>
>     {
>
>         execute(script, export, false, false);
>
>     }
>
>>>>
>
> 
>
> Seems something wrong here - it seems should be:
>
>>>>
>
>                   if(!(drop && create)) {
>
>                         export.create(scriptToConsole, exportToDatabase);
>
>                   } else {
>
>                         export.execute(scriptToConsole, exportToDatabase,
> drop, create);
>
>                   }
>
> 
>
>  >>>
>
> Or just
>
>>>>
>
>                         export.execute(scriptToConsole, exportToDatabase,
> drop, create);
>
>>>>
>
> 
>
> Please comment the code.
>
> 
>
> Best regards,
>
> 
>
> Vitali
>
>