[jbosstools-dev] RE: JDBCReader question

[Vitali Yemialyanchyk]

I have created JDBCTablesColumnsReader - it not be difficult to incorporate
it back into JDBCReader.
But now I do not sure should we place it back. I prefer to discuss it late -
when I prepare all test cases and unit tests.

In situation with JDBCReader - I put some remarks into the code - the
difficult of situation here - 
1) Do we really need configurable solution (very configurable) to get
tables/columns?
And
2) Performance problem - I check it (create unit test) - and see what
processing of columns is a most time consuming thing;

When I create JDBCTablesColumnsReader - my answer to first question was:
We do not need such solution and simple case - JDBCTablesColumnsReader -
solve all situations which code completion requires.

Configurable solution and JDBCReader change - requires SchemaSelection new (
String matchColumn; ) member.
Also configurable solution should solve the performance problem - in this
case we should process columns only in the case when configuration requires
this - so latter we can get situation when we have some tables which columns
has not been processed - so we should handle the situation - so bulk-reading
code should be changed.

In the case when we just merge JDBCTablesColumnsReader & JDBCReader into one
- bulk-reading code should not be changed.

Vitali


-----Original Message-----
From: Max Rydahl Andersen [mailto:max.andersen at redhat.com] 
Sent: Monday, March 31, 2008 10:48 AM
To: Vitali Yemialyanchyk
Cc: jbosstools-dev at lists.jboss.org
Subject: Re: JDBCReader question

On Thu, 27 Mar 2008 20:49:22 +0100, Vitali Yemialyanchyk
<vyemialyanchyk at exadel.com> wrote:

> I am expecting such readings should be in one place and JDBCReader seems
to
> be a right place.

Your are right - what I did not understand why existing bulk-reading code
should be changed ?

/max