[jbosstools-dev] "Hibernate Configuration 3.0 XML Editor"

Wed Sep 9 13:29:41 EDT 2009

Slava,

No sense to implement new editor, even more there is someone in JIRA as a
patch - I had to modify old Exadel studio hibernate cfg editor far times
ago, but this wasn't accepted in trunk.

https://jira.jboss.org/jira/browse/JBIDE-2607 some clauses from this are
fixed. But the main feature which seems could be very useful is properties
name-value suggestion in Add Property dialog. This idea how to enhance XML
Editor - it will be great if this possible to implement in common use.

I check which common plugins are necessary for Hibernate Configuration 3.0
XML Editor:

>> 

org.jboss.tools.common.model, org.jboss.tools.common,
org.jboss.tools.common.model.ui, org.jboss.tools.common.gef,
org.jboss.tools.common.text.ext, org.jboss.tools.common.text.xml,
org.jboss.tools.common.el.core, org.jboss.tools.common.resref.core 

>> 

This is a half common plugins. 

>From here http://sourceforge.net/projects/jboss/files/ it is possible to
download Hibernate Tools separately, but there is no possibility to download
jboss.tools.common.

May be there is a sense to have common as a separate plugins bundle? Just as
idea.

Sometime people ask "I install Hibernate Tools there I can find "Hibernate
Configuration 3.0 XML Editor"? - cause there is it's description in
documentation", so it is necessary to explain what this part of Jboss Tools
and this is not included in Hibernate Tools.

So this could be a reason to include "Hibernate Configuration 3.0 XML
Editor" into Hibernate Tools and suggest the user to download and install
jboss.tools.common together with Hibernate Tools or 

have "Hibernate Configuration 3.0 XML Editor" plugins separately as some
Hibernate Tools addition extension which required jboss.tools.common.

It is interesting to hear some other opinion about the question.

Vitali

From: Viacheslav Kabanovich [mailto:scabanovich at exadel.com] 
Sent: Wednesday, September 09, 2009 7:48 PM
To: vyemialyanchyk at exadel.com; Exadel List
Cc: jbosstools-dev at lists.jboss.org
Subject: Re: [jbosstools-dev] "Hibernate Configuration 3.0 XML Editor"

Hi, Vitali, 

> I want to enhance this editor ("Hibernate Configuration 3.0 XML Editor") 

> to make it more useful and I want to integrate it into Hibernate Tools.

> For this it is necessary to separate org.jboss.tools.hibernate.xml 

> and org.jboss.tools.hibernate.xml.ui, make it detached from XModel.

In my opinion that just means implementing new editor from scratch. In doing
so, you will develop components that you may wish to put to common. We have
many xml editors, there ui has a lot in common, so why not share new
approaches between them? And that is exactly what XModel framework does.
Plugins .hibernate.xml and .hibernate.xml.ui include just few lines of code
customizing components developed in common. Why 'integrating editor into
Hibernate Tools' should mean separating it from common?

All enhancements, listed in https://jira.jboss.org/jira/browse/JBIDE-2607
may be implemented within existing editor. I am sorry I did not pay
attention to this issue before.

Slava

----- Original Message ----- 

From: Vitali Yemialyanchyk <mailto:vyemialyanchyk at exadel.com>  

To: Exadel List <mailto:external-exadel-list at redhat.com>  

Cc: jbosstools-dev at lists.jboss.org 

Sent: Wednesday, September 09, 2009 5:12 PM

Subject: [jbosstools-dev] "Hibernate Configuration 3.0 XML Editor"

Hi,

I want to start discussion of "Hibernate Configuration 3.0 XML Editor".

This rather strange editor is situated in 

trunk\hibernatetools\plugins\org.jboss.tools.hibernate.xml

trunk\hibernatetools\plugins\org.jboss.tools.hibernate.xml.ui

I call it strange cause it in hibernatetools in svn repository, but really
this is Jboss Tools thing and it was nether in Hibernate Tools.

Some users has questions about this and create such bugs in jira:

https://jira.jboss.org/jira/browse/JBIDE-4802

For them and for me (if I think about myself as Hibernate Tools user, not a
developer) it is difficult to explain, why I should take a lot of things

from JBoss Tools if I just want to use separate Hibernate Tools. As a
developer I see advantages of common things.

To make it more useful I create JIRA issue far time ago:

https://jira.jboss.org/jira/browse/JBIDE-2607

there are no changes since that time.

I want to enhance this editor to make it more useful and I want to integrate
it into Hibernate Tools.

For this it is necessary to separate org.jboss.tools.hibernate.xml and
org.jboss.tools.hibernate.xml.ui, make it detached from XModel.

So I want to hear some arguments pro/contra this solution and/or may be some
advises howto possible make this changes in better manner.

Vitali

  _____  

_______________________________________________
jbosstools-dev mailing list
jbosstools-dev at lists.jboss.org
https://lists.jboss.org/mailman/listinfo/jbosstools-dev

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.jboss.org/pipermail/jbosstools-dev/attachments/20090909/addca189/attachment.html 