[jbosstools-dev] [gitmigration] ACTION REQUIRED please respond back wether your project git repo is ok or not!

[Max Rydahl Andersen]

I 'm recalling there were some issues in the first versions of tycho that included support for source builds that would make
builds fail if these were not included and would require to hand-maintain the source features instead of just having
it build automatically for all ~250 plugin.

If that problem does not exist anymore then yes, removing the src should be fine, but if not then there are only 2-3 cases where
we have a pure plugin.xml plugin and it seems then simpler (though annoying) to just add the src folder to avoid having
to tweak pom.xml and/or source.feature for the inclusion.

Mistria - does tycho source feature automatically exclude plugins that doesn't have sources or does it enforce every plugin
listed in the original feature to have sources  (even if just empty)
/max

> ----- Original Message -----
>> Rules for use of sourceTemplateFeature/.gitkeep files and src/
>> folders
>> as they apply to Tycho builds:
>> 
>> http://wiki.eclipse.org/Minerva#Source
> 
> Yep.  Hence my comment about including a plugin without source in a source build.
> 
> So, to clarify, src is required if the plugin is included in a sources build/feature, but not for simply building the plugin.
> 
>> 
>> N
>> 
>> On 10/11/2012 02:50 PM, Rob Cernich wrote:
>>> 
>>> 
>>> ----- Original Message -----
>>>> 
>>>> 
>>>> On 10/11/2012 01:34 PM, Max Rydahl Andersen wrote:
>>>>> 
>>>>>> +1 for Base, but missing .gitkeep file:
>>>>>> 
>>>>>> common/plugins/org.jboss.tools.common.mylyn/src/.gitkeep
>>>>> 
>>>>> why does it need that folder ?
>>>> 
>>>> Because to build a plugin, you need a source folder. To then build
>>>> a
>>>> source plugin, you need a source folder (even if it's empty).
>>> 
>>> Actually, a project does not need to have a source folder.  We have
>>> a few projects that have no source folder.  M2e will add one when
>>> you import the project, but they are not checked into git and the
>>> projects build just fine in Jenkins.  I can't speak to a source
>>> build, but I wouldn't expect a source plugin to exist for a plugin
>>> without source.  For example:
>>> https://github.com/jboss-switchyard/tools/tree/master/eclipse/plugins/org.switchyard.tools.core
>>> 
>>>> 
>>>> So, based on what's in build.properties, we need a src/ folder.
>>>> QED.
>>>> 
>>>>> Here is many more changes in here than a missing src folder.
>>>> 
>>>> Yes, I also disabled building the individual root/component/site/
>>>> folders, created a root/site/ folder, and created a root/pom.xml
>>>> to
>>>> orchestrate the whole thing in one step.
>>>> 
>>>> https://github.com/nickboldt/temp-jbosstools-base/commit/32c5b97a6418d23ab51c37bc2a28fafdf51bb833
>>>> 
>>>>>> -1 for Central -- missing .gitkeep files:
>>>>>> 
>>>>>> central/features/org.jboss.tools.central.themes.feature/sourceTemplateFeature/.gitkeep
>>>>>> maven/features/org.jboss.tools.maven.gwt.feature/sourceTemplateFeature/.gitkeep
>>>>> 
>>>>> these I can understand. annyoing but thats how pde build/tycho
>>>>> works.
>>>>>> 
>>>>>> Having fixed that and updated to latest source from svn trunk,
>>>>>> won't
>>>>>> compile.
>>>>> 
>>>>> why should it compile with latest source from svn trunk ? Only
>>>>> thing expected to work together is the temp-jbosstools-* repos -
>>>>> they should be compared with what was there 7 days ago, not trunk
>>>>> now.
>>>> 
>>>> Are you saying you don't expect the code that will be branched for
>>>> Beta1
>>>> TOMORROW to be stable enough to build today? Yikes, that's not
>>>> good.
>>>> 
>>>>>> See changes in
>>>>>> https://github.com/nickboldt/temp-jbosstools-central
>>>>> also waay more changes than just gitkeep.
>>>> 
>>>> See above for explanation of pom.xml and category.xml changes.
>>>> 
>>>>>> -1 for Server - code out of date; won't compile
>>>>> 
>>>>>> See changes in
>>>>>> https://github.com/nickboldt/temp-jbosstools-server
>>>>> Also a tons of changes.
>>>> 
>>>> See above.
>>>> 
>>>>> And it compiles fine for me - what are you testing here ? not
>>>>> following at all.
>>>> 
>>>> Check out my fork from github and try it. You'll see what it's
>>>> trying
>>>> to
>>>> do (build the whole repo in one step including 3 submodules and
>>>> merged
>>>> update site) in the reactor.
>>>> 
>>>>>> -1 for JavaEE; won't compile org.jboss.tools.cdi.core
>>>>>> See changes in
>>>>>> https://github.com/nickboldt/temp-jbosstools-javaee
>>>>> same as above - not following why you think latest svn would work
>>>>> against these repos ?
>>>> 
>>>> Because if I update the sources in the forked repo to match what's
>>>> in
>>>> trunk, then point it at upstream built binaries for the rest of
>>>> JBT,
>>>> it
>>>> SHOULD work the same way the trunk jobs do. No?
>>>> 
>>>> 
>>>> --
>>>> Nick Boldt :: JBoss by Red Hat
>>>> Productization Lead :: JBoss Tools & Dev Studio
>>>> http://nick.divbyzero.com
>>>> 
>>>> 
>>>> _______________________________________________
>>>> jbosstools-dev mailing list
>>>> jbosstools-dev at lists.jboss.org
>>>> https://lists.jboss.org/mailman/listinfo/jbosstools-dev
>>>> 
>> 
>> --
>> Nick Boldt :: JBoss by Red Hat
>> Productization Lead :: JBoss Tools & Dev Studio
>> http://nick.divbyzero.com
>> 
>> 
>>