[jbosstools-dev] [gitmigration] ACTION REQUIRED please respond back wether your project git repo is ok or not!

[Andrej Podhradsky]

Hi Martin,

thank you, now it is ok.

Have a nice day!

Andrej.

----- Original Message -----
From: "Martin Malina" <mmalina at redhat.com>
To: "Max Rydahl Andersen" <max.andersen at redhat.com>
Cc: "Andrej Podhradsky" <apodhrad at redhat.com>, "jbosstools-dev jbosstools-dev" <jbosstools-dev at lists.jboss.org>
Sent: Thursday, October 18, 2012 9:46:52 PM
Subject: Re: [jbosstools-dev] [gitmigration] ACTION REQUIRED please respond back	wether your project git repo is ok or not!

Thanks. I pulled the new repo and was able to run my tests - that's a good sign. 


Also, both tests/org.jboss.tools.bpel.ui.bot.test/src/org/jboss/tools/bpel/ui/bot/ext/widgets and projects in tests/org.jboss.tools.bpel.ui.bot.test/projects/ that were missing are there now. 


Andrej, can you please check if everything is ok? You can use my fork here git://github.com/mmalina/temp-jbosstools-integration-tests.git 
This contains pom.xml, tests/pom.xml and also fixed parent definition for your tests/org.jboss.tools.bpel.ui.bot.test/pom.xml so it should work right away. 




Max, there are still both master and trunk branches. Why is that? 


Thanks, 
Martin 


On 18. 10. 2012, at 18:25, Max Rydahl Andersen < max.andersen at redhat.com > wrote: 



reran the git migration for the tests with mmalinas fix plus another fix ;) 

https://github.com/jbosstools/temp-jbosstools-integration-tests/tree/master/tests/org.jboss.tools.ui.bot.ext/src/org/jboss/tools/ui/bot/ext/widgets 

now exist. 

Please take it for a spin and see if anything else missing. 

/max 


On 17 Oct 2012, at 13:01, Max Rydahl Andersen <max.andersen at redhat.com> wrote: 



...and its a reminder how wrong it is to just svn rename something to signify deprecation/"oldness" 

if something is not used anymore - *delete* it - dont rename it. its a SCM that has history - you can always go back and get it. 

/max 

On 17 Oct 2012, at 12:42, Martin Malina <mmalina at redhat.com> wrote: 



Summarizing our discussion here: 
This should be fixed with https://github.com/maxandersen/jbosstools-gitmigration/pull/4/ 
The solution is to add the excludes to our jbosstools-integration-tests filter. Thanks catching this, Andrej! And thanks Max for seeing exactly what happened. 

Long boring explanation of what happened: 
Our filter only preserves files in _component_/_something_/*.bot*. 
So it preserved bpel/tests/org.jboss.tools.bpel.ui.bot.test AND ALSO bpel_old/tests/org.jboss.tools.bpel.ui.bot.test . 
But the filter also renames _component_/_something_/_random.bot.plugin_ to tests/_random.bot.plugin_. 
So both bpel/tests/org.jboss.tools.bpel.ui.bot.test and bpel_old/tests/org.jboss.tools.bpel.ui.bot.test were renamed to tests/org.jboss.tools.bpel.ui.bot.test. 
So basically we merged two dirs into one dir. And since the last commit in this merged dir was removing bpel_old completely, it also removed everything from this new merged dir. 
The fix is to exclude bpel_old altogether. 

-Martin 

On 17. 10. 2012, at 11:28, Max Rydahl Andersen <max.andersen at redhat.com> wrote: 



....so bpel-old *was* actually used ?! wtf... 

pinging you on irc.... 

/max 

On 16 Oct 2012, at 19:38, Martin Malina <mmalina at redhat.com> wrote: 



Hi Max, 

I'm resending this just to make sure it doesn't fall through. This is quite a big problem that we need to solve somehow. It seems that any file that was originally committed under some other path (not matching the regexp that we use for jbosstools-integration-tests) and then moved in svn under bot tests won't be included in the filtered git repo :( 

Let's talk on irc tomorrow. 

-Martin 

On 16. 10. 2012, at 19:28, Martin Malina <mmalina at redhat.com> wrote: 




On 16. 10. 2012, at 10:54, Andrej Podhradsky <apodhrad at redhat.com> wrote: 



I'm looking that some resources are also missing, namely 
http://anonsvn.jboss.org/repos/jbosstools/trunk/bpel/tests/org.jboss.tools.bpel.ui.bot.test/projects/ 

You are right again. It has to do something with the fact that the missing directories were forked from somewhere else. 
Compare this: 
https://github.com/jbosstools/jbosstools-full-svn-mirror/tree/trunk/bpel/tests/org.jboss.tools.bpel.ui.bot.test/projects 
with 
https://github.com/jbosstools/temp-jbosstools-integration-tests/tree/trunk/tests/org.jboss.tools.bpel.ui.bot.test/projects 

On the first link you can see that all the folders that disappear in the second link have this last commit message: 
https://github.com/jbosstools/jbosstools-full-svn-mirror/commit/b4ea72bf293ad7677a91a6b9c141d88ddcea0334 
https://issues.jboss.org/browse/JBDS-1810 new bpel in trunk (forked from old bpel-old/ folder) 

What I don't understand is that there is no commit containing the addition of the files. Because this last commit contains all these files under different filename - they must have been moved in bulk inside the bot test folder sometime later. But since there is no commit for it in git, when the fast filter filters the files in commit, it simply skips all these files :( We need to fix this. 

-Martin 




Andrej. 

----- Original Message ----- 
From: "Andrej Podhradsky" <apodhrad at redhat.com> 
To: "Max Rydahl Andersen" <max.andersen at redhat.com> 
Cc: "jbosstools-dev jbosstools-dev" <jbosstools-dev at lists.jboss.org> 
Sent: Tuesday, October 16, 2012 10:04:18 AM 
Subject: Re: [jbosstools-dev] [gitmigration] ACTION REQUIRED please respond back wether your project git repo is ok or not! 

Hi Max, 

in temp-jbosstools-integration-tests isn't the whole project for bpel bot tests. 
The following folder is missing 

http://anonsvn.jboss.org/repos/jbosstools/trunk/bpel/tests/org.jboss.tools.bpel.ui.bot.test/src/org/jboss/tools/bpel/ui/bot/ext/ 

Note that this isn't new folder, was added in 2011. 

Have a nice day! 

Andrej. 

----- Original Message ----- 
From: "Max Rydahl Andersen" <max.andersen at redhat.com> 
To: "jbosstools-dev jbosstools-dev" <jbosstools-dev at lists.jboss.org> 
Sent: Wednesday, October 10, 2012 6:37:52 PM 
Subject: [jbosstools-dev] [gitmigration] ACTION REQUIRED please respond back wether your project git repo is ok or not! 

Hi, 

If you have not yet taken a look at the temp-* repositories on https://github.com/jbosstools please do so ASAP 

If I haven't heard back a +1 or "hey - this works great, except for this and this" for the content of the repositories by Wednesday next week (17th) 
the git migration will be delayed/postponed *after* GA. 

Thus if you want to use git *now* is the time to go help verify the content of the repositories are sane. 

thank you! 
/max 



_______________________________________________ 
jbosstools-dev mailing list 
jbosstools-dev at lists.jboss.org 
https://lists.jboss.org/mailman/listinfo/jbosstools-dev 
_______________________________________________ 
jbosstools-dev mailing list 
jbosstools-dev at lists.jboss.org 
https://lists.jboss.org/mailman/listinfo/jbosstools-dev 
_______________________________________________ 
jbosstools-dev mailing list 
jbosstools-dev at lists.jboss.org 
https://lists.jboss.org/mailman/listinfo/jbosstools-dev 

-- 
Martin Malina 
JBoss QA Engineer 
Red Hat Czech s.r.o. 
Purkynova 99 
612 45 Brno, Czech Republic 

Tel.: +420 532 294 265 




_______________________________________________ 
jbosstools-dev mailing list 
jbosstools-dev at lists.jboss.org 
https://lists.jboss.org/mailman/listinfo/jbosstools-dev 

-- 
Martin Malina 
JBoss QA Engineer 
Red Hat Czech s.r.o. 
Purkynova 99 
612 45 Brno, Czech Republic 

Tel.: +420 532 294 265 






-- 
Martin Malina 
JBoss QA Engineer 
Red Hat Czech s.r.o. 
Purkynova 99 
612 45 Brno, Czech Republic 

Tel.: +420 532 294 265 













-- 
Martin Malina 
JBoss QA Engineer 
Red Hat Czech s.r.o. 
Purkynova 99 
612 45 Brno, Czech Republic 



Tel.: +420 532 294 265