[jbosstools-dev] Pull requests

Max Rydahl Andersen max.andersen at redhat.com
Thu Oct 25 04:36:01 EDT 2012


On topic of pullrequests a few have already come in and just a reminder on how to use these:

1) Use feature-branches, not your own master when doing a pull-request. If you do use master then when you go on to a new feature then the pullrequests that most likely is irrelevant for the new changes will have those changes too.

2) Mention the Jira in the pullrequest, add the pullrequest on the Jira - this way, no matter which why you are coming from you can find the code and the matching jira issue.

3) Do *not* use the green merge button - at minimum follow the instructions under (i) button otherwise history gets screwed over.

I wanted to have an updated contributor guide for Jboss tools ready at this time but circumstances prevented this thus I suggest you read 
https://docs.jboss.org/author/display/ISPN/Contributing+to+Infinispan until I get back and can make it jboss tools specfic.

This doc outlines how contributors and gatekeepers should use git - read it and learn.

And don't be afraid to deny a pull request if the content is broken or those practices have not been followed - with git
its ridiculously fast to fix things compared to svn so lets try and get our habits and commits to master improved.

Thanks,
/max


More information about the jbosstools-dev mailing list