[jbosstools-dev] Significant change to location of astools API

Wed Sep 19 03:05:47 EDT 2012

works for me now.

Thanks
Denis

On 09/18/2012 11:00 PM, Rob Stryker wrote:
> Thanks Dennis.
>
> I'm running the suite locally now too, since hudson seems to be having 
> big failures. Seems pretty strange because in PDE they all pass.
>
> Anyway, just committed the two missing files. I will be paying close 
> attention to what goes on.
>
> - Rob
>
> On 09/19/2012 01:32 PM, Denis Golovin wrote:
>> Rob,
>>
>> you seem to forget put some files into repository after refactoring.
>>
>> [ERROR] Failed to execute goal 
>> org.eclipse.tycho:tycho-compiler-plugin:0.15.0:compile 
>> (default-compile) on project org.jboss.ide.eclipse.as.wtp.core: 
>> Compilation failure: Compilation failure:
>> [ERROR] 
>> /home/eskimo/Projects/jbds/jbosstools-src/as/plugins/org.jboss.ide.eclipse.as.wtp.core/src/org/jboss/ide/eclipse/as/core/util/ServerAttributeHelper.java:[24,0]
>> [ERROR] import org.jboss.ide.eclipse.as.wtp.core.Messages;
>> [ERROR] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>> [ERROR] The import org.jboss.ide.eclipse.as.wtp.core.Messages cannot 
>> be resolved
>> [ERROR] 
>> /home/eskimo/Projects/jbds/jbosstools-src/as/plugins/org.jboss.ide.eclipse.as.wtp.core/src/org/jboss/ide/eclipse/as/core/util/ServerAttributeHelper.java:[111,0]
>> [ERROR] ASWTPToolsPlugin.log(IStatus.ERROR, 
>> Messages.ServerSaveFailed, e);
>> [ERROR] ^^^^^^^^
>> [ERROR] Messages cannot be resolved to a variable
>> [ERROR] 
>> /home/eskimo/Projects/jbds/jbosstools-src/as/plugins/org.jboss.ide.eclipse.as.wtp.core/src/org/jboss/ide/eclipse/as/core/util/RuntimeUtils.java:[19,0]
>> [ERROR] import org.jboss.ide.eclipse.as.wtp.core.Messages;
>> [ERROR] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>> [ERROR] The import org.jboss.ide.eclipse.as.wtp.core.Messages cannot 
>> be resolved
>> [ERROR] 
>> /home/eskimo/Projects/jbds/jbosstools-src/as/plugins/org.jboss.ide.eclipse.as.wtp.core/src/org/jboss/ide/eclipse/as/core/util/RuntimeUtils.java:[38,0]
>> [ERROR] NLS.bind(Messages.ServerRuntimeNotFound, server.getName())));
>> [ERROR] ^^^^^^^^
>> [ERROR] Messages cannot be resolved to a variable
>> [ERROR] 
>> /home/eskimo/Projects/jbds/jbosstools-src/as/plugins/org.jboss.ide.eclipse.as.wtp.core/src/org/jboss/ide/eclipse/as/core/util/RuntimeUtils.java:[62,0]
>> [ERROR] NLS.bind(Messages.ServerRuntimeNotFound, 
>> ((runtime==null)?"null":runtime.getName())))); //$NON-NLS-1$
>> [ERROR] ^^^^^^^^
>> [ERROR] Messages cannot be resolved to a variable
>> [ERROR] 
>> /home/eskimo/Projects/jbds/jbosstools-src/as/plugins/org.jboss.ide.eclipse.as.wtp.core/src/org/jboss/ide/eclipse/as/core/util/FileUtil.java:[33,0]
>> [ERROR] import org.jboss.ide.eclipse.as.wtp.core.Messages;
>> [ERROR] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>> [ERROR] The import org.jboss.ide.eclipse.as.wtp.core.Messages cannot 
>> be resolved
>> [ERROR] 
>> /home/eskimo/Projects/jbds/jbosstools-src/as/plugins/org.jboss.ide.eclipse.as.wtp.core/src/org/jboss/ide/eclipse/as/core/util/FileUtil.java:[157,0]
>> [ERROR] NLS.bind(Messages.CopyFileError, source.toString(), 
>> dest.toString()), e));
>> [ERROR] ^^^^^^^^
>> [ERROR] Messages cannot be resolved to a variable
>> [ERROR] 
>> /home/eskimo/Projects/jbds/jbosstools-src/as/plugins/org.jboss.ide.eclipse.as.wtp.core/src/org/jboss/ide/eclipse/as/core/util/FileUtil.java:[163,0]
>> [ERROR] NLS.bind(Messages.DeleteFolderError, file.toString(), e)));
>> [ERROR] ^^^^^^^^
>> [ERROR] Messages cannot be resolved to a variable
>> [ERROR] 
>> /home/eskimo/Projects/jbds/jbosstools-src/as/plugins/org.jboss.ide.eclipse.as.wtp.core/src/org/jboss/ide/eclipse/as/core/util/FileUtil.java:[169,0]
>> [ERROR] NLS.bind(Messages.DeleteFolderError, file.toString()), e));
>> [ERROR] ^^^^^^^^
>> [ERROR] Messages cannot be resolved to a variable
>> [ERROR] 
>> /home/eskimo/Projects/jbds/jbosstools-src/as/plugins/org.jboss.ide.eclipse.as.wtp.core/src/org/jboss/ide/eclipse/as/core/util/ArgsUtil.java:[22,0]
>> [ERROR] import org.jboss.ide.eclipse.as.wtp.core.Messages;
>> [ERROR] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>> [ERROR] The import org.jboss.ide.eclipse.as.wtp.core.Messages cannot 
>> be resolved
>> [ERROR] 
>> /home/eskimo/Projects/jbds/jbosstools-src/as/plugins/org.jboss.ide.eclipse.as.wtp.core/src/org/jboss/ide/eclipse/as/core/util/ArgsUtil.java:[84,0]
>> [ERROR] NLS.bind(Messages.ServerArgsParseError, s), e);
>> [ERROR] ^^^^^^^^
>> [ERROR] Messages cannot be resolved to a variable
>> [ERROR] 
>> /home/eskimo/Projects/jbds/jbosstools-src/as/plugins/org.jboss.ide.eclipse.as.wtp.core/src/org/jboss/ide/eclipse/as/core/util/IJBossToolingConstants.java:[14,0]
>> [ERROR] import org.jboss.ide.eclipse.as.wtp.core.Messages;
>> [ERROR] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>> [ERROR] The import org.jboss.ide.eclipse.as.wtp.core.Messages cannot 
>> be resolved
>> [ERROR] 
>> /home/eskimo/Projects/jbds/jbosstools-src/as/plugins/org.jboss.ide.eclipse.as.wtp.core/src/org/jboss/ide/eclipse/as/core/util/IJBossToolingConstants.java:[127,0]
>> [ERROR] public static final String JNDI_PORT_DEFAULT_XPATH = 
>> Messages.Ports + IPath.SEPARATOR + "JNDI"; //$NON-NLS-1$
>> [ERROR] ^^^^^^^^
>> [ERROR] Messages cannot be resolved to a variable
>> [ERROR] 
>> /home/eskimo/Projects/jbds/jbosstools-src/as/plugins/org.jboss.ide.eclipse.as.wtp.core/src/org/jboss/ide/eclipse/as/core/util/IJBossToolingConstants.java:[133,0]
>> [ERROR] public static final String WEB_PORT_DEFAULT_XPATH = 
>> Messages.Ports + IPath.SEPARATOR + "JBoss Web"; //$NON-NLS-1$
>> [ERROR] ^^^^^^^^
>> [ERROR] Messages cannot be resolved to a variable
>> [ERROR] 
>> /home/eskimo/Projects/jbds/jbosstools-src/as/plugins/org.jboss.ide.eclipse.as.wtp.core/src/org/jboss/ide/eclipse/as/core/util/IJBossToolingConstants.java:[139,0]
>> [ERROR] public static final String AS7_MANAGEMENT_PORT_DEFAULT_XPATH 
>> = Messages.Ports + IPath.SEPARATOR + "JBoss Management"; //$NON-NLS-1$
>> [ERROR] ^^^^^^^^
>> [ERROR] Messages cannot be resolved to a variable
>> [ERROR] 
>> /home/eskimo/Projects/jbds/jbosstools-src/as/plugins/org.jboss.ide.eclipse.as.wtp.core/src/org/jboss/ide/eclipse/as/core/util/ServerConverter.java:[29,0]
>> [ERROR] import org.jboss.ide.eclipse.as.wtp.core.Messages;
>> [ERROR] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>> [ERROR] The import org.jboss.ide.eclipse.as.wtp.core.Messages cannot 
>> be resolved
>> [ERROR] 
>> /home/eskimo/Projects/jbds/jbosstools-src/as/plugins/org.jboss.ide.eclipse.as.wtp.core/src/org/jboss/ide/eclipse/as/core/util/ServerConverter.java:[59,0]
>> [ERROR] NLS.bind(Messages.CouldNotFindServer, serverId)));
>> [ERROR] ^^^^^^^^
>> [ERROR] Messages cannot be resolved to a variable
>> [ERROR] 
>> /home/eskimo/Projects/jbds/jbosstools-src/as/plugins/org.jboss.ide.eclipse.as.wtp.core/src/org/jboss/ide/eclipse/as/core/util/ServerConverter.java:[73,0]
>> [ERROR] NLS.bind(Messages.CannotSetUpImproperServer, server.getName())));
>> [ERROR] ^^^^^^^^
>> [ERROR] Messages cannot be resolved to a variable
>> [ERROR] 
>> /home/eskimo/Projects/jbds/jbosstools-src/as/plugins/org.jboss.ide.eclipse.as.wtp.core/src/org/jboss/ide/eclipse/as/core/util/LocalCopyCallback.java:[164,0]
>> [ERROR] 
>> NLS.bind(org.jboss.ide.eclipse.as.wtp.core.Messages.PublishRenameFailure,
>> [ERROR] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>> [ERROR] org.jboss.ide.eclipse.as.wtp.core.Messages cannot be resolved 
>> to a variable
>> [ERROR] 
>> /home/eskimo/Projects/jbds/jbosstools-src/as/plugins/org.jboss.ide.eclipse.as.wtp.core/src/org/jboss/ide/eclipse/as/core/server/IJBoss6Server.java:[14,0]
>> [ERROR] import org.jboss.ide.eclipse.as.wtp.core.Messages;
>> [ERROR] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>> [ERROR] The import org.jboss.ide.eclipse.as.wtp.core.Messages cannot 
>> be resolved
>> [ERROR] 
>> /home/eskimo/Projects/jbds/jbosstools-src/as/plugins/org.jboss.ide.eclipse.as.wtp.core/src/org/jboss/ide/eclipse/as/core/server/IJBoss6Server.java:[20,0]
>> [ERROR] public static final String JMX_RMI_PORT_DEFAULT_XPATH = 
>> Messages.Ports + IPath.SEPARATOR + "JMX RMI Port"; //$NON-NLS-1$
>> [ERROR] ^^^^^^^^
>> [ERROR] Messages cannot be resolved to a variable
>> [ERROR] 21 problems (21 errors)
>> [ERROR] -> [Help 1]
>>
>> Best
>> Denis
>>
>>
>> On 09/18/2012 07:57 PM, Rob Stryker wrote:
>>> Hi All:
>>>
>>> Regarding JBIDE-11729, JBIDE-11645 
>>> <https://issues.jboss.org/browse/JBIDE-11645>, JBIDE-12613, and 
>>> others, I've pushed in a significant file move in astools. For the 
>>> most part, logic and package names were not changed. There are a few 
>>> examples where they did change, though. I've done my best to do a 
>>> usage scan and verify that nobody is using the old classes, but it's 
>>> possible I missed one.
>>>
>>> So what was done exactly?  Basically, because plugins were depending 
>>> on as.core to use some interface or utility method, an installation 
>>> of their component would drag in as.core, all our runtime and server 
>>> types, but NOT the full implementation of as7, due to declarative 
>>> services.
>>>
>>> What I've done here is I've moved a large number of interfaces and 
>>> utility classes from as.core into as.wtp.core plugin. as.core 
>>> depends on, and re-exports, as.wtp.core, so users depending on the 
>>> old interfaces should not be affected.
>>>
>>> In general, what this means is that if a component, like seam, 
>>> requires ALL of astools to be included if seam-tools are installed, 
>>> then seam-tools needs to require the astools all-inclusive feature. 
>>> Depending on plugins alone is NOT enough.
>>>
>>> If however you JUST need api access, the interfaces or common 
>>> utility methods, to provide support (but not a full dependency) for 
>>> astools, then you can depend only on o.j.ide.eclipse.as.wtp.core 
>>> plugin.
>>>
>>> Now, I'm not sure how this works in teh build system to be honest, 
>>> so I'm looking for advice from Nick / Mistria. Does the 
>>> as.wtp.core/ui plugins need their own low-level feature? Or can 
>>> other components simply depend on the single plugins?
>>>
>>> Either way, if you are writing code for a component, and find you 
>>> want to extend astools or make use of astools support in some way, 
>>> you have a decision to make. Do you need all of ASTools installed? 
>>> Or do you only need access to the api / interfaces.
>>>
>>> If you are only requiring the interfaces, you should depend only on 
>>> o.j.ide.eclipse.as.wtp.core. If you find that the plugin is missing 
>>> something that you believe should live there, then you should put in 
>>> an api request to me to move the code, utility, or extension point 
>>> from as.core into as.wtp.core. Simply depending on as.core by 
>>> yourself and using the internal api will lead to problems.
>>>
>>> What problems, you ask? Well, if you depend on as.core but do NOT 
>>> depend on the full astools feature, someone installing your 
>>> component from an update site will get your component + as.core, 
>>> which includes a half-complete jboss-7 server adapter.
>>>
>>> So... basically after this recent commit, it is now up to component 
>>> owners to decide if they need all of astools or just the api. If you 
>>> THINK you just need api, but many of the classes you need are still 
>>> in as.core, send me an email and we can discuss it, but it might 
>>> just be the case that you're forced to require all of astools until 
>>> the situation can be fixed.
>>>
>>> As always, I'm here for any questions.
>>>
>>> - Rob
>>>
>>>
>>> _______________________________________________
>>> jbosstools-dev mailing list
>>> jbosstools-dev at lists.jboss.org
>>> https://lists.jboss.org/mailman/listinfo/jbosstools-dev
>>
>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.jboss.org/pipermail/jbosstools-dev/attachments/20120919/fe9695bb/attachment-0001.html 