[jbosstools-dev] Review upcoming change to 4.30.5.Alpha6-SNAPSHOT target platform

[Max Rydahl Andersen]

On Tue, Jun 04, 2013 at 10:32:43AM -0400, Nick Boldt wrote:
>PR 2 was rejected (incomplete), but PR 3 passed validation here and
>there have been no subsequent objections in the last 7hrs, so I've
>pushed it into the repo and will be respinning the TP shortly.

eeeh - could you please give devs a chance to try this out before pushing ?! 7hrs is *not* enough time. Please be realistic
and follow the process we agreed on ! https://github.com/maxandersen/jbosstools-target-platforms/blob/tp_process/docs/updates_to_targetplatform_process.adoc

It clearly says:
"Send email to jbosstools-dev at lists.jboss.org requesting feedback

Await approvals from build, affected team leads and project lead(s). In case of urgency build + one project lead is considered ok, but should be the exception.

*THEN* apply.

..but now for the third time this is ignored.


To give feedback the changes looks good on first roll but change from planner to slicing (which I normally would consider good)
should be confirmed first. i.e. what dependencies will *not* be included now ?

These could easily escape being detected in builds thus would be great to outline them in such a change.

Have you compared the list of bundles in generated TP with and without this slicing/planner mode ?

>https://jenkins.mw.lab.eng.bos.redhat.com/hudson/job/jbosstoolstargetplatforms-matrix/
> >=111
>
>If your job(s) break after this new TP rolls out in the next hour or so,
>please let us know immediately!

>Thanks,
>
>Nick
>
>On 06/04/2013 03:18 AM, Mickael Istria wrote:
>> Hi all,
>>
>> Please review this upcoming change for the 4.30.5.Alpha6-SNAPSHOT target
>> platform: https://github.com/jbosstools/jbosstools-target-platforms/pull/2
>>
>> Summary of changes:
>> * Move to versions of Eclipse.org dependencies for Kepler RC2 (which
>> should be very close to the final version)
>> * Remove dependency on Eclipse repo and org.eclipse.update bundle
>> (previously required by old Atlassian connector)
>> * Use a snapshot SWTBot (include sources when using TP in IDE and fix
>> some issues with Hamcrest 1.3)
>> * Replaced "planner" mode by "slicer" to ensure some transitive
>> dependencies don't leak. This should avoid some occasional glitches we
>> have between mutliple and unified TP and reduce the quantity of red
>> builds for TP.
>>
>> In order to test it locally, do as follow:
>> $ cd jbosstools-target-platforms/jbosstools/multiple
>> $ mvn clean install -P\!multiple2repo
>> $ cd ~/path/to/my/jbosstools-component
>> $ mvn clean verify -Dtpc.targetKind=multiple
>>
>> If you notice any issue, please report it as a comment on
>> https://issues.jboss.org/browse/JBIDE-14729 .
>>
>> Ideally, this PR will be merged and new TP snapshot should be published
>> by the end of the day so we can have a look at how CI jobs behave with
>> this newer versions ASAP. As I'm leaving to EclipseCon France by this
>> afternoon (5pm in France), I guess Nick will be the one to ask quesitons
>> on this topic on IRC for the next few days. I'll try to follow emails.
>> --
>> Mickael Istria
>> Eclipse developer at JBoss, by Red Hat <http://www.jboss.org/tools>
>> My blog <http://mickaelistria.wordpress.com> - My Tweets
>> <http://twitter.com/mickaelistria>
>>
>>
>> _______________________________________________
>> jbosstools-dev mailing list
>> jbosstools-dev at lists.jboss.org
>> https://lists.jboss.org/mailman/listinfo/jbosstools-dev
>>
>
>-- 
>Nick Boldt :: JBoss by Red Hat
>Productization Lead :: JBoss Tools & Dev Studio
>http://nick.divbyzero.com
>_______________________________________________
>jbosstools-dev mailing list
>jbosstools-dev at lists.jboss.org
>https://lists.jboss.org/mailman/listinfo/jbosstools-dev