[jbosstools-dev] AS Test Suite failure fix?
Nick Boldt
nboldt at redhat.com
Tue Mar 19 22:33:37 EDT 2013
Does it strike no one as a problem that the tests pass against Juno SR2
but fail against Juno R? Surely they should pass against any Juno on
which we run the tests, since we can't guarantee that a user will run on
a particular version.
Or will we document this like we did for JBT 3.3 [1], to at least
ENCOURAGE users to use SR2 instead of R or SR1?
[1]
https://www.jboss.org/tools/download/installation/update_3_3#installon370371
On 03/19/2013 02:27 PM, Denis Golovin wrote:
> Hudson is actually running build agaains minimum TP, because it has no
> -Dmaximum switch in maven command line.
>
> Denis
>
> On 03/19/2013 02:10 AM, Rob Stryker wrote:
>
>> https://github.com/jbosstools/jbosstools-server/commit/b3672b46e4df710741c39ff77733246485547c8c
>>
>>
>> Denis:
>>
>> I realize the error in the test suite was that the .project file is
>> now included, whereas it was not included in the past. Why do you
>> think the proper solution to this change in behavior was to simply
>> change the expected count? That seems like a very bad fix.
>>
>> If something upstream has changed, we should discover what it is
>> before simply changing the expected count in the unit test. Clearly
>> these tests used to pass, and started failing after the update to m5.
>> Shouldn't we try to discover what exactly changed here?
>>
>> - Rob
>
> _______________________________________________
> jbosstools-dev mailing list
> jbosstools-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/jbosstools-dev
>
--
Nick Boldt :: JBoss by Red Hat
Productization Lead :: JBoss Tools & Dev Studio
http://nick.divbyzero.com
More information about the jbosstools-dev
mailing list