[jbosstools-dev] Fixes in loading jars in KB model

[Viacheslav Kabanovich]

Two issues were recently fixed in master:

KB Builder does complete scanning of content of every jar file
https://issues.jboss.org/browse/JBIDE-13837

JarAccess should ignore .class entries in jar files
https://issues.jboss.org/browse/JBIDE-13844

Since 2010, after fix of JBIDE-5764, KB Builder induced complete 
scanning of all jar files in classpath. JarAccess builds and keeps a map 
of all paths in jar for fast reference. For the last 3 years, the number 
of jars in projects (Maven Dependencies, AS Runtime) considerably 
increased; so that whereas many performance problems were solved in that 
period, the one created by KB builder and JarAccess could not be left 
without notice.

Fortunately, these two issues could be solved by trivial changes.
1. Facelet specification does not require to look for tag libraries out 
of META-INF. It is a particular case that jsf-impl.jar keeps them at 
"com/sun/faces/metadata". So, KB builder just have to implement that 
particular case rather than scan all content in jars.
2. We do not use .class entries, getting Java model objects from JDT. 
So, JarAccess in building maps can just ignore .class entries.

Since, the fix is so trivial, it could be merged into 4.0.x. Is it ok to 
have it included into 4.0.1 version, or should it wait until 4.0.2?