[jbosstools-dev] ACTION REQUIRED: POSSIBLE BETA3 BLOCKER with forge or m2e (JBIDE-17700)

[Lincoln Baxter, III]

The only place where Forge directly interacts with plexus is here:

https://github.com/forge/core/blob/master/maven/impl-projects/src/main/java/org/jboss/forge/addon/maven/projects/PlexusContainer.java#L26

As you can see, we make sure to always restore the TCCL after invoking it
(using
https://github.com/forge/furnace/blob/master/container-api/src/main/java/org/jboss/forge/furnace/util/ClassLoaders.java#L21),
because Plexus is... well... nasty and does nasty things. There was one
place where we did not do this, but don't think it's the source of the
error described above... however, just for paranoia's sake, I've added this
TCCL protection in the shutdown method as well:

https://github.com/forge/core/commit/37970feeb

~Lincoln


On Wed, Jul 2, 2014 at 6:01 PM, Nick Boldt <nboldt at redhat.com> wrote:

> Escalating to SHOUTY CAPS in subject (so mail filters won't) and adding PM
> folks to cc: so this gets to the agenda, in case it is in fact a Beta3
> blocker.
>
> As Koen is on PTO the next couple days, adding Lincoln instead. Apologies
> if someone else ought to be cc:'d instead.
>
> N
>
> On 07/02/2014 03:25 PM, Rob Stryker wrote:
>
>> Hey all:
>>
>> A user found a strange bug while using astools and publishing a zipped
>> project. The bug is basically that truezip ( a library we use) can't
>> initialize because it can't find a class. It can't find the class
>> because the thread's classloader is from plexus classrealms, and not the
>> standard eclipse classloader that we'd expect.
>>
>> So basically, either forge or m2e is changing a worker's classloader,
>> and not putting it back. This (if true) could be a critical issue, since
>> that thread / worker will probably never have the proper classloader
>> again for the workspace session.
>>
>> I encourage anyone with access to m2e or forge to look into this and
>> verify their respective codebases are behaving properly with regards to
>> classloaders. Feel free to look at the jira and ask any for more details
>> or any questions you might have that might help in tracking this down.
>>
>> https://issues.jboss.org/browse/JBIDE-17700
>> _______________________________________________
>> jbosstools-dev mailing list
>> jbosstools-dev at lists.jboss.org
>> https://lists.jboss.org/mailman/listinfo/jbosstools-dev
>>
>>
> --
> Nick Boldt :: JBoss by Red Hat
> Productization Lead :: JBoss Tools & Dev Studio
> http://nick.divbyzero.com
>



-- 
Lincoln Baxter, III
http://ocpsoft.org
"Simpler is better."
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.jboss.org/pipermail/jbosstools-dev/attachments/20140702/ff522121/attachment.html