[jbosstools-dev] Central build failure

[Snjezana Peco]

On 7/7/2014 7:10 PM, Snjezana Peco wrote:
> On 7/7/2014 1:03 PM, Max Rydahl Andersen wrote:
>> On 7 Jul 2014, at 10:36, Mickael Istria wrote:
>>
>>> On 07/05/2014 07:03 PM, Snjezana Peco wrote:
>>>> The Hibernate build fails because there are the same class names
>>>> within
>>>> the hibernate component (there are four
>>>> org.jboss.tools.hibernate.proxy.SessionFactoryProxy, for instance).
>>>> See
>>>> https://issues.jboss.org/browse/JBIDE-17551
>>> This was already reported for master, and I just removed the Jacoco
>>> step from build to get it working. So Hibernate doesn't have Jacoco
>>> coverage any more.
>>> I'm not sure your patch is better than just disabling jacoco. Since it
>>> ignores all stuff from hibernate, the results of coverage for
>>> Hibernate will most likely become quite useless, so IMO, just removing
>>> the Jacoco step for Hibernate on branch would have been a cleaner fix
>>> that implementing exceptions in the script (that we'll for sure forget
>>> to remove if one day we re-enable Jacoco for Hibernate builds).
>> I still don't get why this is suddenly a new problem -  hibernate tools
>> have for years had multiple versions of the same classnames because it
>> has multiple version support.
>>
>> What is so different about these?
> I am not sure, but the
> org.jboss.tools.hibernate.proxy.SessionFactoryProxy class is a new
> class. I will try to reproduce the issue locally.

The issue can be reproduced locally. Excluding 
org.jboss.tools.hibernate.proxy.*.class from the classfiles element 
fixes it. It seems that only some duplicate classes break jacoco. 
Hibernate also contains duplicate classes in the 
org.jboss.tools.hibernate.util package, but they don't cause any issues.

Snjeza

> Snjeza
>
>> /max
>> http://about.me/maxandersen
>> _______________________________________________
>> jbosstools-dev mailing list
>> jbosstools-dev at lists.jboss.org
>> https://lists.jboss.org/mailman/listinfo/jbosstools-dev
> _______________________________________________
> jbosstools-dev mailing list
> jbosstools-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/jbosstools-dev