[jbosstools-dev] Proposed change to JBoss Central 4.40.0.Beta3-SNAPSHOT target platform: updated version of PMD & removal of duplicate content already in upstream TP

[Max Rydahl Andersen]

On 10 Jun 2014, at 3:30, Nick Boldt wrote:

> Here is a proposal for a change to the JBoss Central
> 4.40.0.Beta3-SNAPSHOT target platform:
>
> 1. 
> https://github.com/jbosstools/jbosstools-download.jboss.org/pull/368
>
> 2. https://github.com/jbosstools/jbosstools-discovery/pull/168
>
> It consists in the following change:
>
> * JBIDE-14971 Generate Abstract Syntax Tree fails - so update to PMD 
> 4.0.3
>
> I would also like to push this PR, which resolves missing upstream
> dependencies by merging the Central (and new Central Early Access TP)
> with the JBT TP.
>
> https://github.com/jbosstools/jbosstools-discovery/pull/167

Any mention of "merging" content from Early Access TP worries me ;)

What is the actual resulting diff here ? your p2diff shows zero 
differences so
that is worrisome.

trying to grok the PR changes but i'm honestly not following the actual 
change ;/

What is the "merge" you want to do ? Earlyaccess should have *zero* 
overlap with the core TP and should not *add* new things to it to begin 
with so
there must be something i'm not grokking here...?

/max
http://about.me/maxandersen